From: Joe Perches <joe@perches.com>
To: netdev@vger.kernel.org
Cc: Anil Murthy <anil.murthy@neterion.com>,
Sreenivasa Honnur <sreenivasa.honnur@neterion.com>,
Sivakumar Subramani <sivakumar.subramani@neterion.com>,
Rastapur Santosh <santosh.rastapur@neterion.com>,
Ramkrishna Vepa <ram.vepa@neterion.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-next@vger.kernel.org
Subject: [PATCH 6/9] s2io.c: convert printks to pr_<level>
Date: Mon, 24 Aug 2009 20:29:45 -0700 [thread overview]
Message-ID: <8447fcff04cb998aba685033f605787876e8e41a.1251170438.git.joe@perches.com> (raw)
In-Reply-To: <cover.1251170438.git.joe@perches.com>
Fixed trivial typo as well
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/s2io.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 003dd8c..2805edd 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -54,6 +54,8 @@
* Possible values '1' for enable and '0' for disable. Default is '0'
************************************************************************/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/module.h>
#include <linux/types.h>
#include <linux/errno.h>
@@ -5547,8 +5549,7 @@ static int s2io_ethtool_idnic(struct net_device *dev, u32 data)
if ((sp->device_type == XFRAME_I_DEVICE) && ((subid & 0xFF) < 0x07)) {
val64 = readq(&bar0->adapter_control);
if (!(val64 & ADAPTER_CNTL_EN)) {
- printk(KERN_ERR
- "Adapter Link down, cannot blink LED\n");
+ pr_err("Adapter Link down, cannot blink LED\n");
return -EFAULT;
}
}
@@ -7130,8 +7131,7 @@ static int s2io_add_isr(struct s2io_nic *sp)
}
}
if (!err) {
- printk(KERN_INFO "MSI-X-RX %d entries enabled\n",
- --msix_rx_cnt);
+ pr_info("MSI-X-RX %d entries enabled\n", --msix_rx_cnt);
DBG_PRINT(INFO_DBG, "MSI-X-TX entries enabled"
" through alarm vector\n");
}
@@ -8724,8 +8724,7 @@ static pci_ers_result_t s2io_io_slot_reset(struct pci_dev *pdev)
struct s2io_nic *sp = netdev_priv(netdev);
if (pci_enable_device(pdev)) {
- printk(KERN_ERR "s2io: "
- "Cannot re-enable PCI device after reset.\n");
+ pr_err("Cannot re-enable PCI device after reset.\n");
return PCI_ERS_RESULT_DISCONNECT;
}
@@ -8749,15 +8748,13 @@ static void s2io_io_resume(struct pci_dev *pdev)
if (netif_running(netdev)) {
if (s2io_card_up(sp)) {
- printk(KERN_ERR "s2io: "
- "Can't bring device back up after reset.\n");
+ pr_err("Can't bring device back up after reset.\n");
return;
}
if (s2io_set_mac_addr(netdev, netdev->dev_addr) == FAILURE) {
s2io_card_down(sp);
- printk(KERN_ERR "s2io: "
- "Can't resetore mac addr after reset.\n");
+ pr_err("Can't restore mac addr after reset.\n");
return;
}
}
--
1.6.3.1.10.g659a0.dirty
next prev parent reply other threads:[~2009-08-25 3:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 3:29 [PATCH 0/9] drivers/net/s2io.c: Cleanups Joe Perches
2009-08-25 3:29 ` [PATCH 1/9] s2io.c: Use const for strings Joe Perches
2009-08-25 3:29 ` [PATCH 2/9] s2io.c: Shorten code line length by using intermediate pointers Joe Perches
2009-08-25 3:29 ` [PATCH 3/9] s2io.c: Use calculated size in kmallocs Joe Perches
2009-08-25 3:29 ` [PATCH 4/9] s2io.c: use kzalloc Joe Perches
2009-08-25 3:29 ` [PATCH 5/9] s2io.c: Make more conforming to normal kernel style Joe Perches
2009-08-25 3:29 ` Joe Perches [this message]
2009-08-25 3:29 ` [PATCH 7/9] s2io.c: fix spelling explaination Joe Perches
2009-08-25 3:29 ` [PATCH 8/9] s2io.c: Standardize statistics accessors Joe Perches
2009-08-25 3:29 ` [PATCH 9/9] s2io.c: Convert skipped nic->config.tx_cfg[i]. to tx_cfg-> Joe Perches
2009-08-25 18:52 ` [PATCH 10/9] s2io: Generate complete messages using single line DBG_PRINTs Joe Perches
2009-08-26 22:33 ` [PATCH 0/9] drivers/net/s2io.c: Cleanups David Miller
2009-08-26 22:47 ` Joe Perches
2009-08-27 2:45 ` Ramkrishna Vepa
2009-08-31 5:21 ` Sreenivasa Honnur
2009-08-31 5:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8447fcff04cb998aba685033f605787876e8e41a.1251170438.git.joe@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=anil.murthy@neterion.com \
--cc=davem@davemloft.net \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@neterion.com \
--cc=santosh.rastapur@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox