Linux-Next discussions
 help / color / mirror / Atom feed
From: "NeilBrown" <neilb@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, Cheng Renquan <crquan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: md tree build warnings
Date: Thu, 20 Nov 2008 16:24:46 +1100 (EST)	[thread overview]
Message-ID: <a441d5f4cdd1d529e288149f659b553c.squirrel@neil.brown.name> (raw)
In-Reply-To: <20081120161056.47b6130e.sfr@canb.auug.org.au>

On Thu, November 20, 2008 4:10 pm, Stephen Rothwell wrote:
> Hi Neil,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced these new
> warnings:
>
> drivers/md/md.c: In function 'print_sb_1':
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 3 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 7 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 8 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 9 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 10 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Lu' expects type 'long long
> unsigned int', but argument 29 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 30 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 31 has type '__le64'
>
> Added by commit 4c3da1f23cf20603339493525adf8903a5722417 "md: need
> another print_sb for mdp_superblock_1".  We cast 64 bit quantities to
> "unsigned long long" when we print them since they are just "unsigned
> long" on some architectures.  Also since they are __le64, will they print
> anything useful on a big endian architecture?


Thanks.  Insufficient review on my part.  I'll get it sorted before you
next pull.

NeilBrown

      parent reply	other threads:[~2008-11-20  5:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-20  5:10 linux-next: md tree build warnings Stephen Rothwell
2008-11-20  5:20 ` Stephen Rothwell
2008-11-20  5:21 ` rae l
2008-11-20  5:24 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a441d5f4cdd1d529e288149f659b553c.squirrel@neil.brown.name \
    --to=neilb@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=crquan@gmail.com \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox