linux-next: md tree build warnings

linux-next: md tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

Hi Neil,

Today's linux-next build (powerpc ppc64_defconfig) produced these new
warnings:

drivers/md/md.c: In function 'print_sb_1':
drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 3 has type '__le64'
drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 7 has type '__le64'
drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 8 has type '__le64'
drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 9 has type '__le64'
drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 10 has type '__le64'
drivers/md/md.c:1698: warning: format '%Lu' expects type 'long long unsigned int', but argument 29 has type '__le64'
drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 30 has type '__le64'
drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 31 has type '__le64'

Added by commit 4c3da1f23cf20603339493525adf8903a5722417 "md: need
another print_sb for mdp_superblock_1".  We cast 64 bit quantities to
"unsigned long long" when we print them since they are just "unsigned
long" on some architectures.  Also since they are __le64, will they print
anything useful on a big endian architecture?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: md tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

Hi Neil,

On Thu, 20 Nov 2008 16:10:56 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (powerpc ppc64_defconfig) produced these new
> warnings:
> 
> drivers/md/md.c: In function 'print_sb_1':
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 3 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 7 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 8 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 9 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 10 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Lu' expects type 'long long unsigned int', but argument 29 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 30 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 31 has type '__le64'

This was especially noticeable because it more than doubled the number of
warnings from that build :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: md tree build warnings

[rae l]

On Thu, Nov 20, 2008 at 1:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Neil,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced these new
> warnings:
>
> drivers/md/md.c: In function 'print_sb_1':
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 3 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 7 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 8 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 9 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 10 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Lu' expects type 'long long unsigned int', but argument 29 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 30 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int', but argument 31 has type '__le64'
>
> Added by commit 4c3da1f23cf20603339493525adf8903a5722417 "md: need
> another print_sb for mdp_superblock_1".  We cast 64 bit quantities to
> "unsigned long long" when we print them since they are just "unsigned
> long" on some architectures.  Also since they are __le64, will they print
> anything useful on a big endian architecture?

That's my problem, I'm checking __le64 to cpu_le64 at once, and will
post another patch later.

>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>



-- 
Cheng Renquan, Shenzhen, China
Dan Quayle  - "This President is going to lead us out of this recovery."

Re: linux-next: md tree build warnings

[NeilBrown]

On Thu, November 20, 2008 4:10 pm, Stephen Rothwell wrote:
> Hi Neil,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced these new
> warnings:
>
> drivers/md/md.c: In function 'print_sb_1':
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 3 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 7 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 8 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 9 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 10 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Lu' expects type 'long long
> unsigned int', but argument 29 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 30 has type '__le64'
> drivers/md/md.c:1698: warning: format '%Ld' expects type 'long long int',
> but argument 31 has type '__le64'
>
> Added by commit 4c3da1f23cf20603339493525adf8903a5722417 "md: need
> another print_sb for mdp_superblock_1".  We cast 64 bit quantities to
> "unsigned long long" when we print them since they are just "unsigned
> long" on some architectures.  Also since they are __le64, will they print
> anything useful on a big endian architecture?


Thanks.  Insufficient review on my part.  I'll get it sorted before you
next pull.

NeilBrown