linux-next: build failure in the final build

linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

Hi all,

After the final merge today's linux-next build (arm64 allyesconfig)
failed like this, the same issue will be present in mainline:

error: field `device` is never read
  --> /tmp/next/build/drivers/gpu/drm/tyr/driver.rs:37:5
   |
36 | pub(crate) struct TyrDriver {
   |                   --------- field in this struct
37 |     device: ARef<TyrDevice>,
   |     ^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

error: fields `mali` and `sram` are never read
   --> /tmp/next/build/drivers/gpu/drm/tyr/driver.rs:196:5
    |
195 | struct Regulators {
    |        ---------- fields in this struct
196 |     mali: Regulator<regulator::Enabled>,
    |     ^^^^
197 |     sram: Regulator<regulator::Enabled>,
    |     ^^^^

error: aborting due to 2 previous errors

Caused by commit

   cf4fd52e32360 (rust: drm: Introduce the Tyr driver for Arm Mali GPUs)

I am continuing to mark the driver as BROKEN.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure in the final build

[Miguel Ojeda]

On Wed, Jan 21, 2026 at 6:14 PM Mark Brown <broonie@kernel.org> wrote:
>
> After the final merge today's linux-next build (arm64 allyesconfig)
> failed like this, the same issue will be present in mainline:

> Caused by commit
>
>    cf4fd52e32360 (rust: drm: Introduce the Tyr driver for Arm Mali GPUs)
>
> I am continuing to mark the driver as BROKEN.

Cc'ing Daniel as maintainer of Tyr and author of the commit -- somehow
he wasn't Cc'd?

Thanks Mark!

Cheers,
Miguel

Re: linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On Wed, Jan 21, 2026 at 06:18:06PM +0100, Miguel Ojeda wrote:

> Cc'ing Daniel as maintainer of Tyr and author of the commit -- somehow
> he wasn't Cc'd?

Ah, sorry - I missed his signoff below the Link: trailer separate to the
rest of the author signoffs.  Copying the Cc list from the blamed commit
is a manual process for build failures, my mistake.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure in the final build

[Miguel Ojeda]

On Wed, Jan 21, 2026 at 6:25 PM Mark Brown <broonie@kernel.org> wrote:
>
> Ah, sorry - I missed his signoff below the Link: trailer separate to the
> rest of the author signoffs.  Copying the Cc list from the blamed commit
> is a manual process for build failures, my mistake.

No worries, happy to help! I indeed thought that part was probably
semi-automated.

Cheers,
Miguel

Re: linux-next: build failure in the final build

[Alice Ryhl]

On Wed, Jan 21, 2026 at 05:14:15PM +0000, Mark Brown wrote:
> Hi all,
> 
> After the final merge today's linux-next build (arm64 allyesconfig)
> failed like this, the same issue will be present in mainline:
> 
> error: field `device` is never read
>   --> /tmp/next/build/drivers/gpu/drm/tyr/driver.rs:37:5
>    |
> 36 | pub(crate) struct TyrDriver {
>    |                   --------- field in this struct
> 37 |     device: ARef<TyrDevice>,
>    |     ^^^^^^
>    |
>    = note: `-D dead-code` implied by `-D warnings`
>    = help: to override `-D warnings` add `#[allow(dead_code)]`
> 
> error: fields `mali` and `sram` are never read
>    --> /tmp/next/build/drivers/gpu/drm/tyr/driver.rs:196:5
>     |
> 195 | struct Regulators {
>     |        ---------- fields in this struct
> 196 |     mali: Regulator<regulator::Enabled>,
>     |     ^^^^
> 197 |     sram: Regulator<regulator::Enabled>,
>     |     ^^^^
> 
> error: aborting due to 2 previous errors
> 
> Caused by commit
> 
>    cf4fd52e32360 (rust: drm: Introduce the Tyr driver for Arm Mali GPUs)
> 
> I am continuing to mark the driver as BROKEN.

Hrm I saw you had this last time too. I'm not sure how you're triggering
it - I haven't run into it myself and I do enable warnings. But I'll try
to repro and fix it.

Note that for this kind of thing you can add `#![allow(warnings)]` to
the top of a file to silence warnings.

Alice

Re: linux-next: build failure in the final build

[Miguel Ojeda]

On Wed, Jan 21, 2026 at 8:14 PM Alice Ryhl <aliceryhl@google.com> wrote:
>
> Hrm I saw you had this last time too. I'm not sure how you're triggering
> it - I haven't run into it myself and I do enable warnings. But I'll try
> to repro and fix it.
>
> Note that for this kind of thing you can add `#![allow(warnings)]` to
> the top of a file to silence warnings.

Mark: we are in a call right now and Danilo asked about this -- I have
a similar issue with CI with `bounded.rs` in 1.80.0, so Danilo tested
1.80.0 and 1.80.1 and indeed 1.80.0 is broken.

We are upping the minimum to 1.85.0 soon, so it is not a big deal.

Could you please upgrade to Rust 1.80.1 at least for linux-next runs?
Where are you taking the toolchain from? i.e. I would expect a distro
to provide the fixed .1

We hope that helps!

Cheers,
Miguel

Re: linux-next: build failure in the final build

[Deborah Brouwer]

On Wed, Jan 21, 2026 at 07:14:38PM +0000, Alice Ryhl wrote:
> On Wed, Jan 21, 2026 at 05:14:15PM +0000, Mark Brown wrote:
> > Hi all,
> > 
> > After the final merge today's linux-next build (arm64 allyesconfig)
> > failed like this, the same issue will be present in mainline:
> > 
> > error: field `device` is never read
> >   --> /tmp/next/build/drivers/gpu/drm/tyr/driver.rs:37:5
> >    |
> > 36 | pub(crate) struct TyrDriver {
> >    |                   --------- field in this struct
> > 37 |     device: ARef<TyrDevice>,
> >    |     ^^^^^^
> >    |
> >    = note: `-D dead-code` implied by `-D warnings`
> >    = help: to override `-D warnings` add `#[allow(dead_code)]`
> > 
> > error: fields `mali` and `sram` are never read
> >    --> /tmp/next/build/drivers/gpu/drm/tyr/driver.rs:196:5
> >     |
> > 195 | struct Regulators {
> >     |        ---------- fields in this struct
> > 196 |     mali: Regulator<regulator::Enabled>,
> >     |     ^^^^
> > 197 |     sram: Regulator<regulator::Enabled>,
> >     |     ^^^^
> > 
> > error: aborting due to 2 previous errors
> > 
> > Caused by commit
> > 
> >    cf4fd52e32360 (rust: drm: Introduce the Tyr driver for Arm Mali GPUs)
> > 
> > I am continuing to mark the driver as BROKEN.
> 
> Hrm I saw you had this last time too. I'm not sure how you're triggering
> it - I haven't run into it myself and I do enable warnings. But I'll try
> to repro and fix it.

Although I hadn't seen this error before I was able to reproduce it
today on linux-next/master so I don't know if it's too late, but here is
a quick fix.

https://lore.kernel.org/rust-for-linux/20260122003746.405370-1-deborah.brouwer@collabora.com/

> 
> Note that for this kind of thing you can add `#![allow(warnings)]` to
> the top of a file to silence warnings.
> 
> Alice

Re: linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

On Wed, Jan 21, 2026 at 07:14:38PM +0000, Alice Ryhl wrote:

> Note that for this kind of thing you can add `#![allow(warnings)]` to
> the top of a file to silence warnings.

That's not really the sort of thing we apply to -next usually.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Wed, Jan 21, 2026 at 08:24:07PM +0100, Miguel Ojeda wrote:
> On Wed, Jan 21, 2026 at 8:14 PM Alice Ryhl <aliceryhl@google.com> wrote:

> > Note that for this kind of thing you can add `#![allow(warnings)]` to
> > the top of a file to silence warnings.

> Mark: we are in a call right now and Danilo asked about this -- I have
> a similar issue with CI with `bounded.rs` in 1.80.0, so Danilo tested
> 1.80.0 and 1.80.1 and indeed 1.80.0 is broken.

> We are upping the minimum to 1.85.0 soon, so it is not a big deal.

> Could you please upgrade to Rust 1.80.1 at least for linux-next runs?
> Where are you taking the toolchain from? i.e. I would expect a distro
> to provide the fixed .1

I've just got the default toolchain in Debian stable which appears to be
1.85.0.

ii  rustc                                 1.85.0+dfsg3-1                       arm64        Rust systems programming language

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi all,

In the final build, today's linux-next build (arm64 allyesconfig)
failed like this:

/tmp/next/build/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:82:12: error: 'lpi_gpio_write' defined but not used [-Werror=unused-function]
   82 | static int lpi_gpio_write(struct lpi_pinctrl *state, unsigned int pin,
      |            ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors make[6]:

The failure also shows up in a defconfig build but that doesn't enable
-Werror.  I have ignored this issue for today.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure in the final build

[Mark Brown]

Hi all,

In the final build, today's linux-next build (arm64 allyesconfig) failed
like this:

ld: drivers/net/wireless/nxp/nxpwifi/main.o: in function `is_command_pending':
main.c:(.text+0xa348): multiple definition of `is_command_pending'; drivers/net/wireless/marvell/mwifiex/main.o:main.c:(.text+0xc188): first defined here
ld: drivers/net/wireless/nxp/nxpwifi/main.o:(.data+0xa80): multiple definition of `driver_version'; drivers/net/wireless/marvell/mwifiex/main.o:(.rodata+0x2c00): first defined here
ld: drivers/net/wireless/nxp/nxpwifi/cfp.o:(.data+0x740): multiple definition of `region_code_index'; drivers/net/wireless/marvell/mwifiex/cfp.o:(.data+0x840): first defined here
ld: drivers/net/wireless/nxp/nxpwifi/wmm.o:(.rodata+0xda0): multiple definition of `tos_to_tid_inv'; drivers/net/wireless/marvell/mwifiex/wmm.o:(.rodata+0xe60): first defined here

due to

   4c477f8bfc1a8 (wifi: nxp: add nxpwifi driver for IW61x)

I have ignored that for today.

Re: linux-next: build failure in the final build

[Johannes Berg]

On Mon, 2026-07-06 at 15:50 +0100, Mark Brown wrote:
> Hi all,
> 
> In the final build, today's linux-next build (arm64 allyesconfig) failed
> like this:
> 
> ld: drivers/net/wireless/nxp/nxpwifi/main.o: in function `is_command_pending':
> main.c:(.text+0xa348): multiple definition of `is_command_pending'; drivers/net/wireless/marvell/mwifiex/main.o:main.c:(.text+0xc188): first defined here
> ld: drivers/net/wireless/nxp/nxpwifi/main.o:(.data+0xa80): multiple definition of `driver_version'; drivers/net/wireless/marvell/mwifiex/main.o:(.rodata+0x2c00): first defined here
> ld: drivers/net/wireless/nxp/nxpwifi/cfp.o:(.data+0x740): multiple definition of `region_code_index'; drivers/net/wireless/marvell/mwifiex/cfp.o:(.data+0x840): first defined here
> ld: drivers/net/wireless/nxp/nxpwifi/wmm.o:(.rodata+0xda0): multiple definition of `tos_to_tid_inv'; drivers/net/wireless/marvell/mwifiex/wmm.o:(.rodata+0xe60): first defined here
> 
> due to
> 
>    4c477f8bfc1a8 (wifi: nxp: add nxpwifi driver for IW61x)
> 

Well. I've dropped the merge then. Jeff, please resend with things fixed
up.

johannes

linux-next: Build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 2710 bytes --]

On Tue, Jul 07, 2026 at 01:11:55PM +0100, Mark Brown wrote:

> After merging the kvm-arm-fixes tree, today's linux-next build
> (arm64 defconfig) started generating warnings:

> In file included from /tmp/next/build/include/linux/limits.h:7,
>                  from /tmp/next/build/include/linux/overflow.h:6,
>                  from /tmp/next/build/include/linux/bits.h:32,
>                  from /tmp/next/build/arch/arm64/include/asm/kvm_pgtable.h:10,
>                  from /tmp/next/build/arch/arm64/kvm/hyp/pgtable.c:11:
> /tmp/next/build/arch/arm64/kvm/hyp/pgtable.c: In function 'kvm_pgtable_stage2_relax_perms':
> /tmp/next/build/include/vdso/limits.h:8:25: warning: overflow in conversion from 'int' to 's8' {aka 'signed char'} changes value from '2147483647' to '-1' [-Woverflow]
>     8 | #define INT_MAX         ((int)(~0U >> 1))
>       |                         ^
> /tmp/next/build/arch/arm64/include/asm/tlbflush.h:131:33: note: in expansion of macro 'INT_MAX'
>   131 | #define TLBI_TTL_UNKNOWN        INT_MAX
>       |                                 ^~~~~~~
> /tmp/next/build/arch/arm64/kvm/hyp/pgtable.c:1361:20: note: in expansion of macro 'TLBI_TTL_UNKNOWN'
>  1361 |         s8 level = TLBI_TTL_UNKNOWN;
>       |                    ^~~~~~~~~~~~~~~~
> In file included from /tmp/next/build/include/linux/limits.h:7,
>                  from /tmp/next/build/include/linux/overflow.h:6,
>                  from /tmp/next/build/include/linux/bits.h:32,
>                  from /tmp/next/build/arch/arm64/include/asm/kvm_pgtable.h:10,
>                  from /tmp/next/build/arch/arm64/kvm/hyp/nvhe/../pgtable.c:11:
> /tmp/next/build/arch/arm64/kvm/hyp/nvhe/../pgtable.c: In function 'kvm_pgtable_stage2_relax_perms':
> /tmp/next/build/include/vdso/limits.h:8:25: warning: overflow in conversion from 'int' to 's8' {aka 'signed char'} changes value from '2147483647' to '-1' [-Woverflow]
>     8 | #define INT_MAX         ((int)(~0U >> 1))
>       |                         ^
> /tmp/next/build/arch/arm64/include/asm/tlbflush.h:131:33: note: in expansion of macro 'INT_MAX'
>   131 | #define TLBI_TTL_UNKNOWN        INT_MAX
>       |                                 ^~~~~~~
> /tmp/next/build/arch/arm64/kvm/hyp/nvhe/../pgtable.c:1361:20: note: in expansion of macro 'TLBI_TTL_UNKNOWN'
>  1361 |         s8 level = TLBI_TTL_UNKNOWN;
>       |                    ^~~~~~~~~~~~~~~~

> Caused by commit

>    100baf0184896 (KVM: arm64: Ensure level is always initialized when relaxing perms)

> I imagine this will cause an allyesconfig build failure when I get to
> that due to -Werror.

Confirmed, nothing later in the merge fixed the warning so -Werror
triggered breaking arm64 allyesconfig.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 4478 bytes --]

Hi all,

In the final builds, today's linux-next build (arm64 allyesconfig)
failed like this:

/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:105:5: error: no previous
prototype for 'write_ulpi' [-Werror=missing-prototypes]
  105 | int write_ulpi(u8 addr, u8 data)
      |     ^~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:118:6: error: no previous
prototype for 'fsl_otg_chrg_vbus' [-Werror=missing-prototypes]
  118 | void fsl_otg_chrg_vbus(struct otg_fsm *fsm, int on)
      |      ^~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:136:6: error: no previous
prototype for 'fsl_otg_dischrg_vbus' [-Werror=missing-prototypes]
  136 | void fsl_otg_dischrg_vbus(int on)
      |      ^~~~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:154:6: error: no previous
prototype for 'fsl_otg_drv_vbus' [-Werror=missing-prototypes]
  154 | void fsl_otg_drv_vbus(struct otg_fsm *fsm, int on)
      |      ^~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:172:6: error: no previous
prototype for 'fsl_otg_loc_conn' [-Werror=missing-prototypes]
  172 | void fsl_otg_loc_conn(struct otg_fsm *fsm, int on)
      |      ^~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:191:6: error: no previous
prototype for 'fsl_otg_loc_sof' [-Werror=missing-prototypes]
  191 | void fsl_otg_loc_sof(struct otg_fsm *fsm, int on)
      |      ^~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:206:6: error: no previous
prototype for 'fsl_otg_start_pulse' [-Werror=missing-prototypes]
  206 | void fsl_otg_start_pulse(struct otg_fsm *fsm)
      |      ^~~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:222:6: error: no previous
prototype for 'b_data_pulse_end' [-Werror=missing-prototypes]
  222 | void b_data_pulse_end(unsigned long foo)
      |      ^~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:241:6: error: no previous
prototype for 'b_vbus_pulse_end' [-Werror=missing-prototypes]
  241 | void b_vbus_pulse_end(unsigned long foo)
      |      ^~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:254:6: error: no previous
prototype for 'b_srp_end' [-Werror=missing-prototypes]
  254 | void b_srp_end(unsigned long foo)
      |      ^~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:269:6: error: no previous
prototype for 'a_wait_enum' [-Werror=missing-prototypes]
  269 | void a_wait_enum(unsigned long foo)
      |      ^~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:279:6: error: no previous
prototype for 'set_tmout' [-Werror=missing-prototypes]
  279 | void set_tmout(unsigned long indicator)
      |      ^~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:285:5: error: no previous
prototype for 'fsl_otg_init_timers' [-Werror=missing-prototypes]
  285 | int fsl_otg_init_timers(struct otg_fsm *fsm)
      |     ^~~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:342:6: error: no previous
prototype for 'fsl_otg_uninit_timers' [-Werror=missing-prototypes]
  342 | void fsl_otg_uninit_timers(void)
      |      ^~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:446:6: error: no previous
prototype for 'otg_reset_controller' [-Werror=missing-prototypes]
  446 | void otg_reset_controller(void)
      |      ^~~~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:458:5: error: no previous
prototype for 'fsl_otg_start_host' [-Werror=missing-prototypes]
  458 | int fsl_otg_start_host(struct otg_fsm *fsm, int on)
      |     ^~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:525:5: error: no previous
prototype for 'fsl_otg_start_gadget' [-Werror=missing-prototypes]
  525 | int fsl_otg_start_gadget(struct otg_fsm *fsm, int on)
      |     ^~~~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:707:13: error: no previous
prototype for 'fsl_otg_isr' [-Werror=missing-prototypes]
  707 | irqreturn_t fsl_otg_isr(int irq, void *dev_id)
      |             ^~~~~~~~~~~
/tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:833:5: error: no previous
prototype for 'usb_otg_start' [-Werror=missing-prototypes]
  833 | int usb_otg_start(struct platform_device *pdev)
      |     ^~~~~~~~~~~~~
cc1: all warnings being treated as errors make[6]:

It looks like this is a change in dependencies which has allowed this to
be built from today, I didn't isolate exactly what - it looks like the
issue is missing statics on all these function definitions, making them
global.  I have ignored this for today.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 4985 bytes --]

On Mon, Jul 13, 2026 at 06:48:32PM +0100, Mark Brown wrote:
> Hi all,
> 
> In the final builds, today's linux-next build (arm64 allyesconfig)
> failed like this:

This error is due to a71f5aef1be98 (USB: gadget: fsl-udc: enable compile
testing) from the usb tree, a dependency change as expected.  I'll do
something about this tomorrow.

> 
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:105:5: error: no previous
> prototype for 'write_ulpi' [-Werror=missing-prototypes]
>   105 | int write_ulpi(u8 addr, u8 data)
>       |     ^~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:118:6: error: no previous
> prototype for 'fsl_otg_chrg_vbus' [-Werror=missing-prototypes]
>   118 | void fsl_otg_chrg_vbus(struct otg_fsm *fsm, int on)
>       |      ^~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:136:6: error: no previous
> prototype for 'fsl_otg_dischrg_vbus' [-Werror=missing-prototypes]
>   136 | void fsl_otg_dischrg_vbus(int on)
>       |      ^~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:154:6: error: no previous
> prototype for 'fsl_otg_drv_vbus' [-Werror=missing-prototypes]
>   154 | void fsl_otg_drv_vbus(struct otg_fsm *fsm, int on)
>       |      ^~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:172:6: error: no previous
> prototype for 'fsl_otg_loc_conn' [-Werror=missing-prototypes]
>   172 | void fsl_otg_loc_conn(struct otg_fsm *fsm, int on)
>       |      ^~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:191:6: error: no previous
> prototype for 'fsl_otg_loc_sof' [-Werror=missing-prototypes]
>   191 | void fsl_otg_loc_sof(struct otg_fsm *fsm, int on)
>       |      ^~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:206:6: error: no previous
> prototype for 'fsl_otg_start_pulse' [-Werror=missing-prototypes]
>   206 | void fsl_otg_start_pulse(struct otg_fsm *fsm)
>       |      ^~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:222:6: error: no previous
> prototype for 'b_data_pulse_end' [-Werror=missing-prototypes]
>   222 | void b_data_pulse_end(unsigned long foo)
>       |      ^~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:241:6: error: no previous
> prototype for 'b_vbus_pulse_end' [-Werror=missing-prototypes]
>   241 | void b_vbus_pulse_end(unsigned long foo)
>       |      ^~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:254:6: error: no previous
> prototype for 'b_srp_end' [-Werror=missing-prototypes]
>   254 | void b_srp_end(unsigned long foo)
>       |      ^~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:269:6: error: no previous
> prototype for 'a_wait_enum' [-Werror=missing-prototypes]
>   269 | void a_wait_enum(unsigned long foo)
>       |      ^~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:279:6: error: no previous
> prototype for 'set_tmout' [-Werror=missing-prototypes]
>   279 | void set_tmout(unsigned long indicator)
>       |      ^~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:285:5: error: no previous
> prototype for 'fsl_otg_init_timers' [-Werror=missing-prototypes]
>   285 | int fsl_otg_init_timers(struct otg_fsm *fsm)
>       |     ^~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:342:6: error: no previous
> prototype for 'fsl_otg_uninit_timers' [-Werror=missing-prototypes]
>   342 | void fsl_otg_uninit_timers(void)
>       |      ^~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:446:6: error: no previous
> prototype for 'otg_reset_controller' [-Werror=missing-prototypes]
>   446 | void otg_reset_controller(void)
>       |      ^~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:458:5: error: no previous
> prototype for 'fsl_otg_start_host' [-Werror=missing-prototypes]
>   458 | int fsl_otg_start_host(struct otg_fsm *fsm, int on)
>       |     ^~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:525:5: error: no previous
> prototype for 'fsl_otg_start_gadget' [-Werror=missing-prototypes]
>   525 | int fsl_otg_start_gadget(struct otg_fsm *fsm, int on)
>       |     ^~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:707:13: error: no previous
> prototype for 'fsl_otg_isr' [-Werror=missing-prototypes]
>   707 | irqreturn_t fsl_otg_isr(int irq, void *dev_id)
>       |             ^~~~~~~~~~~
> /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:833:5: error: no previous
> prototype for 'usb_otg_start' [-Werror=missing-prototypes]
>   833 | int usb_otg_start(struct platform_device *pdev)
>       |     ^~~~~~~~~~~~~
> cc1: all warnings being treated as errors make[6]:
> 
> It looks like this is a change in dependencies which has allowed this to
> be built from today, I didn't isolate exactly what - it looks like the
> issue is missing statics on all these function definitions, making them
> global.  I have ignored this for today.



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure in the final build

[Manuel Ebner]

Hi Mark, 

On Wed, 2026-07-15 at 16:37 +0100, Mark Brown wrote:
> On Mon, Jul 13, 2026 at 06:48:32PM +0100, Mark Brown wrote:
> > Hi all,
> > 
> > In the final builds, today's linux-next build (arm64 allyesconfig)
> > failed like this:
> 
> This error is due to a71f5aef1be98 (USB: gadget: fsl-udc: enable compile
> testing) from the usb tree, a dependency change as expected.  I'll do
> something about this tomorrow.

I stumbled across the same build errors. Are you still on this?

best regarsds
 Manuel Ebner

> 
> > 
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:105:5: error: no previous
> > prototype for 'write_ulpi' [-Werror=missing-prototypes]
> >   105 | int write_ulpi(u8 addr, u8 data)
> >       |     ^~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:118:6: error: no previous
> > prototype for 'fsl_otg_chrg_vbus' [-Werror=missing-prototypes]
> >   118 | void fsl_otg_chrg_vbus(struct otg_fsm *fsm, int on)
> >       |      ^~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:136:6: error: no previous
> > prototype for 'fsl_otg_dischrg_vbus' [-Werror=missing-prototypes]
> >   136 | void fsl_otg_dischrg_vbus(int on)
> >       |      ^~~~~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:154:6: error: no previous
> > prototype for 'fsl_otg_drv_vbus' [-Werror=missing-prototypes]
> >   154 | void fsl_otg_drv_vbus(struct otg_fsm *fsm, int on)
> >       |      ^~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:172:6: error: no previous
> > prototype for 'fsl_otg_loc_conn' [-Werror=missing-prototypes]
> >   172 | void fsl_otg_loc_conn(struct otg_fsm *fsm, int on)
> >       |      ^~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:191:6: error: no previous
> > prototype for 'fsl_otg_loc_sof' [-Werror=missing-prototypes]
> >   191 | void fsl_otg_loc_sof(struct otg_fsm *fsm, int on)
> >       |      ^~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:206:6: error: no previous
> > prototype for 'fsl_otg_start_pulse' [-Werror=missing-prototypes]
> >   206 | void fsl_otg_start_pulse(struct otg_fsm *fsm)
> >       |      ^~~~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:222:6: error: no previous
> > prototype for 'b_data_pulse_end' [-Werror=missing-prototypes]
> >   222 | void b_data_pulse_end(unsigned long foo)
> >       |      ^~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:241:6: error: no previous
> > prototype for 'b_vbus_pulse_end' [-Werror=missing-prototypes]
> >   241 | void b_vbus_pulse_end(unsigned long foo)
> >       |      ^~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:254:6: error: no previous
> > prototype for 'b_srp_end' [-Werror=missing-prototypes]
> >   254 | void b_srp_end(unsigned long foo)
> >       |      ^~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:269:6: error: no previous
> > prototype for 'a_wait_enum' [-Werror=missing-prototypes]
> >   269 | void a_wait_enum(unsigned long foo)
> >       |      ^~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:279:6: error: no previous
> > prototype for 'set_tmout' [-Werror=missing-prototypes]
> >   279 | void set_tmout(unsigned long indicator)
> >       |      ^~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:285:5: error: no previous
> > prototype for 'fsl_otg_init_timers' [-Werror=missing-prototypes]
> >   285 | int fsl_otg_init_timers(struct otg_fsm *fsm)
> >       |     ^~~~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:342:6: error: no previous
> > prototype for 'fsl_otg_uninit_timers' [-Werror=missing-prototypes]
> >   342 | void fsl_otg_uninit_timers(void)
> >       |      ^~~~~~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:446:6: error: no previous
> > prototype for 'otg_reset_controller' [-Werror=missing-prototypes]
> >   446 | void otg_reset_controller(void)
> >       |      ^~~~~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:458:5: error: no previous
> > prototype for 'fsl_otg_start_host' [-Werror=missing-prototypes]
> >   458 | int fsl_otg_start_host(struct otg_fsm *fsm, int on)
> >       |     ^~~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:525:5: error: no previous
> > prototype for 'fsl_otg_start_gadget' [-Werror=missing-prototypes]
> >   525 | int fsl_otg_start_gadget(struct otg_fsm *fsm, int on)
> >       |     ^~~~~~~~~~~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:707:13: error: no previous
> > prototype for 'fsl_otg_isr' [-Werror=missing-prototypes]
> >   707 | irqreturn_t fsl_otg_isr(int irq, void *dev_id)
> >       |             ^~~~~~~~~~~
> > /tmp/next/build/drivers/usb/phy/phy-fsl-usb.c:833:5: error: no previous
> > prototype for 'usb_otg_start' [-Werror=missing-prototypes]
> >   833 | int usb_otg_start(struct platform_device *pdev)
> >       |     ^~~~~~~~~~~~~
> > cc1: all warnings being treated as errors make[6]:
> > 
> > It looks like this is a change in dependencies which has allowed this to
> > be built from today, I didn't isolate exactly what - it looks like the
> > issue is missing statics on all these function definitions, making them
> > global.  I have ignored this for today.
> 

Re: linux-next: build failure in the final build

[Greg Kroah-Hartman]

On Fri, Jul 17, 2026 at 03:47:55PM +0200, Manuel Ebner wrote:
> Hi Mark, 
> 
> On Wed, 2026-07-15 at 16:37 +0100, Mark Brown wrote:
> > On Mon, Jul 13, 2026 at 06:48:32PM +0100, Mark Brown wrote:
> > > Hi all,
> > > 
> > > In the final builds, today's linux-next build (arm64 allyesconfig)
> > > failed like this:
> > 
> > This error is due to a71f5aef1be98 (USB: gadget: fsl-udc: enable compile
> > testing) from the usb tree, a dependency change as expected.  I'll do
> > something about this tomorrow.
> 
> I stumbled across the same build errors. Are you still on this?

Should I revert that commit to resolve this?

thanks,

greg k-h

Re: linux-next: build failure in the final build

[Johan Hovold]

On Fri, Jul 17, 2026 at 04:35:44PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jul 17, 2026 at 03:47:55PM +0200, Manuel Ebner wrote:
> > Hi Mark, 
> > 
> > On Wed, 2026-07-15 at 16:37 +0100, Mark Brown wrote:
> > > On Mon, Jul 13, 2026 at 06:48:32PM +0100, Mark Brown wrote:
> > > > Hi all,
> > > > 
> > > > In the final builds, today's linux-next build (arm64 allyesconfig)
> > > > failed like this:
> > > 
> > > This error is due to a71f5aef1be98 (USB: gadget: fsl-udc: enable compile
> > > testing) from the usb tree, a dependency change as expected.  I'll do
> > > something about this tomorrow.
> > 
> > I stumbled across the same build errors. Are you still on this?
> 
> Should I revert that commit to resolve this?

I think we should fix the broken driver that is now being built instead.

I was also waiting on Mark to follow up on this, otherwise I can take
closer look at it.

Based on a quick look it seemed like Mark was right about missing static
keywords in a driver indirectly enabled by the "offending" commit.

Johan

Re: linux-next: build failure in the final build

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Fri, Jul 17, 2026 at 04:40:38PM +0200, Johan Hovold wrote:

> I was also waiting on Mark to follow up on this, otherwise I can take
> closer look at it.

> Based on a quick look it seemed like Mark was right about missing static
> keywords in a driver indirectly enabled by the "offending" commit.

IIRC I replied to the patch for the offending commit the other day.  At
some point I will get fed up and just revert the usb tree back to one
that works, it's a real pain doing that for issues in the final build.

This seems like it really ought to be straightforward to reproduce
localy...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure in the final build

[Johan Hovold]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

On Fri, Jul 17, 2026 at 03:54:05PM +0100, Mark Brown wrote:
> On Fri, Jul 17, 2026 at 04:40:38PM +0200, Johan Hovold wrote:
> 
> > I was also waiting on Mark to follow up on this, otherwise I can take
> > closer look at it.
> 
> > Based on a quick look it seemed like Mark was right about missing static
> > keywords in a driver indirectly enabled by the "offending" commit.
> 
> IIRC I replied to the patch for the offending commit the other day.  At
> some point I will get fed up and just revert the usb tree back to one
> that works, it's a real pain doing that for issues in the final build.
> 
> This seems like it really ought to be straightforward to reproduce
> localy...

Oh, sorry. I misunderstood your comment about doing "something about
this tomorrow" to mean that you intended to send a fix yourself.

I'll send a fix in a bit.

Johan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]