From: Thomas Gleixner <tglx@linutronix.de>
To: Richard Weinberger <richard@nod.at>
Cc: peterz@infradead.org, hpa@zytor.com, mingo@elte.hu,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org
Subject: Re: linux-next: User Mode Linux broken
Date: Thu, 21 Oct 2010 18:09:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1010211805040.2418@localhost6.localdomain6> (raw)
In-Reply-To: <201010211315.26679.richard@nod.at>
On Thu, 21 Oct 2010, Richard Weinberger wrote:
> Thomas,
>
> Your commit c5f7563 ("genirq: Provide compat handling for chip->enable()")
> breaks UML.
> It does not start anymore.
>
> When I apply this patch it works fine again.
> http://userweb.kernel.org/~akpm/mmotm/broken-out/um-migrate-from-__do_irq-to-
> generic_handle_irq.patch
>
> Maybe your patch breaks all users of __do_IRQ()?
Not intentionally :)
The irq_chip of um has it's own dummy enable function, so the compat
code uses it.
+static void compat_irq_enable(struct irq_data *data)
+{
+ data->chip->enable(data->irq);
+}
+
...
+ if (chip->enable)
+ chip->irq_enable = compat_irq_enable;
+
+ /*
+ * The real defaults
+ */
+ if (!chip->irq_enable)
+ chip->irq_enable = default_enable;
So I really can't see how's that supposed to break UM
Thanks,
tglx
next prev parent reply other threads:[~2010-10-21 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 11:15 linux-next: User Mode Linux broken Richard Weinberger
2010-10-21 16:09 ` Thomas Gleixner [this message]
2010-10-21 19:22 ` Richard Weinberger
2010-10-21 19:45 ` Thomas Gleixner
2010-10-21 20:27 ` Richard Weinberger
2010-10-22 7:03 ` Thomas Gleixner
2010-10-22 10:50 ` Richard Weinberger
2010-10-22 11:12 ` Thomas Gleixner
2010-10-22 13:27 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1010211805040.2418@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox