From: Thomas Gleixner <tglx@linutronix.de>
To: Richard Weinberger <richard@nod.at>
Cc: peterz@infradead.org, hpa@zytor.com, mingo@elte.hu,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org
Subject: Re: linux-next: User Mode Linux broken
Date: Fri, 22 Oct 2010 09:03:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1010220900230.3467@localhost6.localdomain6> (raw)
In-Reply-To: <201010212227.12919.richard@nod.at>
On Thu, 21 Oct 2010, Richard Weinberger wrote:
> Am Donnerstag 21 Oktober 2010, 21:45:35 schrieb Thomas Gleixner:
> > Why shold it solve it ? irq_enable is set to compat_irq_enable which
> > in turn calls chip->enable.
> >
> > So how's that different ?
>
> I took a closer look on the issue.
>
> check_irq_resend() gets called before irq_chip_set_defaults().
> In the first call to check_irq_resend() desc->irq_data.chip->irq_enable is
> NULL. UML dies due to a NULL-pointer dereference...
>
> I don't know why check_irq_resend() is called before irq_chip_set_defaults().
> It's your code. ;-)
Well, but it only gets called via enable_irq(). So that means
something is calling enable_irq _before_ request/setup_irq().
arch/um/kernel/irq.c:init_IRQ() does that :)
Thanks,
tglx
next prev parent reply other threads:[~2010-10-22 7:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 11:15 linux-next: User Mode Linux broken Richard Weinberger
2010-10-21 16:09 ` Thomas Gleixner
2010-10-21 19:22 ` Richard Weinberger
2010-10-21 19:45 ` Thomas Gleixner
2010-10-21 20:27 ` Richard Weinberger
2010-10-22 7:03 ` Thomas Gleixner [this message]
2010-10-22 10:50 ` Richard Weinberger
2010-10-22 11:12 ` Thomas Gleixner
2010-10-22 13:27 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1010220900230.3467@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox