* linux-next: manual merge of the sound tree with the pm tree
@ 2026-10-13 17:00 Mark Brown
2026-10-13 17:24 ` Rafael J. Wysocki (Intel)
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2026-10-13 17:00 UTC (permalink / raw)
To: Takashi Iwai
Cc: Linux Kernel Mailing List, Linux Next Mailing List, Ma Ke,
Rafael J. Wysocki, Rafael J. Wysocki
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
Hi all,
Today's linux-next merge of the sound tree got a conflict in:
sound/hda/codecs/side-codecs/cs35l41_hda.c
between commit:
2f47382b3ea31 ("ALSA: hda: cs35l41: Switch to use acpi_bus_get_primary_device()")
from the pm tree and commit:
8d70e364e866b ("ALSA: hda: cs35l41: Fix ACPI device reference leak on probe failure")
from the sound tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
diff --cc sound/hda/codecs/side-codecs/cs35l41_hda.c
index 32abb71dd4019,d50c3d8f5303c..0000000000000
--- a/sound/hda/codecs/side-codecs/cs35l41_hda.c
+++ b/sound/hda/codecs/side-codecs/cs35l41_hda.c
@@@ -1926,11 -1925,10 +1925,9 @@@ static int cs35l41_hda_read_acpi(struc
}
cs35l41->dacpi = adev;
- struct device *physdev __free(put_device) =
- get_device(acpi_get_first_physical_node(adev));
+ struct device *physdev __free(put_device) = acpi_bus_get_primary_device(adev);
- if (!physdev) {
- acpi_dev_put(adev);
+ if (!physdev)
return -ENODEV;
- }
sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
if (IS_ERR(sub))
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: manual merge of the sound tree with the pm tree
2026-10-13 17:00 linux-next: manual merge of the sound tree with the pm tree Mark Brown
@ 2026-10-13 17:24 ` Rafael J. Wysocki (Intel)
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki (Intel) @ 2026-10-13 17:24 UTC (permalink / raw)
To: Mark Brown
Cc: Takashi Iwai, Linux Kernel Mailing List, Linux Next Mailing List,
Ma Ke, Rafael J. Wysocki, Rafael J. Wysocki
Hi Mark,
On Tue, Oct 13, 2026 at 7:00 PM Mark Brown <broonie@kernel.org> wrote:
>
> Hi all,
>
> Today's linux-next merge of the sound tree got a conflict in:
>
> sound/hda/codecs/side-codecs/cs35l41_hda.c
>
> between commit:
>
> 2f47382b3ea31 ("ALSA: hda: cs35l41: Switch to use acpi_bus_get_primary_device()")
>
> from the pm tree and commit:
>
> 8d70e364e866b ("ALSA: hda: cs35l41: Fix ACPI device reference leak on probe failure")
>
> from the sound tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> diff --cc sound/hda/codecs/side-codecs/cs35l41_hda.c
> index 32abb71dd4019,d50c3d8f5303c..0000000000000
> --- a/sound/hda/codecs/side-codecs/cs35l41_hda.c
> +++ b/sound/hda/codecs/side-codecs/cs35l41_hda.c
> @@@ -1926,11 -1925,10 +1925,9 @@@ static int cs35l41_hda_read_acpi(struc
> }
>
> cs35l41->dacpi = adev;
> - struct device *physdev __free(put_device) =
> - get_device(acpi_get_first_physical_node(adev));
> + struct device *physdev __free(put_device) = acpi_bus_get_primary_device(adev);
> - if (!physdev) {
> - acpi_dev_put(adev);
> + if (!physdev)
> return -ENODEV;
> - }
>
> sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
> if (IS_ERR(sub))
The merge conflict resolution looks good to me, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-13 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-13 17:00 linux-next: manual merge of the sound tree with the pm tree Mark Brown
2026-10-13 17:24 ` Rafael J. Wysocki (Intel)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox