linux-next: Signed-off-by missing for commit in the mediatek tree

linux-next: Signed-off-by missing for commit in the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi all,

Commits

  775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
  c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
  c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
  75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Matthias Brugger]

Hi Stephen,

On 26/04/2022 00:07, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>    775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>    c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>    c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>    75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
> 
> are missing a Signed-off-by from their committer.
> 

These patches are taken by Krysztof and merge into my tree via a tag [1] to 
avoid any conflicts. Please let me know if there is anything I need to do to fix 
this problem.

Regards,
Matthias

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.19/arm-dts64-cleanups

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Krzysztof Kozlowski]

On 26/04/2022 10:48, Matthias Brugger wrote:
> Hi Stephen,
> 
> On 26/04/2022 00:07, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commits
>>
>>    775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>>    c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>>    c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>>    75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
>>
>> are missing a Signed-off-by from their committer.
>>
> 
> These patches are taken by Krysztof and merge into my tree via a tag [1] to 
> avoid any conflicts. Please let me know if there is anything I need to do to fix 
> this problem.

Hi Matthias,

Before you merged my branch, which was fine, but later you rebased all
this thus making yourself committer. Commits pulled from other trees
should in general not be rebased, because it creates duplicates - there
are ones in my tree, and separate in yours.

Additionally, such rebase changes the author, so you need your SoB.

Since you already rebased it, I propose you add your own SoB to Mediatek
patches and drop the one hisilicon (75a3c81bc634). I will do the reverse
- drop Mediatek and keep hisilicon.


Best regards,
Krzysztof

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Krzysztof Kozlowski]

On 26/04/2022 10:52, Krzysztof Kozlowski wrote:
> On 26/04/2022 10:48, Matthias Brugger wrote:
>> Hi Stephen,
>>
>> On 26/04/2022 00:07, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>>    775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>>>    c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>>>    c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>>>    75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
>>>
>>> are missing a Signed-off-by from their committer.
>>>
>>
>> These patches are taken by Krysztof and merge into my tree via a tag [1] to 
>> avoid any conflicts. Please let me know if there is anything I need to do to fix 
>> this problem.
> 
> Hi Matthias,
> 
> Before you merged my branch, which was fine, but later you rebased all
> this thus making yourself committer. Commits pulled from other trees
> should in general not be rebased, because it creates duplicates - there
> are ones in my tree, and separate in yours.
> 
> Additionally, such rebase changes the author, so you need your SoB.

Minor update - you not only rebased these commits, but also kept my
branch so even in your tree they are duplicated.

> Since you already rebased it, I propose you add your own SoB to Mediatek
> patches and drop the one hisilicon (75a3c81bc634). I will do the reverse
> - drop Mediatek and keep hisilicon.

Best regards,
Krzysztof

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Matthias Brugger]

On 26/04/2022 10:52, Krzysztof Kozlowski wrote:
> On 26/04/2022 10:48, Matthias Brugger wrote:
>> Hi Stephen,
>>
>> On 26/04/2022 00:07, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>>     775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>>>     c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>>>     c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>>>     75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
>>>
>>> are missing a Signed-off-by from their committer.
>>>
>>
>> These patches are taken by Krysztof and merge into my tree via a tag [1] to
>> avoid any conflicts. Please let me know if there is anything I need to do to fix
>> this problem.
> 
> Hi Matthias,
> 
> Before you merged my branch, which was fine, but later you rebased all
> this thus making yourself committer. Commits pulled from other trees
> should in general not be rebased, because it creates duplicates - there
> are ones in my tree, and separate in yours.
> 
> Additionally, such rebase changes the author, so you need your SoB.
> 

Ok thanks for the explanation.

> Since you already rebased it, I propose you add your own SoB to Mediatek
> patches and drop the one hisilicon (75a3c81bc634). I will do the reverse
> - drop Mediatek and keep hisilicon.
> 

Ok, I think this is the easiest solution. Sorry for the inconvenience I created.

Regards,
Matthias

linux-next: Signed-off-by missing for commit in the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hi all,

Commit

  fd042310df40 ("arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver")

is missing a Signed-off-by from its committer.


-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[AngeloGioacchino Del Regno]

Il 24/02/25 23:17, Stephen Rothwell ha scritto:
> Hi all,
> 
> Commit
> 
>    fd042310df40 ("arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver")
> 
> is missing a Signed-off-by from its committer.
> 
> 

Yeah, thanks, fixing immediately.

Cheers,
Angelo

linux-next: Signed-off-by missing for commit in the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Hi all,

Commits

  8e7a6a0b622a ("arm64: dts: mediatek: mt7988: add efuse block")
  242372c0a236 ("arm64: dts: mediatek: mt7988: add UART controllers")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Hi all,

Commits

  65b99309a9c1 ("arm64: dts: mt8183: Damu: add i2c2's i2c-scl-internal-delay-ns")
  025869564bf8 ("arm64: dts: mt8183: cozmo: add i2c2's i2c-scl-internal-delay-ns")
  3d3bc7cb46e8 ("arm64: dts: mt8183: burnet: add i2c2's i2c-scl-internal-delay-ns")
  5bbddfd0470f ("arm64: dts: mt8183: fennel: add i2c2's i2c-scl-internal-delay-ns")
(The above also has an empty Reviewed-by tag)
  ca80f75083f6 ("arm64: dts: mt8183: set DMIC one-wire mode on Damu")

are missing a Signed-off-by from their authors.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[AngeloGioacchino Del Regno]

Il 08/10/24 22:15, Stephen Rothwell ha scritto:
> Hi all,
> 
> Commits
> 
>    65b99309a9c1 ("arm64: dts: mt8183: Damu: add i2c2's i2c-scl-internal-delay-ns")
>    025869564bf8 ("arm64: dts: mt8183: cozmo: add i2c2's i2c-scl-internal-delay-ns")
>    3d3bc7cb46e8 ("arm64: dts: mt8183: burnet: add i2c2's i2c-scl-internal-delay-ns")
>    5bbddfd0470f ("arm64: dts: mt8183: fennel: add i2c2's i2c-scl-internal-delay-ns")
> (The above also has an empty Reviewed-by tag)
>    ca80f75083f6 ("arm64: dts: mt8183: set DMIC one-wire mode on Damu")
> 
> are missing a Signed-off-by from their authors.
> 

The empty R-b happened because b4 didn't interpret "<email>2" correctly
and dropped the email entirely. We should probably report that to the authors.

Anyway, dropping these commits until Hsin-Te and Daolong clarify what to do here
with the S-o-b tags, I didn't notice that the author was different, there.

Sorry about that.

Regards,
Angelo

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[AngeloGioacchino Del Regno]

Il 09/10/24 10:19, Hsin-Te Yuan ha scritto:
> On Wed, Oct 9, 2024 at 3:52 PM AngeloGioacchino Del Regno <
> angelogioacchino.delregno@kernel.org> wrote:
> 
>> Il 08/10/24 22:15, Stephen Rothwell ha scritto:
>>> Hi all,
>>>
>>> Commits
>>>
>>>     65b99309a9c1 ("arm64: dts: mt8183: Damu: add i2c2's
>> i2c-scl-internal-delay-ns")
>>>     025869564bf8 ("arm64: dts: mt8183: cozmo: add i2c2's
>> i2c-scl-internal-delay-ns")
>>>     3d3bc7cb46e8 ("arm64: dts: mt8183: burnet: add i2c2's
>> i2c-scl-internal-delay-ns")
>>>     5bbddfd0470f ("arm64: dts: mt8183: fennel: add i2c2's
>> i2c-scl-internal-delay-ns")
>>> (The above also has an empty Reviewed-by tag)
>>>     ca80f75083f6 ("arm64: dts: mt8183: set DMIC one-wire mode on Damu")
>>>
>>> are missing a Signed-off-by from their authors.
>>>
>>
>> The empty R-b happened because b4 didn't interpret "<email>2" correctly
>> and dropped the email entirely. We should probably report that to the
>> authors.
>>
>> Anyway, dropping these commits until Hsin-Te and Daolong clarify what to
>> do here
>> with the S-o-b tags, I didn't notice that the author was different, there.
>>
>> Sorry about that.
>>
>> Regards,
>> Angelo
>>
> 
> 
> There is a "Signed-off-by: Daolong Zhu <
> jg_daolongzhu@mediatek.corp-partner.google.com>" tag for i2c related
> patches  and a "Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>" tag for
> DMIC patch in downstream, but I accidentally dropped it while sending to
> upstream.
> Sorry about that. Should I resend these patches?
> 
> By the way, it seems that Daolong is no longer working for Mediatek, and I
> don't have any way to contact Daolong.
> 

Yes please resend the patches; make sure to keep the Reviewed-by tags, and
also make sure that *your* S-o-B (and the author's) is present on them.
If the author is Daolong, you either take authorship and add him with a
Co-Developed-by, or you ask him to signoff the patches.

Thanks,
Angelo

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Konstantin Ryabitsev]

On Wed, Oct 09, 2024 at 09:52:14AM GMT, AngeloGioacchino Del Regno wrote:
> >    65b99309a9c1 ("arm64: dts: mt8183: Damu: add i2c2's i2c-scl-internal-delay-ns")
> >    025869564bf8 ("arm64: dts: mt8183: cozmo: add i2c2's i2c-scl-internal-delay-ns")
> >    3d3bc7cb46e8 ("arm64: dts: mt8183: burnet: add i2c2's i2c-scl-internal-delay-ns")
> >    5bbddfd0470f ("arm64: dts: mt8183: fennel: add i2c2's i2c-scl-internal-delay-ns")
> > (The above also has an empty Reviewed-by tag)
> >    ca80f75083f6 ("arm64: dts: mt8183: set DMIC one-wire mode on Damu")
> > 
> > are missing a Signed-off-by from their authors.
> > 
> 
> The empty R-b happened because b4 didn't interpret "<email>2" correctly
> and dropped the email entirely. We should probably report that to the authors.

Consider it reported. :) However, I'm not sure I understand what the situation
is. When I pull that series with ``b4 -slH shazam``, all the trailers are
properly preserved as far as I can tell:

    arm64: dts: mt8183: Damu: add i2c2's i2c-scl-internal-delay-ns

    Add i2c2's i2c-scl-internal-delay-ns.

    Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
    Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Signed-off-by: Daolong Zhu <jg_daolongzhu@mediatek.corp-partner.google.com>
    Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
    Link: https://lore.kernel.org/r/20241009-i2c-delay-v1-4-6cf59721c1d1@chromium.org
    Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

-K

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[AngeloGioacchino Del Regno]

Il 09/10/24 22:53, Konstantin Ryabitsev ha scritto:
> On Wed, Oct 09, 2024 at 09:52:14AM GMT, AngeloGioacchino Del Regno wrote:
>>>     65b99309a9c1 ("arm64: dts: mt8183: Damu: add i2c2's i2c-scl-internal-delay-ns")
>>>     025869564bf8 ("arm64: dts: mt8183: cozmo: add i2c2's i2c-scl-internal-delay-ns")
>>>     3d3bc7cb46e8 ("arm64: dts: mt8183: burnet: add i2c2's i2c-scl-internal-delay-ns")
>>>     5bbddfd0470f ("arm64: dts: mt8183: fennel: add i2c2's i2c-scl-internal-delay-ns")
>>> (The above also has an empty Reviewed-by tag)
>>>     ca80f75083f6 ("arm64: dts: mt8183: set DMIC one-wire mode on Damu")
>>>
>>> are missing a Signed-off-by from their authors.
>>>
>>
>> The empty R-b happened because b4 didn't interpret "<email>2" correctly
>> and dropped the email entirely. We should probably report that to the authors.
> 
> Consider it reported. :) However, I'm not sure I understand what the situation
> is. When I pull that series with ``b4 -slH shazam``, all the trailers are
> properly preserved as far as I can tell:
> 
>      arm64: dts: mt8183: Damu: add i2c2's i2c-scl-internal-delay-ns
> 
>      Add i2c2's i2c-scl-internal-delay-ns.
> 
>      Fixes: cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
>      Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>      Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>      Signed-off-by: Daolong Zhu <jg_daolongzhu@mediatek.corp-partner.google.com>
>      Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
>      Link: https://lore.kernel.org/r/20241009-i2c-delay-v1-4-6cf59721c1d1@chromium.org
>      Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
> 
> -K

Uhm, maybe I'm using an older version of b4 - I admit I haven't updated it in the
last (more than) 6 months.

I'll recheck as soon as I can after updating.

linux-next: Signed-off-by missing for commit in the mediatek tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hi Matthias,

Commit

  f039c4193c93 ("iregmap: include <linux/ktime.h> from include/linux/regmap.h")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

[Matthias Brugger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Stephen,

On 05/13/2018 11:57 PM, Stephen Rothwell wrote:
> Hi Matthias,
> 
> Commit
> 
> f039c4193c93 ("iregmap: include <linux/ktime.h> from
> include/linux/regmap.h")
> 
> is missing a Signed-off-by from its committer.
> 

My tree was broken and the merge commit disappeared which pulled this commit
into my tree. Should be fixed by now.

Regards,
Matthias
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEiUuSfQSYnG8EMsBltDliWyzx00MFAlr5aU0ACgkQtDliWyzx
00O68Q//eXk6z6PiRXG+30Pk5z5Wl3vmEvEokwivO1I1kCErktyAcvjMNYA5CJS+
Df7FWAg3p17G7e6p7w5NOteOxBI4leCsebLnRMKOja2m6IrulxHb98koAjcx14sx
twKsa2YEMI7GjhwE93ozkoqkeGeQ0i/IxyFRqn0brcpmUv/49AY8Qw4VTi/Q5rxm
ma6YFWygcQ7x603eWrkxJKG5pmExmUTwNU7B+9Ycqp/yMaikUYW9RedToDxjILAJ
OGQ2uexySNyUJaX2ECpHeM7FnSkOBKzqAjzCD8bDQTL82hiUla5mDFRsOhtzg9be
pe/CdChbeLxZ0v8fv1n2WEO4Bb1E6OXp7YmL8hH6nbmWVxQf448QX0POV5IrJX+V
46/iMzwUtjTasAj50RoI8cb3mhj0fcJgmB/Ivk6OZQfy1UoZ0VrPjIiNlymfgTGM
aP28Dx8RUxysZCvj0Uy/CX+kxMxJU77OgOMDxotf8iTAVnbC2dSqiHSkqZCj7ncK
1cVQkfUHvqEgtCdsEyHN+k7fcu2vmYwvISE5IpoKZyHPU1CNc5+cFdEbxlCvUVVJ
K9PNYz8VFJsYJyYcVG+1C4EUJHLRrnhTK6cdp5GaKlSHagV8UKaefuUvXU8GRBZm
BO+xTm6qRX5ZnQI57MPaq/xEvhVevMRG4xp0wZ5Bf86uIvlP97w=
=gxCq
-----END PGP SIGNATURE-----