* [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional
From: Randy Dunlap @ 2009-10-09 23:17 UTC (permalink / raw)
To: Stephen Rothwell, lenb
Cc: linux-next, LKML, Borislav Deianov, Henrique de Moraes Holschuh
In-Reply-To: <20091009190654.741eeffd.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix optional part of driver to be built optionally:
drivers/platform/x86/thinkpad_acpi.c:6251: error: implicit declaration of function 'tpacpi_hotkey_driver_mask_set'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20091009.orig/drivers/platform/x86/thinkpad_acpi.c
+++ linux-next-20091009/drivers/platform/x86/thinkpad_acpi.c
@@ -6245,12 +6245,14 @@ static int __init brightness_init(struct
ibm_backlight_device->props.brightness = b & TP_EC_BACKLIGHT_LVLMSK;
backlight_update_status(ibm_backlight_device);
+#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_BRGHT,
"brightness: registering brightness hotkeys "
"as change notification\n");
tpacpi_hotkey_driver_mask_set(hotkey_driver_mask
| TP_ACPI_HKEY_BRGHTUP_MASK
| TP_ACPI_HKEY_BRGHTDWN_MASK);;
+#endif
return 0;
}
^ permalink raw reply
* [PATCH -next] libertas: depends on CFG80211
From: Randy Dunlap @ 2009-10-09 23:17 UTC (permalink / raw)
To: Stephen Rothwell, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
Dan Williams
Cc: linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
In-Reply-To: <20091009190654.741eeffd.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
From: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
libertas uses CFG80211 functions so it should depend on that symbol.
drivers/built-in.o: In function `lbs_cfg_free':
(.text+0x9ca93): undefined reference to `wiphy_unregister'
drivers/built-in.o: In function `lbs_cfg_free':
(.text+0x9ca9a): undefined reference to `wiphy_free'
drivers/built-in.o: In function `lbs_cfg_register':
(.text+0x9cb45): undefined reference to `wiphy_register'
drivers/built-in.o: In function `lbs_cfg_alloc':
(.text+0x9cc64): undefined reference to `wiphy_new'
Signed-off-by: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
drivers/net/wireless/libertas/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20091009.orig/drivers/net/wireless/libertas/Kconfig
+++ linux-next-20091009/drivers/net/wireless/libertas/Kconfig
@@ -1,6 +1,6 @@
config LIBERTAS
tristate "Marvell 8xxx Libertas WLAN driver support"
- depends on WLAN_80211
+ depends on WLAN_80211 && CFG80211
select WIRELESS_EXT
select WEXT_SPY
select LIB80211
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional
From: Henrique de Moraes Holschuh @ 2009-10-10 0:08 UTC (permalink / raw)
To: Randy Dunlap, Ingo Molnar; +Cc: Stephen Rothwell, lenb, linux-next, LKML
In-Reply-To: <20091009161723.b68b91a7.randy.dunlap@oracle.com>
On Fri, 09 Oct 2009, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix optional part of driver to be built optionally:
NAK!
This happens because of (linux-next) commit
7f6443f7238a0aa9014b11a0a31ab76825d75cdf
"thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL" by
Ingo.
That commit is wrong, it must NOT be applied as explained in the thread
starting at http://lkml.org/lkml/2009/9/27/30.
Ingo, can you please check if you don't have that commit still in one of
your trees that are fed into linux-next? It broke the driver now that the
"backlight/thinkpad-acpi: issue backlight class events" patch landed in
-next, just like I said it would happen...
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
^ permalink raw reply
* Re: linux-next: manual merge of the parisc tree with Linus' tree
From: Stephen Rothwell @ 2009-10-10 1:23 UTC (permalink / raw)
To: Kyle McMartin; +Cc: linux-parisc, linux-next, linux-kernel, David Howells
In-Reply-To: <20091009183914.GG11702@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
Hi Kyle,
On Fri, 9 Oct 2009 14:39:14 -0400 Kyle McMartin <kyle@mcmartin.ca> wrote:
>
> Sorry, forgot to push out a new #next. Should be sorted now.
No worries, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] linux-next: 20090929 - android driver build breaks
From: Pavel Machek @ 2009-10-11 9:05 UTC (permalink / raw)
To: Greg KH
Cc: David Rientjes, Greg KH, Kamalesh Babulal, linux-next, LKML, sfr,
Andrew Morton, Arve Hjonnevag, San Mehat
In-Reply-To: <20091008232825.GA540@suse.de>
> > If it's a criticism of the staleness of the Android code within the
> > staging tree or no recent activity, then we should probably loop in some
> > Android developers to find our about their plans. I've added them to the
> > cc.
>
> They know all about this and agreed that the code should be dropped for
> 2.6.33 if no one sends me patches. If someone does, then I will remove
> my 'delete the android code' patch in the staging tree.
>
> Honestly, I'm not holding my breath :(
Heh, I'm glad, I did not make dream suppport dependend on
CONFIG_ANDROID... :-).
Oops, no, it does depend on it.
Something like this?
Pavel
---
Make Dream support idenependend of CONFIG_ANDROID.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
--- linux-rc/drivers/staging.ofic/Makefile 2009-10-06 13:51:49.000000000 +0200
+++ linux-rc/drivers/staging/Makefile 2009-10-10 14:52:36.000000000 +0200
@@ -27,7 +27,7 @@
obj-$(CONFIG_INPUT_MIMIO) += mimio/
obj-$(CONFIG_TRANZPORT) += frontier/
obj-$(CONFIG_ANDROID) += android/
-obj-$(CONFIG_ANDROID) += dream/
+obj-$(CONFIG_DREAM) += dream/
obj-$(CONFIG_DST) += dst/
obj-$(CONFIG_POHMELFS) += pohmelfs/
obj-$(CONFIG_STLC45XX) += stlc45xx/
--- linux-rc/drivers/staging.ofic/dream/Kconfig 2009-10-06 13:52:05.000000000 +0200
+++ linux-rc/drivers/staging/dream/Kconfig 2009-10-10 14:53:11.000000000 +0200
@@ -1,3 +1,6 @@
+config DREAM
+ tristate "HTC Dream support"
+
source "drivers/staging/dream/smd/Kconfig"
source "drivers/staging/dream/camera/Kconfig"
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply
* linux-next: origin tree build warning
From: Stephen Rothwell @ 2009-10-11 23:56 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
Hi Trond,
Today's linux-next build (powerpc ppc64_defconfig) produced these warnings:
fs/nfs/super.c: In function 'nfs_compare_remount_data':
fs/nfs/super.c:1852: warning: passing argument 1 of 'rpc_cmp_addr' from incompatible pointer type
include/linux/sunrpc/clnt.h:254: note: expected 'const struct sockaddr *' but argument is of type 'struct __kernel_sockaddr_storage *'
fs/nfs/super.c:1852: warning: passing argument 2 of 'rpc_cmp_addr' from incompatible pointer type
include/linux/sunrpc/clnt.h:254: note: expected 'const struct sockaddr *' but argument is of type 'struct __kernel_sockaddr_storage *'
Introduced by commit bcd2ea17da6a329a7276cde7286d802f009af332 ("NFS: Fix
port initialisation in nfs_remount()").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: linux-next: mfd tree build failure
From: Stephen Rothwell @ 2009-10-12 2:11 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Haojian Zhuang, Mark Brown
In-Reply-To: <20091006130202.5e18a332.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
Hi Samuel,
On Tue, 6 Oct 2009 13:02:02 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/built-in.o: In function `pm8607_write_device':
> 88pm8607.c:(.text+0xd02e9): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `pm8607_read_device':
> 88pm8607.c:(.text+0xd033b): undefined reference to `i2c_master_send'
> 88pm8607.c:(.text+0xd035c): undefined reference to `i2c_master_recv'
> drivers/built-in.o: In function `pm8607_init':
> 88pm8607.c:(.init.text+0xa9bd): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `pm8607_probe':
> 88pm8607.c:(.devinit.text+0x4db6): undefined reference to `mfd_add_devices'
> drivers/built-in.o: In function `pm8607_exit':
> 88pm8607.c:(.exit.text+0x598): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `pm8607_remove':
> 88pm8607.c:(.devexit.text+0x198): undefined reference to `mfd_remove_devices'
>
> Obviously caused by commit 9ec6cd8f2235ddeee5b39068956f14238a12a617
> ("mfd: Add 88PM8607 driver").
>
> This build has CONFIG_I2C=m and CONFIG_MFD_CORE=m.
>
> I have used the version of the mfd tree form next-20091005 for today.
This build failure is still happening and I am still using the mfd tree
from next-20091005.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* linux-next: voltage tree build failure
From: Stephen Rothwell @ 2009-10-12 2:26 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-next, linux-kernel, Haojian Zhuang, Samuel Ortiz
[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]
Hi Liam,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/built-in.o: In function `pm8607_write_device':
88pm8607.c:(.text+0xd1359): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `pm8607_read_device':
88pm8607.c:(.text+0xd13ab): undefined reference to `i2c_master_send'
88pm8607.c:(.text+0xd13cc): undefined reference to `i2c_master_recv'
drivers/built-in.o: In function `pm8607_init':
88pm8607.c:(.init.text+0xaa22): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `pm8607_probe':
88pm8607.c:(.devinit.text+0x50fb): undefined reference to `mfd_add_devices'
drivers/built-in.o: In function `pm8607_exit':
88pm8607.c:(.exit.text+0x5de): undefined reference to `i2c_del_driver'
drivers/built-in.o: In function `pm8607_remove':
88pm8607.c:(.devexit.text+0x1cc): undefined reference to `mfd_remove_devices'
Caused by commit 258e3427f83a573d738344c2f5499da5e026e1df ("regulator:
add 88PM8607 PMIC driver"). This is the same driver that has caused the
mfd tree to fail in the same way since next-20091006. I have used the
version of the voltage tree from next-20091009 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: linux-next: voltage tree build failure
From: Haojian Zhuang @ 2009-10-12 2:50 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Samuel Ortiz
In-Reply-To: <20091012132628.2f709e40.sfr@canb.auug.org.au>
On Sun, Oct 11, 2009 at 10:26 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Liam,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/built-in.o: In function `pm8607_write_device':
> 88pm8607.c:(.text+0xd1359): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `pm8607_read_device':
> 88pm8607.c:(.text+0xd13ab): undefined reference to `i2c_master_send'
> 88pm8607.c:(.text+0xd13cc): undefined reference to `i2c_master_recv'
> drivers/built-in.o: In function `pm8607_init':
> 88pm8607.c:(.init.text+0xaa22): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `pm8607_probe':
> 88pm8607.c:(.devinit.text+0x50fb): undefined reference to `mfd_add_devices'
> drivers/built-in.o: In function `pm8607_exit':
> 88pm8607.c:(.exit.text+0x5de): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `pm8607_remove':
> 88pm8607.c:(.devexit.text+0x1cc): undefined reference to `mfd_remove_devices'
>
> Caused by commit 258e3427f83a573d738344c2f5499da5e026e1df ("regulator:
> add 88PM8607 PMIC driver"). This is the same driver that has caused the
> mfd tree to fail in the same way since next-20091006. I have used the
> version of the voltage tree from next-20091009 for today.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
Hi Samuel & Liam,
Please help review and merge this fix patch. I'm sorry for inconvience.
Stephen,
Thanks for your check.
From b7d3707263598c4c6671ac592eaaf13535a7b96a Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <haojian.zhuang@marvell.com>
Date: Tue, 6 Oct 2009 08:08:37 -0400
Subject: [PATCH] mfd: fix the dependancy issue on 88PM8607
88PM8607 depends on I2C and MFD_CORE. Since 88PM8607 is built-in
kernel, it also requires that I2C and MFD_CORE are built-in
kernel also.
Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fbe684b..00064e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -307,7 +307,7 @@ config EZX_PCAP
config MFD_88PM8607
bool "Support Marvell 88PM8607"
- depends on I2C
+ depends on I2C=y
select MFD_CORE
help
This supports for Marvell 88PM8607 Power Management IC. This includes
--
1.5.6.5
Best Regards
Haojian
^ permalink raw reply related
* linux-next: suspend tree build failure
From: Stephen Rothwell @ 2009-10-12 3:00 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2206 bytes --]
Hi Rafael,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/base/power/main.c: In function 'device_pm_wait':
drivers/base/power/main.c:218: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
drivers/base/power/main.c:218: error: (Each undeclared identifier is reported only once
drivers/base/power/main.c:218: error: for each function it appears in.)
drivers/base/power/main.c:218: error: implicit declaration of function 'schedule'
drivers/base/power/main.c: In function 'dbg_show_time':
drivers/base/power/main.c:514: error: implicit declaration of function 'task_pid_nr'
drivers/base/power/main.c: In function '__device_resume_noirq':
drivers/base/power/main.c:551: error: 'TASK_NORMAL' undeclared (first use in this function)
drivers/base/power/main.c: In function '__device_resume':
drivers/base/power/main.c:713: error: 'TASK_NORMAL' undeclared (first use in this function)
drivers/base/power/main.c: In function '__device_suspend_noirq':
drivers/base/power/main.c:970: error: 'TASK_NORMAL' undeclared (first use in this function)
drivers/base/power/main.c: In function '__device_suspend':
drivers/base/power/main.c:1145: error: 'TASK_NORMAL' undeclared (first use in this function)
Presumably caused by commit d43c36dc6b357fa1806800f18aa30123c747a6d1
("headers: remove sched.h from interrupt.h") from Linus' tree.
I have added the following patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 12 Oct 2009 13:48:27 +1100
Subject: [PATCH] suspend: using TASK_ macros requires sched.h
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/base/power/main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 3b09009..fb1c648 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -29,6 +29,7 @@
#include <linux/async.h>
#include <linux/completion.h>
#include <linux/time.h>
+#include <linux/sched.h>
#include "../base.h"
#include "power.h"
--
1.6.4.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related
* linux-next: manual merge of the i7core_edac tree with Linus' tree
From: Stephen Rothwell @ 2009-10-12 3:23 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-next, linux-kernel, Ingo Molnar
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
Hi Mauro,
Today's linux-next merge of the i7core_edac tree got a conflict in
arch/x86/kernel/cpu/mcheck/mce.c between commit
f436f8bb73138bc74eb1c6527723e00988ad8a8a ("x86: EDAC: MCE: Fix MCE
decoding callback logic") from Linus' tree and commit
699a7dbe1ffdf4b25c1475e45590b181c3e23087 ("edac_mce: Add an interface
driver to report mce errors via edac") from the i7core_edac tree.
I don't know how to resolve these two commits so I have dropped the
i7core_edac tree for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* linux-next: tip tree question
From: Stephen Rothwell @ 2009-10-12 3:56 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
Cc: linux-next, LKML
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Hi all,
I noticed that the auto-latest branch of the tip tree (which is what is
included in linux-next) has had the tip out-of-tree branch merged into
it. This seems to just introduce lots of commits into linux-next that
have nothing to do with the tip tree (some of which contain fixes that
are also in Linus' tree) and adds a localversion-tip file.
I was wondering if this was done out of necessity or by oversight.
I have reverted commit e67d8da85f7a4c2772fe3731de9396b6d01a045e ("Merge
branch 'out-of-tree' into auto-latest") from linux-next for today and the
x86_64 allmodconfig and powerpc ppc64_defconfig builds still seem OK.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: linux-next: manual merge of the i7core_edac tree with Linus' tree
From: Borislav Petkov @ 2009-10-12 5:05 UTC (permalink / raw)
To: Stephen Rothwell, Ingo Molnar
Cc: Mauro Carvalho Chehab, linux-next, linux-kernel
In-Reply-To: <20091012142328.710881fe.sfr@canb.auug.org.au>
On Mon, Oct 12, 2009 at 02:23:28PM +1100, Stephen Rothwell wrote:
> Today's linux-next merge of the i7core_edac tree got a conflict in
> arch/x86/kernel/cpu/mcheck/mce.c between commit
> f436f8bb73138bc74eb1c6527723e00988ad8a8a ("x86: EDAC: MCE: Fix MCE
> decoding callback logic") from Linus' tree and commit
> 699a7dbe1ffdf4b25c1475e45590b181c3e23087 ("edac_mce: Add an interface
> driver to report mce errors via edac") from the i7core_edac tree.
The current way Ingo suggested is using an atomic notifier instead
from within print_mce to convey MCE info to an EDAC driver, see
http://marc.info/?l=linux-kernel&m=125455310112745&w=2
Ingo, what are your plans with that? I'm guessing the .33 timeframe?
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply
* linux-next: sound tree build failure
From: Stephen Rothwell @ 2009-10-12 5:08 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Lydia Wang, Logan Li
Hi Takashi,
Today's linux-next build (i386 defconfig) failed like this:
sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
Caused by commit eb7188cafcb7aa1419b8889494cdbd4e6a01da1c ("ALSA: HDA
VIA: Add VT1718S support").
sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
Caused by commit f3db423df84570c9950754a5771ad26f0111235f ("ALSA: HDA
VIA: Add VT1716S support").
sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
Caused by commit 25eaba2f8a6877ba6f58197c4723c2433a316e09 ("ALSA: HDA VIA: Add VT2002P support").
sound/pci/hda/patch_via.c: In function 'patch_vt1812':
sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
Caused by commit ab6734e7ea32e9f9cbe0f55eeddf4aa629ed1c3d ("ALSA: HDA VIA: Add VT1812 support").
I applied the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 12 Oct 2009 15:56:17 +1100
Subject: [PATCH] sound: use semicolons to end statements
Fixes:
sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
sound/pci/hda/patch_via.c: In function 'patch_vt1812':
sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
sound/pci/hda/patch_via.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 30260e2..a294060 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -4942,7 +4942,7 @@ static int patch_vt1718S(struct hda_codec *codec)
codec->patch_ops = via_patch_ops;
codec->patch_ops.init = via_auto_init;
- codec->patch_ops.unsol_event = via_unsol_event,
+ codec->patch_ops.unsol_event = via_unsol_event;
#ifdef CONFIG_SND_HDA_POWER_SAVE
spec->loopback.amplist = vt1718S_loopbacks;
@@ -5432,7 +5432,7 @@ static int patch_vt1716S(struct hda_codec *codec)
codec->patch_ops = via_patch_ops;
codec->patch_ops.init = via_auto_init;
- codec->patch_ops.unsol_event = via_unsol_event,
+ codec->patch_ops.unsol_event = via_unsol_event;
#ifdef CONFIG_SND_HDA_POWER_SAVE
spec->loopback.amplist = vt1716S_loopbacks;
@@ -5785,7 +5785,7 @@ static int patch_vt2002P(struct hda_codec *codec)
codec->patch_ops = via_patch_ops;
codec->patch_ops.init = via_auto_init;
- codec->patch_ops.unsol_event = via_unsol_event,
+ codec->patch_ops.unsol_event = via_unsol_event;
#ifdef CONFIG_SND_HDA_POWER_SAVE
spec->loopback.amplist = vt2002P_loopbacks;
@@ -6139,7 +6139,7 @@ static int patch_vt1812(struct hda_codec *codec)
codec->patch_ops = via_patch_ops;
codec->patch_ops.init = via_auto_init;
- codec->patch_ops.unsol_event = via_unsol_event,
+ codec->patch_ops.unsol_event = via_unsol_event;
#ifdef CONFIG_SND_HDA_POWER_SAVE
spec->loopback.amplist = vt1812_loopbacks;
--
1.6.4.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related
* Re: linux-next: sound tree build failure
From: Takashi Iwai @ 2009-10-12 5:34 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Lydia Wang, Logan Li
In-Reply-To: <20091012160816.90fe936d.sfr@canb.auug.org.au>
At Mon, 12 Oct 2009 16:08:16 +1100,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> Today's linux-next build (i386 defconfig) failed like this:
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
> sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
>
> Caused by commit eb7188cafcb7aa1419b8889494cdbd4e6a01da1c ("ALSA: HDA
> VIA: Add VT1718S support").
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
> sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
>
> Caused by commit f3db423df84570c9950754a5771ad26f0111235f ("ALSA: HDA
> VIA: Add VT1716S support").
>
> sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
> sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
>
> Caused by commit 25eaba2f8a6877ba6f58197c4723c2433a316e09 ("ALSA: HDA VIA: Add VT2002P support").
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1812':
> sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
>
> Caused by commit ab6734e7ea32e9f9cbe0f55eeddf4aa629ed1c3d ("ALSA: HDA VIA: Add VT1812 support").
>
> I applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 12 Oct 2009 15:56:17 +1100
> Subject: [PATCH] sound: use semicolons to end statements
>
> Fixes:
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
> sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
> sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
> sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt1812':
> sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
This error happens only when CONFIG_SND_HDA_POWER_SAVE=n, which wasn't
triggered by build tests...
I applied your fix now. Thanks Stephen!
Takashi
> ---
> sound/pci/hda/patch_via.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 30260e2..a294060 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -4942,7 +4942,7 @@ static int patch_vt1718S(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt1718S_loopbacks;
> @@ -5432,7 +5432,7 @@ static int patch_vt1716S(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt1716S_loopbacks;
> @@ -5785,7 +5785,7 @@ static int patch_vt2002P(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt2002P_loopbacks;
> @@ -6139,7 +6139,7 @@ static int patch_vt1812(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt1812_loopbacks;
> --
> 1.6.4.3
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
^ permalink raw reply
* linux-next: Tree for October 12
From: Stephen Rothwell @ 2009-10-12 5:54 UTC (permalink / raw)
To: linux-next; +Cc: LKML
[-- Attachment #1: Type: text/plain, Size: 7739 bytes --]
Changes since 20091009:
New tree: i7core_edac
Dropped tree: i7core_edac (difficult merge conflict)
My fixes tree contains a build fix for powerpc/kvm.
Linus' tree lost its build failure.
The mips tree lost its conflicts.
The parisc tree lost its conflicts.
The mfd tree still has a build failure so I used the version from
next-20091005.
The voltage tree gained a build failure so I used the version from
next-10091009.
The suspend tree gained a build failure for which I applied a patch.
The i7core_edac gained a difficult merge conflict against Linus' tree so I
dropped it for today.
I reverted a (possibly unintended) merge from the tip tree.
The sound tree gained a build failure for which I applied a patch.
----------------------------------------------------------------------------
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ). If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one. You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).
You can see which trees have been included by looking in the Next/Trees
file in the source. There are also quilt-import.log and merge.log files
in the Next directory. Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES - this fails its final link) and i386, sparc
and sparc64 defconfig. These builds also have
CONFIG_ENABLE_WARN_DEPRECATED, CONFIG_ENABLE_MUST_CHECK and
CONFIG_DEBUG_INFO disabled when necessary.
Below is a summary of the state of the merge.
We are up to 142 trees (counting Linus' and 22 trees of patches pending for
Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.
Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next . If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.
Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ , the guys at http://test.kernel.org/ and Randy
Dunlap for doing many randconfig builds.
There is a wiki covering stuff to do with linux-next at
http://linux.f-seidel.de/linux-next/pmwiki/ . Thanks to Frank Seidel.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
$ git checkout master
$ git reset --hard stable
Merging origin/master
Merging fixes/fixes
Merging arm-current/master
Merging m68k-current/for-linus
Merging powerpc-merge/merge
Merging sparc-current/master
Merging scsi-rc-fixes/master
Merging net-current/master
Merging sound-current/for-linus
Merging pci-current/for-linus
Merging wireless-current/master
Merging kbuild-current/master
Merging quilt/driver-core.current
Merging quilt/tty.current
Merging quilt/usb.current
Merging quilt/staging.current
Merging cpufreq-current/fixes
Merging input-current/for-linus
Merging md-current/for-linus
Merging audit-current/for-linus
Merging crypto-current/master
Merging ide-curent/master
Merging dwmw2/master
Merging arm/devel
Merging davinci/for-next
Merging pxa/for-next
Merging avr32/avr32-arch
Merging blackfin/for-linus
Merging cris/for-next
Merging ia64/test
Merging m68k/for-next
CONFLICT (content): Merge conflict in drivers/rtc/Kconfig
Merging m68knommu/for-next
Merging microblaze/next
Merging mips/mips-for-linux-next
Merging parisc/next
Merging powerpc/next
Merging 4xx/next
Merging galak/next
Merging s390/features
Merging sh/master
Merging sparc/master
Merging xtensa/master
Merging cifs/master
Merging configfs/linux-next
Merging ecryptfs/next
CONFLICT (content): Merge conflict in fs/ecryptfs/Kconfig
Merging ext3/for_next
Merging ext4/next
Merging fatfs/master
Merging fuse/for-next
Merging gfs2/master
Merging jfs/next
Merging nfs/linux-next
Merging nfsd/nfsd-next
Merging nilfs2/for-next
Merging ocfs2/linux-next
Merging squashfs/master
Merging udf/for_next
Merging v9fs/for-next
Merging ubifs/linux-next
Merging xfs/master
Merging reiserfs-bkl/reiserfs/kill-bkl
Merging vfs/for-next
Merging pci/linux-next
Merging hid/for-next
Merging quilt/i2c
Merging quilt/jdelvare-hwmon
Merging quilt/kernel-doc
Merging v4l-dvb/master
Merging quota/for_next
Merging kbuild/master
Merging kconfig/for-next
Merging ide/master
Merging libata/NEXT
Merging infiniband/for-next
Merging acpi/test
Merging ieee1394/for-next
Merging ubi/linux-next
Merging kvm/linux-next
Merging dlm/next
Merging scsi/master
Merging async_tx/next
Merging net/master
Merging wireless/master
Merging mtd/master
Merging crypto/master
Merging sound/for-next
Merging cpufreq/next
Merging quilt/rr
Merging mmc/next
Merging tmio-mmc/linux-next
Merging input/next
Merging lsm/for-next
Merging block/for-next
Merging quilt/device-mapper
Merging embedded/master
Merging firmware/master
Merging pcmcia/master
Merging battery/master
Merging leds/for-mm
Merging backlight/for-mm
Merging kgdb/kgdb-next
Merging slab/for-next
Merging uclinux/for-next
Merging md/for-next
Merging mfd/for-next
$ git reset --hard HEAD^
Merging refs/next/20091005/mfd
Merging hdlc/hdlc-next
Merging drm/drm-next
Merging voltage/for-next
$ git reset --hard HEAD^
Merging refs/next/20091009/voltage
Merging security-testing/next
Merging lblnet/master
Merging agp/agp-next
Merging uwb/for-upstream
Merging watchdog/master
Merging bdev/master
Merging dwmw2-iommu/master
Merging cputime/cputime
Merging osd/linux-next
Merging jc_docs/docs-next
Merging nommu/master
Merging trivial/for-next
Merging audit/for-next
Merging omap/for-next
Merging quilt/aoe
Merging suspend/linux-next
Applying: suspend: using TASK_ macros requires sched.h
Merging bluetooth/master
Merging fsnotify/for-next
Merging irda/for-next
Merging hwlat/for-linus
Merging drbd/for-jens
CONFLICT (add/add): Merge conflict in drivers/block/drbd/Kconfig
CONFLICT (add/add): Merge conflict in drivers/block/drbd/Makefile
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_actlog.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_int.h
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_main.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_nl.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_receiver.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_req.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_worker.c
CONFLICT (add/add): Merge conflict in include/linux/drbd.h
Merging catalin/for-next
Merging alacrity/linux-next
CONFLICT (content): Merge conflict in lib/Kconfig
Merging i7core_edac/linux_next
CONFLICT (content): Merge conflict in arch/x86/kernel/cpu/mcheck/mce.c
CONFLICT (content): Merge conflict in drivers/edac/Makefile
$ git reset --hard
Merging tip/auto-latest
CONFLICT (content): Merge conflict in drivers/mtd/maps/gpio-addr-flash.c
[master 49979ad] Revert "Merge branch 'out-of-tree' into auto-latest"
Merging oprofile/for-next
Merging percpu/for-next
Merging sfi/sfi-test
Merging asm-generic/next
Merging hwpoison/hwpoison
Merging quilt/driver-core
Merging quilt/tty
Merging quilt/usb
Merging quilt/staging
Merging scsi-post-merge/master
Applying: sound: use semicolons to end statements
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: linux-next: tip tree question
From: Ingo Molnar @ 2009-10-12 6:49 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, H. Peter Anvin, Peter Zijlstra, linux-next, LKML
In-Reply-To: <20091012145609.c3cc78aa.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> I noticed that the auto-latest branch of the tip tree (which is what
> is included in linux-next) has had the tip out-of-tree branch merged
> into it. [...]
That was unintended. tip:out-of-tree is like the tail section of -mm:
for useful but never-for-upstream patches.
Fixed it - thanks Stephen,
Ingo
^ permalink raw reply
* Re: [PATCH -next] libertas: depends on CFG80211
From: Holger Schurig @ 2009-10-12 7:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
Dan Williams, linux-next-u79uwXL29TY76Z2rM5mHXA,
libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
In-Reply-To: <20091009161730.6ae5fe59.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> libertas uses CFG80211 functions so it should depend on that
symbol.
Ack.
Sigh, I should concentrate more on getting clean patches on the
first iteration.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH -next] libertas: depends on CFG80211
From: Holger Schurig @ 2009-10-12 7:18 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-wireless, Dan Williams, linux-next,
libertas-dev
In-Reply-To: <20091009161730.6ae5fe59.randy.dunlap@oracle.com>
Oh, and I sent in the same patch:
http://marc.info/?l=linux-wireless&m=125507252131925&w=4
I don't care which one get's applied.
--
http://www.holgerschurig.de
^ permalink raw reply
* Re: linux-next: tip tree question
From: Stephen Rothwell @ 2009-10-12 8:42 UTC (permalink / raw)
To: Ingo Molnar
Cc: Thomas Gleixner, H. Peter Anvin, Peter Zijlstra, linux-next, LKML
In-Reply-To: <20091012064944.GA32027@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
Hi Ingo,
On Mon, 12 Oct 2009 08:49:44 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>
> That was unintended. tip:out-of-tree is like the tail section of -mm:
> for useful but never-for-upstream patches.
>
> Fixed it
OK, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: linux-next: manual merge of the i7core_edac tree with Linus' tree
From: Ingo Molnar @ 2009-10-12 10:24 UTC (permalink / raw)
To: Borislav Petkov, Stephen Rothwell, Mauro Carvalho Chehab,
linux-next, linux-kernel
In-Reply-To: <20091012050534.GC7629@liondog.tnic>
* Borislav Petkov <petkovbb@googlemail.com> wrote:
> On Mon, Oct 12, 2009 at 02:23:28PM +1100, Stephen Rothwell wrote:
> > Today's linux-next merge of the i7core_edac tree got a conflict in
> > arch/x86/kernel/cpu/mcheck/mce.c between commit
> > f436f8bb73138bc74eb1c6527723e00988ad8a8a ("x86: EDAC: MCE: Fix MCE
> > decoding callback logic") from Linus' tree and commit
> > 699a7dbe1ffdf4b25c1475e45590b181c3e23087 ("edac_mce: Add an interface
> > driver to report mce errors via edac") from the i7core_edac tree.
>
> The current way Ingo suggested is using an atomic notifier instead
> from within print_mce to convey MCE info to an EDAC driver, see
> http://marc.info/?l=linux-kernel&m=125455310112745&w=2
>
> Ingo, what are your plans with that? I'm guessing the .33 timeframe?
yeah, that looks like .33 material. (unless it fixes a regression)
I have queued it up in tip:x86/mce.
Thanks,
Ingo
^ permalink raw reply
* Re: linux-next: voltage tree build failure
From: Mark Brown @ 2009-10-12 12:57 UTC (permalink / raw)
To: Haojian Zhuang
Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
Samuel Ortiz
In-Reply-To: <771cded00910111950y6104fe0fl4f1d10144d938243@mail.gmail.com>
On Sun, Oct 11, 2009 at 10:50:54PM -0400, Haojian Zhuang wrote:
> Hi Samuel & Liam,
> Please help review and merge this fix patch. I'm sorry for inconvience.
This is waiting for Samuel - it should go via the MFD tree. I've CCed
in Samuel's current e-mail address on the off-chance that that helps.
^ permalink raw reply
* Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional
From: Ingo Molnar @ 2009-10-12 12:59 UTC (permalink / raw)
To: Henrique de Moraes Holschuh
Cc: Randy Dunlap, Stephen Rothwell, lenb, linux-next, LKML
In-Reply-To: <20091010000808.GA10637@khazad-dum.debian.net>
* Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote:
> On Fri, 09 Oct 2009, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Fix optional part of driver to be built optionally:
>
> NAK!
>
> This happens because of (linux-next) commit
> 7f6443f7238a0aa9014b11a0a31ab76825d75cdf
> "thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL" by
> Ingo.
>
> That commit is wrong, it must NOT be applied as explained in the
> thread starting at http://lkml.org/lkml/2009/9/27/30.
Yep, that was wrong - it should be gone now.
Ingo
^ permalink raw reply
* Re: linux-next: voltage tree build failure
From: Samuel Ortiz @ 2009-10-12 13:35 UTC (permalink / raw)
To: Mark Brown
Cc: Haojian Zhuang, Stephen Rothwell, Liam Girdwood, linux-next,
linux-kernel
In-Reply-To: <20091012125707.GE22233@sirena.org.uk>
On Mon, Oct 12, 2009 at 01:57:07PM +0100, Mark Brown wrote:
> On Sun, Oct 11, 2009 at 10:50:54PM -0400, Haojian Zhuang wrote:
>
> > Hi Samuel & Liam,
>
> > Please help review and merge this fix patch. I'm sorry for inconvience.
>
> This is waiting for Samuel - it should go via the MFD tree. I've CCed
> in Samuel's current e-mail address on the off-chance that that helps.
Patch applied and pushed. Sorry for the delay, I wasnt cc'ed at first.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply
* Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional
From: Henrique de Moraes Holschuh @ 2009-10-12 15:41 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Randy Dunlap, Stephen Rothwell, lenb, linux-next, LKML
In-Reply-To: <20091012125942.GA25464@elte.hu>
On Mon, 12 Oct 2009, Ingo Molnar wrote:
> * Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote:
> > On Fri, 09 Oct 2009, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > Fix optional part of driver to be built optionally:
> >
> > NAK!
> >
> > This happens because of (linux-next) commit
> > 7f6443f7238a0aa9014b11a0a31ab76825d75cdf
> > "thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL" by
> > Ingo.
> >
> > That commit is wrong, it must NOT be applied as explained in the
> > thread starting at http://lkml.org/lkml/2009/9/27/30.
>
> Yep, that was wrong - it should be gone now.
Thank you.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox