Linux-Next discussions
 help / color / mirror / Atom feed
* [PATCH -next] tpm: fix header for modular build
From: Randy Dunlap @ 2009-10-28 17:49 UTC (permalink / raw)
  To: Stephen Rothwell, tpmdd-devel; +Cc: linux-next, LKML, akpm
In-Reply-To: <20091028190643.627f10aa.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix build for TCG_TPM=m.  Header file doesn't handle this
and incorrectly builds stubs.

drivers/char/tpm/tpm.c:720: error: redefinition of 'tpm_pcr_read'
include/linux/tpm.h:35: error:previous definition of 'tpm_pcr_read' was here
drivers/char/tpm/tpm.c:752: error: redefinition of 'tpm_pcr_extend'
include/linux/tpm.h:38: error:previous definition of 'tpm_pcr_extend' was here

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 include/linux/tpm.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20091028.orig/include/linux/tpm.h
+++ linux-next-20091028/include/linux/tpm.h
@@ -27,7 +27,7 @@
  */
 #define	TPM_ANY_NUM 0xFFFF
 
-#if defined(CONFIG_TCG_TPM)
+#if defined(CONFIG_TCG_TPM) || defined(CONFIG_TCG_TPM_MODULE)
 
 extern int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf);
 extern int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash);

^ permalink raw reply

* RE: [PATCH -next] ia64/sn: fix percpu warnings
From: Luck, Tony @ 2009-10-28 16:58 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Randy Dunlap, Stephen Rothwell, linux-ia64@vger.kernel.org,
	linux-next@vger.kernel.org, LKML, akpm
In-Reply-To: <4AE87344.6030708@kernel.org>

> DEFINE_PER_CPU(struct list_head [NR_SOFTIRQS], softirq_work_list);
> EXPORT_PER_CPU_SYMBOL(softirq_work_list);
>
> and it doesn't cause any warning on x86 neither does it on ia64 with
> defconfig.  softirq_work_list doesn't trigger any warning there,
> right?

Of the 10 EXPORT_PER_CPU_SYMBOL and 4 EXPORT_PER_CPU_SYMBOL_GPL
items on ia64, only __sn_cnodeid_to_nasid and softirq_work_list are
arrays.  The latter appears not to be actually used by any in-tree
modules (janitors: does it need to be exported?).

The CRC warning only shows up on a module that uses an exported
per-cpu array.  There seems to be nothing special about the
__sn_cnodeid_to_nasid.  When I hacked a module to make a random
use of softirq_work_list, it too gave a CRC error.

I just tried an x86_64 build with a module also modified to access
softirq_work_list.  It did NOT get a CRC error.  So the x86_64
toolchain doesn't seem to have the same issue as ia64.

-Tony

^ permalink raw reply

* Re: [PATCH -next] ia64/sn: fix percpu warnings
From: Tejun Heo @ 2009-10-28 16:37 UTC (permalink / raw)
  To: Luck, Tony
  Cc: Randy Dunlap, Stephen Rothwell, linux-ia64@vger.kernel.org,
	linux-next@vger.kernel.org, LKML, akpm
In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA3E34C0108@orsmsx505.amr.corp.intel.com>

Hello,

Luck, Tony wrote:
> That's what Randy's patch uses ... but doing it the "right" way gives
> me the "has no CRC!" warning.

Ah, right.  I got confused.

> This seems to be a feature of exported per cpu arrays.  If I hack
> up a driver to make use of softirq_work_list, I see a similar
> no CRC warning for it.
> 
> Is this problem in the ia64 tool chain[1]?  Or do other architectures
> have problems with exported per cpu arrays?

kern/softirq.c has the followings.

 DEFINE_PER_CPU(struct list_head [NR_SOFTIRQS], softirq_work_list);
 EXPORT_PER_CPU_SYMBOL(softirq_work_list);

and it doesn't cause any warning on x86 neither does it on ia64 with
defconfig.  softirq_work_list doesn't trigger any warning there,
right?

Thanks.

-- 
tejun

^ permalink raw reply

* RE: [PATCH -next] ia64/sn: fix percpu warnings
From: Luck, Tony @ 2009-10-28 16:24 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Randy Dunlap, Stephen Rothwell, linux-ia64@vger.kernel.org,
	linux-next@vger.kernel.org, LKML, akpm
In-Reply-To: <4AE85D28.90809@kernel.org>

> Umm... the correct correct declaration and definition would be
> 
> DECLARE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid);
>
> and
>
> DEFINE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid);
>
> So that the first part contains full type.  Doing it the other way
> might cause problems if the __weak trick is turned on.

That's what Randy's patch uses ... but doing it the "right" way gives
me the "has no CRC!" warning.

This seems to be a feature of exported per cpu arrays.  If I hack
up a driver to make use of softirq_work_list, I see a similar
no CRC warning for it.

Is this problem in the ia64 tool chain[1]?  Or do other architectures
have problems with exported per cpu arrays?

-Tony

[1] My default toolchain is uses gcc 4.1.2.  But 4.4.1 has the same
behavior.


^ permalink raw reply

* Re: [PATCH -next] ia64/sn: fix percpu warnings
From: Tejun Heo @ 2009-10-28 15:03 UTC (permalink / raw)
  To: Luck, Tony
  Cc: Randy Dunlap, Stephen Rothwell, Jes Sorensen,
	linux-ia64@vger.kernel.org, linux-next@vger.kernel.org, LKML,
	akpm
In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA3E345953E@orsmsx505.amr.corp.intel.com>

Hello,

Luck, Tony wrote:
>> WARNING: "per_cpu____sn_cnodeid_to_nasid" [drivers/misc/sgi-xp/xpc.ko] has no CRC!
> 
> Note that this warning goes away if I fix the mismatch declaration so
> that we have:
> 
> DECLARE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]);
> in arch.h
> 
> and
> 
> DEFINE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]);
> in setup.c

Umm... the correct correct declaration and definition would be

DECLARE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid);

and

DEFINE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid);

So that the first part contains full type.  Doing it the other way
might cause problems if the __weak trick is turned on.

Thanks.

-- 
tejun

^ permalink raw reply

* Re: [PATCH -next] netxen: fix builds for SYSFS=n or MODULES=n
From: David Miller @ 2009-10-28  9:36 UTC (permalink / raw)
  To: randy.dunlap; +Cc: sfr, netdev, linux-next, linux-kernel, dhananjay
In-Reply-To: <20091026150945.3f35a811.randy.dunlap@oracle.com>

From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Mon, 26 Oct 2009 15:09:45 -0700

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> When CONFIG_MODULES=n:
> drivers/net/netxen/netxen_nic_main.c:2751: error: dereferencing pointer to incomplete type
> drivers/net/netxen/netxen_nic_main.c:2764: error: dereferencing pointer to incomplete type
> 
> Also needs addition of <linux/sysfs.h> for sysfs function prototypes or
> stubs when CONFIG_SYSFS=n.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, thanks Randy.

^ permalink raw reply

* Re: [PATCH -next] netxen: fix builds for SYSFS=n or MODULES=n
From: David Miller @ 2009-10-28  9:34 UTC (permalink / raw)
  To: dhananjay.phadke; +Cc: randy.dunlap, sfr, netdev, linux-next, linux-kernel
In-Reply-To: <7608421F3572AB4292BB2532AE89D5658B0B8903CB@AVEXMB1.qlogic.org>

From: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Date: Tue, 27 Oct 2009 15:09:24 -0700

> Sorry, seems like I am keeping you busy with the build errors.
> Thanks for fixing it again (may be I need to setup all different build configs).
> 
> Acked-by: Dhananjay Phadke <dhananjay@netxen.com>

Please adhere to the following netiquette when replying to
patches:

1) DO NOT TOP POST.

   You can feel free to continue doing this, but I am warning you
   that soon a day will come when replying to postings in a top-post
   manner will have your posting completely rejected from the list.

   This is absolutely the largest pet peeve amongst kernel developers.
   Quote only the relevant parts of the message, nothing more, and
   then afterwards you place your comments.  Do not add comments
   before the quoted material.  People need to read the quoted part to
   gain the context necessary to understand your reply, not the other
   way around.

2) Do not quote the patch when just adding your ACK or signoff.

   That makes the patch appear twice in patchwork, making more work
   for me and confusion for the patch submitted.

Thank you.

^ permalink raw reply

* linux-next: Tree for October 28
From: Stephen Rothwell @ 2009-10-28  8:06 UTC (permalink / raw)
  To: linux-next; +Cc: LKML

[-- Attachment #1: Type: text/plain, Size: 7946 bytes --]

Hi all,

[The kernel.org mirroring seems to be lagging a bit today ...]

Changes since 20091027:

Removed tree: quota (at the maintainers request)

My fixes tree contains a build fix for powerpc/kvm.

The sh tree gained a conflict against the powerpc-merge tree.

The block tree still has a build failure so I used the version from
next-20091026.

The tip tree gained a conflict against the kgdb tree.

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES - this fails its final link) and i386, sparc
and sparc64 defconfig. These builds also have
CONFIG_ENABLE_WARN_DEPRECATED, CONFIG_ENABLE_MUST_CHECK and
CONFIG_DEBUG_INFO disabled when necessary.

Below is a summary of the state of the merge.

We are up to 145 trees (counting Linus' and 22 trees of patches pending for
Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ , the guys at http://test.kernel.org/ and Randy
Dunlap for doing many randconfig builds.

There is a wiki covering stuff to do with linux-next at
http://linux.f-seidel.de/linux-next/pmwiki/ .  Thanks to Frank Seidel.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

$ git checkout master
$ git reset --hard stable
Merging origin/master
Merging fixes/fixes
Merging arm-current/master
Merging m68k-current/for-linus
Merging powerpc-merge/merge
Merging sparc-current/master
Merging scsi-rc-fixes/master
Merging net-current/master
Merging sound-current/for-linus
Merging pci-current/for-linus
Merging wireless-current/master
Merging kbuild-current/master
Merging quilt/driver-core.current
Merging quilt/tty.current
Merging quilt/usb.current
Merging quilt/staging.current
Merging cpufreq-current/fixes
Merging input-current/for-linus
Merging md-current/for-linus
Merging audit-current/for-linus
Merging crypto-current/master
Merging ide-curent/master
Merging dwmw2/master
Merging arm/devel
Merging davinci/davinci-next
Merging omap/for-next
Merging pxa/for-next
Merging avr32/avr32-arch
Merging blackfin/for-linus
Merging cris/for-next
Merging ia64/test
Merging m68k/for-next
CONFLICT (content): Merge conflict in drivers/rtc/Kconfig
Merging m68knommu/for-next
Merging microblaze/next
Merging mips/mips-for-linux-next
Merging parisc/next
Merging powerpc/next
Merging 4xx/next
Merging galak/next
Merging s390/features
Merging sh/master
CONFLICT (content): Merge conflict in fs/Kconfig
Merging sparc/master
Merging xtensa/master
Merging ceph/for-next
Merging cifs/master
Merging configfs/linux-next
Merging ecryptfs/next
Merging ext3/for_next
Merging ext4/next
Merging fatfs/master
Merging fuse/for-next
Merging gfs2/master
Merging jfs/next
Merging nfs/linux-next
Merging nfsd/nfsd-next
Merging nilfs2/for-next
Merging ocfs2/linux-next
Merging squashfs/master
Merging udf/for_next
Merging v9fs/for-next
Merging ubifs/linux-next
Merging xfs/master
Merging reiserfs-bkl/reiserfs/kill-bkl
Merging vfs/for-next
Merging pci/linux-next
Merging hid/for-next
Merging quilt/i2c
Merging quilt/jdelvare-hwmon
Merging quilt/kernel-doc
Merging v4l-dvb/master
Merging kbuild/master
Merging kconfig/for-next
Merging ide/master
Merging libata/NEXT
Merging infiniband/for-next
Merging acpi/test
Merging ieee1394/for-next
Merging ubi/linux-next
Merging kvm/linux-next
CONFLICT (content): Merge conflict in arch/x86/kvm/mmu.c
Merging dlm/next
Merging scsi/master
Merging async_tx/next
Merging net/master
CONFLICT (delete/modify): drivers/net/sfc/sfe4001.c deleted in net/master and modified in HEAD. Version HEAD of drivers/net/sfc/sfe4001.c left in tree.
$ git rm -f drivers/net/sfc/sfe4001.c
Applying: net: merge fixup for drivers/net/sfc/falcon_boards.c
Merging wireless/master
CONFLICT (content): Merge conflict in drivers/net/wireless/libertas/cmd.c
Merging mtd/master
Merging crypto/master
Merging sound/for-next
Merging cpufreq/next
Merging quilt/rr
Merging mmc/next
Merging tmio-mmc/linux-next
Merging input/next
Merging lsm/for-next
Merging block/for-next
$ git reset --hard HEAD^
Merging refs/next/20091026/block
Merging quilt/device-mapper
Merging embedded/master
Merging firmware/master
Merging pcmcia/master
Merging battery/master
Merging leds/for-mm
Merging backlight/for-mm
Merging kgdb/kgdb-next
Merging slab/for-next
Merging uclinux/for-next
Merging md/for-next
Merging mfd/for-next
Merging hdlc/hdlc-next
Merging drm/drm-next
Merging voltage/for-next
CONFLICT (content): Merge conflict in drivers/mfd/Kconfig
CONFLICT (content): Merge conflict in drivers/mfd/Makefile
Merging security-testing/next
CONFLICT (content): Merge conflict in Documentation/dontdiff
Merging lblnet/master
Merging agp/agp-next
Merging uwb/for-upstream
Merging watchdog/master
Merging bdev/master
Merging dwmw2-iommu/master
Merging cputime/cputime
Merging osd/linux-next
Merging jc_docs/docs-next
Merging nommu/master
Merging trivial/for-next
CONFLICT (content): Merge conflict in drivers/acpi/video_detect.c
Merging audit/for-next
Merging quilt/aoe
Merging suspend/linux-next
Merging bluetooth/master
Merging fsnotify/for-next
Merging irda/for-next
Merging hwlat/for-linus
CONFLICT (content): Merge conflict in drivers/misc/Makefile
Merging drbd/for-jens
CONFLICT (add/add): Merge conflict in drivers/block/drbd/Kconfig
CONFLICT (add/add): Merge conflict in drivers/block/drbd/Makefile
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_actlog.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_int.h
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_main.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_nl.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_receiver.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_req.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_worker.c
CONFLICT (add/add): Merge conflict in include/linux/drbd.h
Merging catalin/for-next
Merging alacrity/linux-next
CONFLICT (content): Merge conflict in drivers/net/Kconfig
CONFLICT (content): Merge conflict in lib/Kconfig
Merging i7core_edac/linux_next
Merging devicetree/next-devicetree
Merging limits/writable_limits
Merging tip/auto-latest
CONFLICT (content): Merge conflict in arch/x86/kernel/kgdb.c
Merging oprofile/for-next
Merging percpu/for-next
Merging sfi/sfi-test
Merging asm-generic/next
Merging hwpoison/hwpoison
Merging quilt/driver-core
Merging quilt/tty
Merging quilt/usb
Merging quilt/staging
CONFLICT (content): Merge conflict in drivers/net/wireless/Kconfig
Applying: staging: merge fixup for wireless drivers move
Merging scsi-post-merge/master

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply

* linux-next: i7core_edac tree build warning
From: Stephen Rothwell @ 2009-10-28  7:59 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-next, linux-kernel, Aristeu Rozanski

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

Hi Mauro,

Today's linux-next build (i386 defconfig) produced this warning:

WARNING: arch/x86/pci/built-in.o(__ksymtab_gpl+0x8): Section mismatch in reference from the variable __ksymtab_pci_legacy_init to the function .init.text:pci_legacy_init()
The symbol pci_legacy_init is exported and annotated __init 
Fix this by removing the __init annotation of pci_legacy_init or drop the export.

Introduced by commit a120a84ebbc4cbc9c1addddd2b491e3683b842a6 ("pci: Add
a probing code that seeks for an specific bus").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply

* Re: linux-next: tip tree build warning
From: Ingo Molnar @ 2009-10-28  7:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Thomas Gleixner, H. Peter Anvin, Peter Zijlstra, linux-next,
	linux-kernel
In-Reply-To: <20091028184851.504752ef.sfr@canb.auug.org.au>


* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> On Wed, 28 Oct 2009 18:41:26 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > static inline physid_mask_t default_apicid_to_cpu_present(int phys_apicid)
> > {
> >         return physid_mask_of_physid(phys_apicid);
> > }
> 
> I just noticed that this function (default_apicid_to_cpu_present) is 
> declared "static inline in a header" but looks like it is only used by 
> assigning its address to a function pointer.  Its only use for x86_64 
> is in arch/x86/kernel/apic/apic_noop.c ...

yes, that might be a real problem - returning the mask like that is 
messy. Thanks, will check.

	Ingo

^ permalink raw reply

* Re: linux-next: tip tree build warning
From: Stephen Rothwell @ 2009-10-28  7:48 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Thomas Gleixner, H. Peter Anvin, Peter Zijlstra, linux-next,
	linux-kernel
In-Reply-To: <20091028184126.b5f52d1b.sfr@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

Hi all,

On Wed, 28 Oct 2009 18:41:26 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> static inline physid_mask_t default_apicid_to_cpu_present(int phys_apicid)
> {
>         return physid_mask_of_physid(phys_apicid);
> }

I just noticed that this function (default_apicid_to_cpu_present) is
declared "static inline in a header" but looks like it is only used by
assigning its address to a function pointer.  Its only use for x86_64 is
in arch/x86/kernel/apic/apic_noop.c ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply

* Re: linux-next: tip tree build warning
From: Stephen Rothwell @ 2009-10-28  7:41 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Thomas Gleixner, H. Peter Anvin, Peter Zijlstra, linux-next,
	linux-kernel
In-Reply-To: <20091028073145.GD6353@elte.hu>

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Hi Ingo,

On Wed, 28 Oct 2009 08:31:45 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> 
> That commit is very simple. Are you sure it's not GCC bogosity?

That commit just produces the warning (since it introduced the
apic_noop.c file) and probably has nothing directly to do with the
problem (as I said).

The relevant part of apic.h is:

static inline physid_mask_t default_apicid_to_cpu_present(int phys_apicid)
{
        return physid_mask_of_physid(phys_apicid);
}

Where physid_mask_of_physid() manipulates a physid_mask_t which contains
an array of unsigned longs that is BITS_TO_LONGS(MAX_APICS) long and
MAX_APICS is 32768.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply

* Re: linux-next: tip tree build warning
From: Ingo Molnar @ 2009-10-28  7:31 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Thomas Gleixner, H. Peter Anvin, Peter Zijlstra, linux-next,
	linux-kernel
In-Reply-To: <20091028181443.50a09dbb.sfr@canb.auug.org.au>


* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> In file included from arch/x86/include/asm/smp.h:13,
>                  from arch/x86/include/asm/mmzone_64.h:12,
>                  from arch/x86/include/asm/mmzone.h:4,
>                  from include/linux/mmzone.h:783,
>                  from include/linux/gfp.h:4,
>                  from include/linux/kmod.h:22,
>                  from include/linux/module.h:13,
>                  from arch/x86/kernel/apic/apic_noop.c:14:
> arch/x86/include/asm/apic.h: In function 'default_apicid_to_cpu_present':
> arch/x86/include/asm/apic.h:591: warning: the frame size of 8192 bytes is larger than 2048 bytes
> 
> It may not have been caused by the tip tree, but I can't find what 
> changed to cause this and a commit from the tip tree has exposed it 
> (9844ab11c763bfed9f054c82366b19dcda66aca9 "x86, apic: Introduce the 
> NOOP apic driver").

That commit is very simple. Are you sure it's not GCC bogosity?

	Ingo

^ permalink raw reply

* linux-next: tip tree build warning
From: Stephen Rothwell @ 2009-10-28  7:14 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

Hi all,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

In file included from arch/x86/include/asm/smp.h:13,
                 from arch/x86/include/asm/mmzone_64.h:12,
                 from arch/x86/include/asm/mmzone.h:4,
                 from include/linux/mmzone.h:783,
                 from include/linux/gfp.h:4,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from arch/x86/kernel/apic/apic_noop.c:14:
arch/x86/include/asm/apic.h: In function 'default_apicid_to_cpu_present':
arch/x86/include/asm/apic.h:591: warning: the frame size of 8192 bytes is larger than 2048 bytes

It may not have been caused by the tip tree, but I can't find what
changed to cause this and a commit from the tip tree has exposed it
(9844ab11c763bfed9f054c82366b19dcda66aca9 "x86, apic: Introduce the NOOP
apic driver").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply

* linux-next: manual merge of the tip tree with the kgdb tree
From: Stephen Rothwell @ 2009-10-28  7:04 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: linux-next, linux-kernel, Jason Wessel

Hi all,

Today's linux-next merge of the tip tree got a conflict in
arch/x86/kernel/kgdb.c between commit
1cde88814e04c3b2bbe60e20c0927a0b4e1748ab ("kgdb,i386: Fix corner case
access to sp with NMI watch dog exception") from the kgdb tree and commit
5ca6c0ca5dbf105d7b0ffdae2289519982189730 ("x86: use kernel_stack_pointer
() in kgdb.c") from the tip tree.

I fixed it up (see below) but would like people to check as I am not sure
of the fix.  I can carry this as necessary.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc arch/x86/kernel/kgdb.c
index e9afae9,3310d84..0000000
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@@ -85,15 -85,9 +85,15 @@@ void pt_regs_to_gdb_regs(unsigned long 
  	gdb_regs[GDB_DS]	= regs->ds;
  	gdb_regs[GDB_ES]	= regs->es;
  	gdb_regs[GDB_CS]	= regs->cs;
 -	gdb_regs[GDB_SS]	= __KERNEL_DS;
  	gdb_regs[GDB_FS]	= 0xFFFF;
  	gdb_regs[GDB_GS]	= 0xFFFF;
 +	if (user_mode_vm(regs)) {
 +		gdb_regs[GDB_SS] = regs->ss;
 +		gdb_regs[GDB_SP] = regs->sp;
 +	} else {
 +		gdb_regs[GDB_SS] = __KERNEL_DS;
- 		gdb_regs[GDB_SP] = (unsigned long)&regs->sp;
++		gdb_regs[GDB_SP] = kernel_stack_pointer(regs);
 +	}
  #else
  	gdb_regs[GDB_R8]	= regs->r8;
  	gdb_regs[GDB_R9]	= regs->r9;
@@@ -106,8 -100,8 +106,8 @@@
  	gdb_regs32[GDB_PS]	= regs->flags;
  	gdb_regs32[GDB_CS]	= regs->cs;
  	gdb_regs32[GDB_SS]	= regs->ss;
- 	gdb_regs[GDB_SP]	= regs->sp;
 -#endif
+ 	gdb_regs[GDB_SP]	= kernel_stack_pointer(regs);
 +#endif
  }
  
  /**

^ permalink raw reply

* linux-next: manual merge of the sh tree with the powerpc-merge tree
From: Stephen Rothwell @ 2009-10-28  2:13 UTC (permalink / raw)
  To: Paul Mundt
  Cc: linux-next, linux-kernel, Kumar Gala, Benjamin Herrenschmidt,
	Paul Mackerras, linuxppc-dev

Hi Paul,

Today's linux-next merge of the sh tree got a conflict in fs/Kconfig
between commit 0cd9ad73b8d181737005ff4e506b9b6bd043f4dd ("powerpc: Limit
hugetlbfs support to PPC64 Book-3S machines") from the powerpc-merge tree
and commit ffb4a73d8906f71910e6c83ec2b499e70025ee8e ("sh: Fix hugetlbfs
dependencies for SH-3 && MMU configurations") from the sh tree.

I fixed it up (see below) and can carry the fix for a while (the
powerpc-merge commit should be in Linus' tree soon).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc fs/Kconfig
index f93d0ed,48b81f9..0000000
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@@ -135,8 -135,8 +135,8 @@@ config TMPFS_POSIX_AC
  
  config HUGETLBFS
  	bool "HugeTLB file system support"
- 	depends on X86 || IA64 || PPC_BOOK3S_64 || SPARC64 || (SUPERH && MMU) || \
 -	depends on X86 || IA64 || PPC64 || SPARC64 || (S390 && 64BIT) || \
 -		   SYS_SUPPORTS_HUGETLBFS || BROKEN
++	depends on X86 || IA64 || PPC_BOOK3S_64 || SPARC64 || \
 +		   (S390 && 64BIT) || SYS_SUPPORTS_HUGETLBFS || BROKEN
  	help
  	  hugetlbfs is a filesystem backing for HugeTLB pages, based on
  	  ramfs. For architectures that support it, say Y here and read

^ permalink raw reply

* RE: [PATCH -next] netxen: fix builds for SYSFS=n or MODULES=n
From: Dhananjay Phadke @ 2009-10-27 22:09 UTC (permalink / raw)
  To: Randy Dunlap, Stephen Rothwell, netdev
  Cc: linux-next@vger.kernel.org, LKML, davem@davemloft.net
In-Reply-To: <20091026150945.3f35a811.randy.dunlap@oracle.com>

Sorry, seems like I am keeping you busy with the build errors.
Thanks for fixing it again (may be I need to setup all different build configs).

Acked-by: Dhananjay Phadke <dhananjay@netxen.com>

-----Original Message-----
From: Randy Dunlap [mailto:randy.dunlap@oracle.com] 
Sent: Monday, October 26, 2009 3:10 PM
To: Stephen Rothwell; netdev
Cc: linux-next@vger.kernel.org; LKML; davem@davemloft.net; Dhananjay Phadke
Subject: [PATCH -next] netxen: fix builds for SYSFS=n or MODULES=n

From: Randy Dunlap <randy.dunlap@oracle.com>

When CONFIG_MODULES=n:
drivers/net/netxen/netxen_nic_main.c:2751: error: dereferencing pointer to incomplete type
drivers/net/netxen/netxen_nic_main.c:2764: error: dereferencing pointer to incomplete type

Also needs addition of <linux/sysfs.h> for sysfs function prototypes or
stubs when CONFIG_SYSFS=n.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/net/netxen/netxen_nic_main.c |    9 +++++++++
 1 file changed, 9 insertions(+)

--- linux-next-20091026.orig/drivers/net/netxen/netxen_nic_main.c
+++ linux-next-20091026/drivers/net/netxen/netxen_nic_main.c
@@ -34,6 +34,7 @@
 #include <net/ip.h>
 #include <linux/ipv6.h>
 #include <linux/inetdevice.h>
+#include <linux/sysfs.h>
 
 MODULE_DESCRIPTION("NetXen Multi port (1/10) Gigabit Network Driver");
 MODULE_LICENSE("GPL");
@@ -2500,6 +2501,7 @@ static struct bin_attribute bin_attr_mem
 	.write = netxen_sysfs_write_mem,
 };
 
+#ifdef CONFIG_MODULES
 static ssize_t
 netxen_store_auto_fw_reset(struct module_attribute *mattr,
 		struct module *mod, const char *buf, size_t count)
@@ -2534,6 +2536,7 @@ static struct module_attribute mod_attr_
 	.show = netxen_show_auto_fw_reset,
 	.store = netxen_store_auto_fw_reset,
 };
+#endif
 
 static void
 netxen_create_sysfs_entries(struct netxen_adapter *adapter)
@@ -2739,7 +2742,9 @@ static struct pci_driver netxen_driver =
 
 static int __init netxen_init_module(void)
 {
+#ifdef CONFIG_MODULES
 	struct module *mod = THIS_MODULE;
+#endif
 
 	printk(KERN_INFO "%s\n", netxen_nic_driver_string);
 
@@ -2748,9 +2753,11 @@ static int __init netxen_init_module(voi
 	register_inetaddr_notifier(&netxen_inetaddr_cb);
 #endif
 
+#ifdef CONFIG_MODULES
 	if (sysfs_create_file(&mod->mkobj.kobj, &mod_attr_fw_reset.attr))
 		printk(KERN_ERR "%s: Failed to create auto_fw_reset "
 				"sysfs entry.", netxen_nic_driver_name);
+#endif
 
 	return pci_register_driver(&netxen_driver);
 }
@@ -2759,9 +2766,11 @@ module_init(netxen_init_module);
 
 static void __exit netxen_exit_module(void)
 {
+#ifdef CONFIG_MODULES
 	struct module *mod = THIS_MODULE;
 
 	sysfs_remove_file(&mod->mkobj.kobj, &mod_attr_fw_reset.attr);
+#endif
 
 	pci_unregister_driver(&netxen_driver);
 

^ permalink raw reply

* Re: linux-next: manual merge of the staging tree with the net/wireless tree
From: Greg KH @ 2009-10-27 16:23 UTC (permalink / raw)
  To: John W. Linville
  Cc: Stephen Rothwell, linux-next, linux-kernel, David S. Miller,
	Johannes Berg, Holger Schurig
In-Reply-To: <20091027145631.GB15566@tuxdriver.com>

On Tue, Oct 27, 2009 at 10:56:31AM -0400, John W. Linville wrote:
> On Tue, Oct 27, 2009 at 07:13:25AM -0700, Greg KH wrote:
> > On Tue, Oct 27, 2009 at 06:35:03PM +1100, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > Today's linux-next merge of the staging tree got conflicts in
> > > drivers/net/wireless/Kconfig between commits
> > > 3d23e349d807177eaf519d444677cee86b1a04cf ("wext: refactor") and
> > > 0465af8e03bdc6cd0b49dc5548671387a8674b69 ("libertas: separate libertas'
> > > Kconfig in it's own file") from the net/wireless tree and various commits
> > > ("... move driver to staging") from the staging tree.
> > > 
> > > I fixed it up (see below) and added a merge fixup (see further below) and
> > > can carry these as necessary (though it may be easier for everyone (i.e.
> > > me :-)) if these 4 staging tree commits are moved to the wireless
> > > tree ...).
> > 
> > John, I have no objection to these 4 commits going through your tree, if
> > it will make these types of merge issues go away.  If so, I have 4 more
> > patches that should be added, adding the TODO files for the drivers.  I
> > can send them to you if you want to take them.
> 
> Sure, that would be fine.  I did get copies of the TODO addition
> patches, but I deleted them as I had not yet seen this. :-(  Could
> you resend them to me?

Now sent.

thanks,

greg k-h

^ permalink raw reply

* Re: linux-next: manual merge of the staging tree with the net/wireless tree
From: John W. Linville @ 2009-10-27 14:56 UTC (permalink / raw)
  To: Greg KH
  Cc: Stephen Rothwell, linux-next, linux-kernel, David S. Miller,
	Johannes Berg, Holger Schurig
In-Reply-To: <20091027141325.GA17352@kroah.com>

On Tue, Oct 27, 2009 at 07:13:25AM -0700, Greg KH wrote:
> On Tue, Oct 27, 2009 at 06:35:03PM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > Today's linux-next merge of the staging tree got conflicts in
> > drivers/net/wireless/Kconfig between commits
> > 3d23e349d807177eaf519d444677cee86b1a04cf ("wext: refactor") and
> > 0465af8e03bdc6cd0b49dc5548671387a8674b69 ("libertas: separate libertas'
> > Kconfig in it's own file") from the net/wireless tree and various commits
> > ("... move driver to staging") from the staging tree.
> > 
> > I fixed it up (see below) and added a merge fixup (see further below) and
> > can carry these as necessary (though it may be easier for everyone (i.e.
> > me :-)) if these 4 staging tree commits are moved to the wireless
> > tree ...).
> 
> John, I have no objection to these 4 commits going through your tree, if
> it will make these types of merge issues go away.  If so, I have 4 more
> patches that should be added, adding the TODO files for the drivers.  I
> can send them to you if you want to take them.

Sure, that would be fine.  I did get copies of the TODO addition
patches, but I deleted them as I had not yet seen this. :-(  Could
you resend them to me?

Thanks!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply

* Re: [PATCH 9/9] pcmcia: remove pcmcia_get_{first,next}_tuple()
From: Greg KH @ 2009-10-27 14:39 UTC (permalink / raw)
  To: Randy Dunlap, devel, linux-next, linux-pcmcia
In-Reply-To: <20091027051224.GA10891@isilmar.linta.de>

On Tue, Oct 27, 2009 at 06:12:24AM +0100, Dominik Brodowski wrote:
> Randy,
> 
> On Mon, Oct 26, 2009 at 03:19:58PM -0700, Randy Dunlap wrote:
> > > Remove the pcmcia_get_{first,next}_tuple() calls no longer needed by
> > > (current) pcmcia device drivers.
> > 
> > linux-next 20091026:
> > 
> > drivers/staging/comedi/drivers/cb_das16_cs.c:155: error: implicit declaration of function 'pcmcia_get_first_tuple'
> > drivers/staging/comedi/drivers/cb_das16_cs.c:156: error: implicit declaration of function 'pcmcia_get_tuple_data'
> > drivers/staging/comedi/drivers/cb_das16_cs.c:883: error: implicit declaration of function 'pcmcia_get_next_tuple'
> > 
> > There are also other comedi/ drivers that this randconfig didn't attempt
> > to build that are still using these same interfaces.
> 
> What are the current rules on drivers in staging/ ? Do they need to be
> updated as well on API changes?

You don't have to do it, no.  I'll be glad to do so as long as I get a
hint as to what needs to be done :)

thanks,

greg k-h

^ permalink raw reply

* Re: next tree for October 27:  znet build failure
From: Stephen Rothwell @ 2009-10-27 14:37 UTC (permalink / raw)
  To: Sachin Sant; +Cc: linux-next, netdev, David Miller, John W. Linville, Greg KH
In-Reply-To: <4AE6BEC7.2030703@in.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Just adding John and Greg to the cc list as this is caused by patches in
the staging tree.

On Tue, 27 Oct 2009 15:05:03 +0530 Sachin Sant <sachinp@in.ibm.com> wrote:
>
> Fails to build on x86_32 with lots of errors related to znet
> 
> drivers/net/znet.c:107:29: error: wireless/i82593.h: No such file or directory
> drivers/net/znet.c:133: error: field 'i593_init' has incomplete type
> drivers/net/znet.c: In function 'znet_set_multicast_list':
> drivers/net/znet.c:235: error: invalid application of 'sizeof' to incomplete type 'struct i82593_conf_block'
> drivers/net/znet.c:247: error: dereferencing pointer to incomplete type
> .....
> 
> Commit 879e9304... moved wireless/i82593.h to drivers/staging/wavelan/i82593.h
> 
> Thanks
> -Sachin
> 
> 
> -- 
> 
> ---------------------------------
> Sachin Sant
> IBM Linux Technology Center
> India Systems and Technology Labs
> Bangalore, India
> ---------------------------------
> 


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply

* Re: linux-next: manual merge of the staging tree with the net/wireless tree
From: Greg KH @ 2009-10-27 14:13 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, John W. Linville, David S. Miller,
	Johannes Berg, Holger Schurig
In-Reply-To: <20091027183503.5c398311.sfr@canb.auug.org.au>

On Tue, Oct 27, 2009 at 06:35:03PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next merge of the staging tree got conflicts in
> drivers/net/wireless/Kconfig between commits
> 3d23e349d807177eaf519d444677cee86b1a04cf ("wext: refactor") and
> 0465af8e03bdc6cd0b49dc5548671387a8674b69 ("libertas: separate libertas'
> Kconfig in it's own file") from the net/wireless tree and various commits
> ("... move driver to staging") from the staging tree.
> 
> I fixed it up (see below) and added a merge fixup (see further below) and
> can carry these as necessary (though it may be easier for everyone (i.e.
> me :-)) if these 4 staging tree commits are moved to the wireless
> tree ...).

John, I have no objection to these 4 commits going through your tree, if
it will make these types of merge issues go away.  If so, I have 4 more
patches that should be added, adding the TODO files for the drivers.  I
can send them to you if you want to take them.

thanks,

greg k-h

^ permalink raw reply

* next tree for October 27:  znet build failure
From: Sachin Sant @ 2009-10-27  9:35 UTC (permalink / raw)
  To: linux-next; +Cc: Stephen Rothwell, netdev, David Miller
In-Reply-To: <20091027190850.9694fb39.sfr@canb.auug.org.au>

Fails to build on x86_32 with lots of errors related to znet

drivers/net/znet.c:107:29: error: wireless/i82593.h: No such file or directory
drivers/net/znet.c:133: error: field 'i593_init' has incomplete type
drivers/net/znet.c: In function 'znet_set_multicast_list':
drivers/net/znet.c:235: error: invalid application of 'sizeof' to incomplete type 'struct i82593_conf_block'
drivers/net/znet.c:247: error: dereferencing pointer to incomplete type
.....

Commit 879e9304... moved wireless/i82593.h to drivers/staging/wavelan/i82593.h

Thanks
-Sachin


-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------

^ permalink raw reply

* linux-next: Tree for October 27
From: Stephen Rothwell @ 2009-10-27  8:08 UTC (permalink / raw)
  To: linux-next; +Cc: LKML

[-- Attachment #1: Type: text/plain, Size: 7645 bytes --]

Hi all,

Changes since 20091026:

My fixes tree contains a build fix for powerpc/kvm.

The pci tree lost its conflict.

The block tree gained a build failure so I used the version from
next-20091026.

The staging tree gained a conflict against the net/wireless trees.

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES - this fails its final link) and i386, sparc
and sparc64 defconfig. These builds also have
CONFIG_ENABLE_WARN_DEPRECATED, CONFIG_ENABLE_MUST_CHECK and
CONFIG_DEBUG_INFO disabled when necessary.

Below is a summary of the state of the merge.

We are up to 146 trees (counting Linus' and 22 trees of patches pending for
Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ , the guys at http://test.kernel.org/ and Randy
Dunlap for doing many randconfig builds.

There is a wiki covering stuff to do with linux-next at
http://linux.f-seidel.de/linux-next/pmwiki/ .  Thanks to Frank Seidel.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

$ git checkout master
$ git reset --hard stable
Merging origin/master
Merging fixes/fixes
Merging arm-current/master
Merging m68k-current/for-linus
Merging powerpc-merge/merge
Merging sparc-current/master
Merging scsi-rc-fixes/master
Merging net-current/master
Merging sound-current/for-linus
Merging pci-current/for-linus
Merging wireless-current/master
Merging kbuild-current/master
Merging quilt/driver-core.current
Merging quilt/tty.current
Merging quilt/usb.current
Merging quilt/staging.current
Merging cpufreq-current/fixes
Merging input-current/for-linus
Merging md-current/for-linus
Merging audit-current/for-linus
Merging crypto-current/master
Merging ide-curent/master
Merging dwmw2/master
Merging arm/devel
Merging davinci/davinci-next
Merging omap/for-next
Merging pxa/for-next
Merging avr32/avr32-arch
Merging blackfin/for-linus
Merging cris/for-next
Merging ia64/test
Merging m68k/for-next
CONFLICT (content): Merge conflict in drivers/rtc/Kconfig
Merging m68knommu/for-next
Merging microblaze/next
Merging mips/mips-for-linux-next
Merging parisc/next
Merging powerpc/next
Merging 4xx/next
Merging galak/next
Merging s390/features
Merging sh/master
Merging sparc/master
Merging xtensa/master
Merging ceph/for-next
Merging cifs/master
Merging configfs/linux-next
Merging ecryptfs/next
Merging ext3/for_next
Merging ext4/next
Merging fatfs/master
Merging fuse/for-next
Merging gfs2/master
Merging jfs/next
Merging nfs/linux-next
Merging nfsd/nfsd-next
Merging nilfs2/for-next
Merging ocfs2/linux-next
Merging squashfs/master
Merging udf/for_next
Merging v9fs/for-next
Merging ubifs/linux-next
Merging xfs/master
Merging reiserfs-bkl/reiserfs/kill-bkl
Merging vfs/for-next
Merging pci/linux-next
Merging hid/for-next
Merging quilt/i2c
Merging quilt/jdelvare-hwmon
Merging quilt/kernel-doc
Merging v4l-dvb/master
Merging quota/for_next
Merging kbuild/master
Merging kconfig/for-next
Merging ide/master
Merging libata/NEXT
Merging infiniband/for-next
Merging acpi/test
Merging ieee1394/for-next
Merging ubi/linux-next
Merging kvm/linux-next
CONFLICT (content): Merge conflict in arch/x86/kvm/mmu.c
Merging dlm/next
Merging scsi/master
Merging async_tx/next
Merging net/master
CONFLICT (delete/modify): drivers/net/sfc/sfe4001.c deleted in net/master and modified in HEAD. Version HEAD of drivers/net/sfc/sfe4001.c left in tree.
$ git rm -f drivers/net/sfc/sfe4001.c
Applying: net: merge fixup for drivers/net/sfc/falcon_boards.c
Merging wireless/master
Merging mtd/master
Merging crypto/master
Merging sound/for-next
Merging cpufreq/next
Merging quilt/rr
Merging mmc/next
Merging tmio-mmc/linux-next
Merging input/next
Merging lsm/for-next
Merging block/for-next
$ git reset --hard HEAD^
Merging refs/next/20091026/block
Merging quilt/device-mapper
Merging embedded/master
Merging firmware/master
Merging pcmcia/master
Merging battery/master
Merging leds/for-mm
Merging backlight/for-mm
Merging kgdb/kgdb-next
Merging slab/for-next
Merging uclinux/for-next
Merging md/for-next
Merging mfd/for-next
Merging hdlc/hdlc-next
Merging drm/drm-next
Merging voltage/for-next
CONFLICT (content): Merge conflict in drivers/mfd/Kconfig
CONFLICT (content): Merge conflict in drivers/mfd/Makefile
Merging security-testing/next
CONFLICT (content): Merge conflict in Documentation/dontdiff
Merging lblnet/master
Merging agp/agp-next
Merging uwb/for-upstream
Merging watchdog/master
Merging bdev/master
Merging dwmw2-iommu/master
Merging cputime/cputime
Merging osd/linux-next
Merging jc_docs/docs-next
Merging nommu/master
Merging trivial/for-next
CONFLICT (content): Merge conflict in drivers/acpi/video_detect.c
Merging audit/for-next
Merging quilt/aoe
Merging suspend/linux-next
Merging bluetooth/master
Merging fsnotify/for-next
Merging irda/for-next
Merging hwlat/for-linus
CONFLICT (content): Merge conflict in drivers/misc/Makefile
Merging drbd/for-jens
CONFLICT (add/add): Merge conflict in drivers/block/drbd/Kconfig
CONFLICT (add/add): Merge conflict in drivers/block/drbd/Makefile
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_actlog.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_int.h
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_main.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_nl.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_receiver.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_req.c
CONFLICT (add/add): Merge conflict in drivers/block/drbd/drbd_worker.c
CONFLICT (add/add): Merge conflict in include/linux/drbd.h
Merging catalin/for-next
Merging alacrity/linux-next
CONFLICT (content): Merge conflict in drivers/net/Kconfig
CONFLICT (content): Merge conflict in lib/Kconfig
Merging i7core_edac/linux_next
Merging devicetree/next-devicetree
Merging limits/writable_limits
Merging tip/auto-latest
Merging oprofile/for-next
Merging percpu/for-next
Merging sfi/sfi-test
Merging asm-generic/next
Merging hwpoison/hwpoison
Merging quilt/driver-core
Merging quilt/tty
Merging quilt/usb
Merging quilt/staging
CONFLICT (content): Merge conflict in drivers/net/wireless/Kconfig
Applying: staging: merge fixup for wireless drivers move
Merging scsi-post-merge/master

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply

* linux-next: manual merge of the staging tree with the net/wireless tree
From: Stephen Rothwell @ 2009-10-27  7:35 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-next, linux-kernel, John W. Linville, David S. Miller,
	Johannes Berg, Holger Schurig

Hi Greg,

Today's linux-next merge of the staging tree got conflicts in
drivers/net/wireless/Kconfig between commits
3d23e349d807177eaf519d444677cee86b1a04cf ("wext: refactor") and
0465af8e03bdc6cd0b49dc5548671387a8674b69 ("libertas: separate libertas'
Kconfig in it's own file") from the net/wireless tree and various commits
("... move driver to staging") from the staging tree.

I fixed it up (see below) and added a merge fixup (see further below) and
can carry these as necessary (though it may be easier for everyone (i.e.
me :-)) if these 4 staging tree commits are moved to the wireless
tree ...).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/net/wireless/Kconfig
index 85f8bf4,18cadf0..0000000
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@@ -5,132 -5,20 +5,23 @@@
  menuconfig WLAN
  	bool "Wireless LAN"
  	depends on !S390
 +	select WIRELESS
  	default y
  	---help---
- 	  This section contains all the pre 802.11 and 802.11 wireless
- 	  device drivers. For a complete list of drivers and documentation
+ 	  This section contains all the 802.11 wireless LAN device
+ 	  drivers. For a complete list of drivers and documentation
  	  on them refer to the wireless wiki:
  
  	  http://wireless.kernel.org/en/users/Drivers
  
  if WLAN
  
- menuconfig WLAN_PRE80211
- 	bool "Wireless LAN (pre-802.11)"
- 	depends on NETDEVICES
- 	---help---
- 	  Say Y if you have any pre-802.11 wireless LAN hardware.
- 
- 	  This option does not affect the kernel build, it only
- 	  lets you choose drivers.
- 
- config STRIP
- 	tristate "STRIP (Metricom starmode radio IP)"
- 	depends on INET && WLAN_PRE80211
- 	select WIRELESS_EXT
- 	---help---
- 	  Say Y if you have a Metricom radio and intend to use Starmode Radio
- 	  IP. STRIP is a radio protocol developed for the MosquitoNet project
- 	  to send Internet traffic using Metricom radios.  Metricom radios are
- 	  small, battery powered, 100kbit/sec packet radio transceivers, about
- 	  the size and weight of a cellular telephone. (You may also have heard
- 	  them called "Metricom modems" but we avoid the term "modem" because
- 	  it misleads many people into thinking that you can plug a Metricom
- 	  modem into a phone line and use it as a modem.)
- 
- 	  You can use STRIP on any Linux machine with a serial port, although
- 	  it is obviously most useful for people with laptop computers. If you
- 	  think you might get a Metricom radio in the future, there is no harm
- 	  in saying Y to STRIP now, except that it makes the kernel a bit
- 	  bigger.
- 
- 	  To compile this as a module, choose M here: the module will be
- 	  called strip.
- 
- config ARLAN
- 	tristate "Aironet Arlan 655 & IC2200 DS support"
- 	depends on ISA && !64BIT && WLAN_PRE80211
- 	select WIRELESS_EXT
- 	---help---
- 	  Aironet makes Arlan, a class of wireless LAN adapters. These use the
- 	  www.Telxon.com chip, which is also used on several similar cards.
- 	  This driver is tested on the 655 and IC2200 series cards. Look at
- 	  <http://www.ylenurme.ee/~elmer/655/> for the latest information.
- 
- 	  The driver is built as two modules, arlan and arlan-proc. The latter
- 	  is the /proc interface and is not needed most of time.
- 
- 	  On some computers the card ends up in non-valid state after some
- 	  time. Use a ping-reset script to clear it.
- 
- config WAVELAN
- 	tristate "AT&T/Lucent old WaveLAN & DEC RoamAbout DS ISA support"
- 	depends on ISA && WLAN_PRE80211
- 	select WIRELESS_EXT
- 	select WEXT_SPY
- 	select WEXT_PRIV
- 	---help---
- 	  The Lucent WaveLAN (formerly NCR and AT&T; or DEC RoamAbout DS) is
- 	  a Radio LAN (wireless Ethernet-like Local Area Network) using the
- 	  radio frequencies 900 MHz and 2.4 GHz.
- 
- 	  If you want to use an ISA WaveLAN card under Linux, say Y and read
- 	  the Ethernet-HOWTO, available from
- 	  <http://www.tldp.org/docs.html#howto>. Some more specific
- 	  information is contained in
- 	  <file:Documentation/networking/wavelan.txt> and in the source code
- 	  <file:drivers/net/wireless/wavelan.p.h>.
- 
- 	  You will also need the wireless tools package available from
- 	  <http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/Tools.html>.
- 	  Please read the man pages contained therein.
- 
- 	  To compile this driver as a module, choose M here: the module will be
- 	  called wavelan.
- 
- config PCMCIA_WAVELAN
- 	tristate "AT&T/Lucent old WaveLAN Pcmcia wireless support"
- 	depends on PCMCIA && WLAN_PRE80211
- 	select WIRELESS_EXT
- 	select WEXT_SPY
- 	select WEXT_PRIV
- 	help
- 	  Say Y here if you intend to attach an AT&T/Lucent Wavelan PCMCIA
- 	  (PC-card) wireless Ethernet networking card to your computer.  This
- 	  driver is for the non-IEEE-802.11 Wavelan cards.
- 
- 	  To compile this driver as a module, choose M here: the module will be
- 	  called wavelan_cs.  If unsure, say N.
- 
- config PCMCIA_NETWAVE
- 	tristate "Xircom Netwave AirSurfer Pcmcia wireless support"
- 	depends on PCMCIA && WLAN_PRE80211
- 	select WIRELESS_EXT
- 	select WEXT_PRIV
- 	help
- 	  Say Y here if you intend to attach this type of PCMCIA (PC-card)
- 	  wireless Ethernet networking card to your computer.
- 
- 	  To compile this driver as a module, choose M here: the module will be
- 	  called netwave_cs.  If unsure, say N.
- 
- 
- menuconfig WLAN_80211
- 	bool "Wireless LAN (IEEE 802.11)"
- 	depends on NETDEVICES
- 	---help---
- 	  Say Y if you have any 802.11 wireless LAN hardware.
- 
- 	  This option does not affect the kernel build, it only
- 	  lets you choose drivers.
- 
  config PCMCIA_RAYCS
  	tristate "Aviator/Raytheon 2.4GHz wireless support"
- 	depends on PCMCIA && WLAN_80211
+ 	depends on PCMCIA
  	select WIRELESS_EXT
 +	select WEXT_SPY
 +	select WEXT_PRIV
  	---help---
  	  Say Y here if you intend to attach an Aviator/Raytheon PCMCIA
  	  (PC-card) wireless Ethernet networking card to your computer.
@@@ -140,9 -28,48 +31,9 @@@
  	  To compile this driver as a module, choose M here: the module will be
  	  called ray_cs.  If unsure, say N.
  
 -config LIBERTAS
 -	tristate "Marvell 8xxx Libertas WLAN driver support"
 -	select WIRELESS_EXT
 -	select LIB80211
 -	select FW_LOADER
 -	---help---
 -	  A library for Marvell Libertas 8xxx devices.
 -
 -config LIBERTAS_USB
 -	tristate "Marvell Libertas 8388 USB 802.11b/g cards"
 -	depends on LIBERTAS && USB
 -	---help---
 -	  A driver for Marvell Libertas 8388 USB devices.
 -
 -config LIBERTAS_CS
 -	tristate "Marvell Libertas 8385 CompactFlash 802.11b/g cards"
 -	depends on LIBERTAS && PCMCIA
 -	select FW_LOADER
 -	---help---
 -	  A driver for Marvell Libertas 8385 CompactFlash devices.
 -
 -config LIBERTAS_SDIO
 -	tristate "Marvell Libertas 8385/8686/8688 SDIO 802.11b/g cards"
 -	depends on LIBERTAS && MMC
 -	---help---
 -	  A driver for Marvell Libertas 8385/8686/8688 SDIO devices.
 -
 -config LIBERTAS_SPI
 -	tristate "Marvell Libertas 8686 SPI 802.11b/g cards"
 -	depends on LIBERTAS && SPI
 -	---help---
 -	  A driver for Marvell Libertas 8686 SPI devices.
 -
 -config LIBERTAS_DEBUG
 -	bool "Enable full debugging output in the Libertas module."
 -	depends on LIBERTAS
 -	---help---
 -	  Debugging support.
 -
  config LIBERTAS_THINFIRM
  	tristate "Marvell 8xxx Libertas WLAN driver support with thin firmware"
- 	depends on WLAN_80211 && MAC80211
+ 	depends on MAC80211
  	select FW_LOADER
  	---help---
  	  A library for Marvell Libertas 8xxx devices using thinfirm.
@@@ -155,11 -82,9 +46,11 @@@ config LIBERTAS_THINFIRM_US
  
  config AIRO
  	tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
- 	depends on ISA_DMA_API && WLAN_80211 && (PCI || BROKEN)
+ 	depends on ISA_DMA_API && (PCI || BROKEN)
  	select WIRELESS_EXT
  	select CRYPTO
 +	select WEXT_SPY
 +	select WEXT_PRIV
  	---help---
  	  This is the standard Linux driver to support Cisco/Aironet ISA and
  	  PCI 802.11 wireless cards.
@@@ -175,9 -100,8 +66,9 @@@
  
  config ATMEL
        tristate "Atmel at76c50x chipset  802.11b support"
-       depends on (PCI || PCMCIA) && WLAN_80211
+       depends on (PCI || PCMCIA)
        select WIRELESS_EXT
 +      select WEXT_PRIV
        select FW_LOADER
        select CRC32
         ---help---
@@@ -237,21 -161,18 +128,21 @@@ config AIRO_C
  	  Cisco Linux utilities can be used to configure the card.
  
  config PCMCIA_WL3501
 -      tristate "Planet WL3501 PCMCIA cards"
 -      depends on EXPERIMENTAL && PCMCIA
 -      select WIRELESS_EXT
 -       ---help---
 -         A driver for WL3501 PCMCIA 802.11 wireless cards made by Planet.
 -	 It has basic support for Linux wireless extensions and initial
 -	 micro support for ethtool.
 +	tristate "Planet WL3501 PCMCIA cards"
- 	depends on EXPERIMENTAL && PCMCIA && WLAN_80211
++	depends on EXPERIMENTAL && PCMCIA
 +	select WIRELESS_EXT
 +	select WEXT_SPY
 +	help
 +	  A driver for WL3501 PCMCIA 802.11 wireless cards made by Planet.
 +	  It has basic support for Linux wireless extensions and initial
 +	  micro support for ethtool.
  
  config PRISM54
  	tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus (DEPRECATED)'
- 	depends on PCI && EXPERIMENTAL && WLAN_80211
+ 	depends on PCI && EXPERIMENTAL
  	select WIRELESS_EXT
 +	select WEXT_SPY
 +	select WEXT_PRIV
  	select FW_LOADER
  	---help---
  	  This enables support for FullMAC PCI/Cardbus prism54 devices. This
@@@ -272,9 -193,8 +163,9 @@@
  
  config USB_ZD1201
  	tristate "USB ZD1201 based Wireless device support"
- 	depends on USB && WLAN_80211
+ 	depends on USB
  	select WIRELESS_EXT
 +	select WEXT_PRIV
  	select FW_LOADER
  	---help---
  	  Say Y if you want to use wireless LAN adapters based on the ZyDAS


-------------------------------------------------------
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 27 Oct 2009 18:29:04 +1100
Subject: [PATCH] staging: merge fixup for wireless drivers move

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/wireless/libertas/Kconfig |    2 +-
 drivers/staging/netwave/Kconfig       |    1 +
 drivers/staging/wavelan/Kconfig       |    4 ++++
 3 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/libertas/Kconfig b/drivers/net/wireless/libertas/Kconfig
index 8f8d75b..30aa9d4 100644
--- a/drivers/net/wireless/libertas/Kconfig
+++ b/drivers/net/wireless/libertas/Kconfig
@@ -1,6 +1,6 @@
 config LIBERTAS
 	tristate "Marvell 8xxx Libertas WLAN driver support"
-	depends on WLAN_80211 && CFG80211
+	depends on CFG80211
 	select WIRELESS_EXT
 	select WEXT_SPY
 	select LIB80211
diff --git a/drivers/staging/netwave/Kconfig b/drivers/staging/netwave/Kconfig
index b6f0f0a..c0c996c 100644
--- a/drivers/staging/netwave/Kconfig
+++ b/drivers/staging/netwave/Kconfig
@@ -2,6 +2,7 @@ config PCMCIA_NETWAVE
 	tristate "Xircom Netwave AirSurfer Pcmcia wireless support"
 	depends on PCMCIA
 	select WIRELESS_EXT
+	select WEXT_PRIV
 	help
 	  Say Y here if you intend to attach this type of PCMCIA (PC-card)
 	  wireless Ethernet networking card to your computer.
diff --git a/drivers/staging/wavelan/Kconfig b/drivers/staging/wavelan/Kconfig
index ff349cd..786060e 100644
--- a/drivers/staging/wavelan/Kconfig
+++ b/drivers/staging/wavelan/Kconfig
@@ -2,6 +2,8 @@ config WAVELAN
 	tristate "AT&T/Lucent old WaveLAN & DEC RoamAbout DS ISA support"
 	depends on ISA
 	select WIRELESS_EXT
+	select WEXT_SPY
+	select WEXT_PRIV
 	---help---
 	  The Lucent WaveLAN (formerly NCR and AT&T; or DEC RoamAbout DS) is
 	  a Radio LAN (wireless Ethernet-like Local Area Network) using the
@@ -25,6 +27,8 @@ config PCMCIA_WAVELAN
 	tristate "AT&T/Lucent old WaveLAN Pcmcia wireless support"
 	depends on PCMCIA
 	select WIRELESS_EXT
+	select WEXT_SPY
+	select WEXT_PRIV
 	help
 	  Say Y here if you intend to attach an AT&T/Lucent Wavelan PCMCIA
 	  (PC-card) wireless Ethernet networking card to your computer.  This
-- 
1.6.5

^ permalink raw reply related


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox