[PATCH v2] nfsd: allow more than 64 backlogged connections

[PATCH v2] nfsd: allow more than 64 backlogged connections

[trondmy]

From: Trond Myklebust <trond.myklebust@hammerspace.com>

When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
we currently limit the number of backlogged connections to 64. Since
that value was chosen in 2006, the scale at which data centres operate
has changed significantly. Given a modern server with many thousands of
clients, a limit of 64 connections can create bottlenecks, particularly
at at boot time.
Let's use the POSIX-sanctioned maximum value of SOMAXCONN.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
v2: Use SOMAXCONN instead of a value of -1.

 utils/nfsd/nfssvc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
index 46452d972407..9650cecee986 100644
--- a/utils/nfsd/nfssvc.c
+++ b/utils/nfsd/nfssvc.c
@@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
 			rc = errno;
 			goto error;
 		}
-		if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
+		if (addr->ai_protocol == IPPROTO_TCP &&
+		    listen(sockfd, SOMAXCONN)) {
 			xlog(L_ERROR, "unable to create listening socket: "
 				"errno %d (%m)", errno);
 			rc = errno;
-- 
2.44.0

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Jeff Layton]

On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres operate
> has changed significantly. Given a modern server with many thousands of
> clients, a limit of 64 connections can create bottlenecks, particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> v2: Use SOMAXCONN instead of a value of -1.
> 
>  utils/nfsd/nfssvc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
>  			rc = errno;
>  			goto error;
>  		}
> -		if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
> +		if (addr->ai_protocol == IPPROTO_TCP &&
> +		    listen(sockfd, SOMAXCONN)) {
>  			xlog(L_ERROR, "unable to create listening socket: "
>  				"errno %d (%m)", errno);
>  			rc = errno;

Reviewed-by: Jeff Layton <jlayton@kernel.org>

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Chuck Lever]

On Fri, Mar 08, 2024 at 01:02:23PM -0500, trondmy@gmail.com wrote:
> When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres operate
> has changed significantly. Given a modern server with many thousands of
> clients, a limit of 64 connections can create bottlenecks, particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> v2: Use SOMAXCONN instead of a value of -1.
> 
>  utils/nfsd/nfssvc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
>  			rc = errno;
>  			goto error;
>  		}
> -		if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
> +		if (addr->ai_protocol == IPPROTO_TCP &&
> +		    listen(sockfd, SOMAXCONN)) {
>  			xlog(L_ERROR, "unable to create listening socket: "
>  				"errno %d (%m)", errno);
>  			rc = errno;
> -- 
> 2.44.0

Acked-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Cedric Blancher]

Could you please ACK this for 6.6-LTS too ?

Ced

On Fri, 8 Mar 2024 at 19:58, Chuck Lever <chuck.lever@oracle.com> wrote:
>
> On Fri, Mar 08, 2024 at 01:02:23PM -0500, trondmy@gmail.com wrote:
> > When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
> > we currently limit the number of backlogged connections to 64. Since
> > that value was chosen in 2006, the scale at which data centres operate
> > has changed significantly. Given a modern server with many thousands of
> > clients, a limit of 64 connections can create bottlenecks, particularly
> > at at boot time.
> > Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> >
> > Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> > ---
> > v2: Use SOMAXCONN instead of a value of -1.
> >
> >  utils/nfsd/nfssvc.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> > index 46452d972407..9650cecee986 100644
> > --- a/utils/nfsd/nfssvc.c
> > +++ b/utils/nfsd/nfssvc.c
> > @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
> >                       rc = errno;
> >                       goto error;
> >               }
> > -             if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
> > +             if (addr->ai_protocol == IPPROTO_TCP &&
> > +                 listen(sockfd, SOMAXCONN)) {
> >                       xlog(L_ERROR, "unable to create listening socket: "
> >                               "errno %d (%m)", errno);
> >                       rc = errno;
> > --
> > 2.44.0
>
> Acked-by: Chuck Lever <chuck.lever@oracle.com>
>
> --
> Chuck Lever
>


-- 
Cedric Blancher <cedric.blancher@gmail.com>
[https://plus.google.com/u/0/+CedricBlancher/]
Institute Pasteur

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Trond Myklebust]

On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> When creating a listener socket to be handed to
> /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres
> operate
> has changed significantly. Given a modern server with many thousands
> of
> clients, a limit of 64 connections can create bottlenecks,
> particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> v2: Use SOMAXCONN instead of a value of -1.
> 
>  utils/nfsd/nfssvc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const
> char *node, const char *port)
>  			rc = errno;
>  			goto error;
>  		}
> -		if (addr->ai_protocol == IPPROTO_TCP &&
> listen(sockfd, 64)) {
> +		if (addr->ai_protocol == IPPROTO_TCP &&
> +		    listen(sockfd, SOMAXCONN)) {
>  			xlog(L_ERROR, "unable to create listening
> socket: "
>  				"errno %d (%m)", errno);
>  			rc = errno;

Ping on the above.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Hanxiao Chen (Fujitsu)]

> -----邮件原件-----
> 发件人: Trond Myklebust <trondmy@hammerspace.com>
> 发送时间: 2024年4月12日 3:12
> 收件人: SteveD@redhat.com
> 抄送: linux-nfs@vger.kernel.org
> 主题: Re: [PATCH v2] nfsd: allow more than 64 backlogged connections
> 
> On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
> > From: Trond Myklebust <trond.myklebust@hammerspace.com>
> >
> > When creating a listener socket to be handed to
> > /proc/fs/nfsd/portlist,
> > we currently limit the number of backlogged connections to 64. Since
> > that value was chosen in 2006, the scale at which data centres
> > operate
> > has changed significantly. Given a modern server with many thousands
> > of
> > clients, a limit of 64 connections can create bottlenecks,
> > particularly
> > at at boot time.
> > Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> >

Tested-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>

Regards,
- Chen

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Jeff Layton]

On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> When creating a listener socket to be handed to
> /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres
> operate
> has changed significantly. Given a modern server with many thousands
> of
> clients, a limit of 64 connections can create bottlenecks,
> particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> v2: Use SOMAXCONN instead of a value of -1.
> 
>  utils/nfsd/nfssvc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const
> char *node, const char *port)
>  			rc = errno;
>  			goto error;
>  		}
> -		if (addr->ai_protocol == IPPROTO_TCP &&
> listen(sockfd, 64)) {
> +		if (addr->ai_protocol == IPPROTO_TCP &&
> +		    listen(sockfd, SOMAXCONN)) {
>  			xlog(L_ERROR, "unable to create listening
> socket: "
>  				"errno %d (%m)", errno);
>  			rc = errno;

Steve,

Is there some reason you've not committed this patch? It seems fairly
straightforward. I think I sent this earlier, but:

Reviewed-by: Jeffrey Layton <jlayton@kernel.org>

-- 
Jeff Layton <jlayton@poochiereds.net>

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Steve Dickson]

On 5/9/24 9:31 AM, Jeff Layton wrote:
> On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
>> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>>
>> When creating a listener socket to be handed to
>> /proc/fs/nfsd/portlist,
>> we currently limit the number of backlogged connections to 64. Since
>> that value was chosen in 2006, the scale at which data centres
>> operate
>> has changed significantly. Given a modern server with many thousands
>> of
>> clients, a limit of 64 connections can create bottlenecks,
>> particularly
>> at at boot time.
>> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
>>
>> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
>> ---
>> v2: Use SOMAXCONN instead of a value of -1.
>>
>>   utils/nfsd/nfssvc.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
>> index 46452d972407..9650cecee986 100644
>> --- a/utils/nfsd/nfssvc.c
>> +++ b/utils/nfsd/nfssvc.c
>> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const
>> char *node, const char *port)
>>   			rc = errno;
>>   			goto error;
>>   		}
>> -		if (addr->ai_protocol == IPPROTO_TCP &&
>> listen(sockfd, 64)) {
>> +		if (addr->ai_protocol == IPPROTO_TCP &&
>> +		    listen(sockfd, SOMAXCONN)) {
>>   			xlog(L_ERROR, "unable to create listening
>> socket: "
>>   				"errno %d (%m)", errno);
>>   			rc = errno;
> 
> Steve,
> 
> Is there some reason you've not committed this patch? It seems fairly
> straightforward. I think I sent this earlier, but:
> 
> Reviewed-by: Jeffrey Layton <jlayton@kernel.org>
> 
Thanks for the poke... The patch was not on my todo list.

I'm on it...

steved.

Re: [PATCH v2] nfsd: allow more than 64 backlogged connections

[Steve Dickson]

On 3/8/24 1:02 PM, trondmy@gmail.com wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres operate
> has changed significantly. Given a modern server with many thousands of
> clients, a limit of 64 connections can create bottlenecks, particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Committed... Sorry it took so long... The patch was not
on my radar... Feel free to ping when things linger this long.

steved.

> ---
> v2: Use SOMAXCONN instead of a value of -1.
> 
>   utils/nfsd/nfssvc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
>   			rc = errno;
>   			goto error;
>   		}
> -		if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
> +		if (addr->ai_protocol == IPPROTO_TCP &&
> +		    listen(sockfd, SOMAXCONN)) {
>   			xlog(L_ERROR, "unable to create listening socket: "
>   				"errno %d (%m)", errno);
>   			rc = errno;