Re: [RFC, PATCH 3/15] knfsd: initialize RDMA transport in sunrpc

[Tom Tucker <tom@opengridcomputing.com>]

On Fri, 2007-05-18 at 14:23 -0400, Trond Myklebust wrote:
> On Fri, 2007-05-18 at 12:44 -0500, Tom Tucker wrote:
> > Add calls to the svc_rdma initialization and cleanup routines to the
> > sunrpc module init logic.
> > 
> > Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
> > ---
> > 
> >  net/sunrpc/sunrpc_syms.c |   10 +++++++++-
> >  1 files changed, 9 insertions(+), 1 deletions(-)
> > 
> > diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
> > index 43ecf62..16a50c9 100644
> > --- a/net/sunrpc/sunrpc_syms.c
> > +++ b/net/sunrpc/sunrpc_syms.c
> > @@ -20,7 +20,9 @@ #include <linux/sunrpc/svcsock.h>
> >  #include <linux/sunrpc/auth.h>
> >  #include <linux/workqueue.h>
> >  #include <linux/sunrpc/rpc_pipe_fs.h>
> > -
> > +#ifdef CONFIG_NFSD_RDMA
> > +#include <linux/sunrpc/svc_rdma.h>
> > +#endif
> >  
> >  /* RPC scheduler */
> >  EXPORT_SYMBOL(rpc_execute);
> > @@ -158,6 +160,9 @@ #endif
> >  	cache_register(&ip_map_cache);
> >  	cache_register(&unix_gid_cache);
> >  	init_socket_xprt();
> > +#ifdef CONFIG_NFSD_RDMA
> > +	err = svc_rdma_init();
> > +#endif
> >  out:
> >  	return err;
> >  }
> > @@ -175,6 +180,9 @@ cleanup_sunrpc(void)
> >  #ifdef RPC_DEBUG
> >  	rpc_unregister_sysctl();
> >  #endif
> > +#ifdef CONFIG_NFSD_RDMA
> > +	svc_rdma_cleanup();
> > +#endif
> >  #ifdef CONFIG_PROC_FS
> >  	rpc_proc_exit();
> >  #endif
> 
> Hmm... You really want to reorder this patch. AFAICS you haven't defined
> either svc_rdma.h or svc_rdma_*().
> 
> Please also convert the above to avoid inlined #ifdef/#endif by defining
> inlined dummy versions of svc_rdma_cleanup/svc_rdma_init inside
> svc_rdma.h:
> 
> #ifdef CONFIG_NFSD_RDMA
> void svc_rdma_cleanup(void);
> #else
> static inline void svc_rdma_cleanup(void)
> {
> }
> #endif

Ok, I'll add this to the svc_rdma.h file. Thanks,

> 
> 
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs