Re: [RFC, PATCH 3/15] knfsd: initialize RDMA transport in sunrpc

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]

As part of the client side transport switch, I constructed a transport 
"register" and "unregister" interface so that when a transport module is 
loaded, it's init routine is invoked automatically, and likewise when it 
is unloaded its cleanup routine is automatically invoked.

I'd like to see the same here.  I don't think we want to create a 
situation where you have to make source code changes in order to add new 
transport capabilities.  Especially the distributors would be allergic 
to such a constraint.

Please consider this change while going about the process of integrating 
the server-side transport switch with your RDMA transport.

Tom Tucker wrote:
> Add calls to the svc_rdma initialization and cleanup routines to the
> sunrpc module init logic.
> 
> Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
> ---
> 
>  net/sunrpc/sunrpc_syms.c |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
> index 43ecf62..16a50c9 100644
> --- a/net/sunrpc/sunrpc_syms.c
> +++ b/net/sunrpc/sunrpc_syms.c
> @@ -20,7 +20,9 @@ #include <linux/sunrpc/svcsock.h>
>  #include <linux/sunrpc/auth.h>
>  #include <linux/workqueue.h>
>  #include <linux/sunrpc/rpc_pipe_fs.h>
> -
> +#ifdef CONFIG_NFSD_RDMA
> +#include <linux/sunrpc/svc_rdma.h>
> +#endif
>  
>  /* RPC scheduler */
>  EXPORT_SYMBOL(rpc_execute);
> @@ -158,6 +160,9 @@ #endif
>  	cache_register(&ip_map_cache);
>  	cache_register(&unix_gid_cache);
>  	init_socket_xprt();
> +#ifdef CONFIG_NFSD_RDMA
> +	err = svc_rdma_init();
> +#endif
>  out:
>  	return err;
>  }
> @@ -175,6 +180,9 @@ cleanup_sunrpc(void)
>  #ifdef RPC_DEBUG
>  	rpc_unregister_sysctl();
>  #endif
> +#ifdef CONFIG_NFSD_RDMA
> +	svc_rdma_cleanup();
> +#endif
>  #ifdef CONFIG_PROC_FS
>  	rpc_proc_exit();
>  #endif
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> NFS maillist  -  NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs


[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 291 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel/
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs