From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Peter Staubach <staubach@redhat.com>
Cc: chucklever@gmail.com, NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH V2] make "noac" and "actimeo=0" work correctly
Date: Fri, 11 Jul 2008 16:19:00 -0400 [thread overview]
Message-ID: <1215807540.17983.2.camel@localhost> (raw)
In-Reply-To: <4877BF39.20102@redhat.com>
On Fri, 2008-07-11 at 16:14 -0400, Peter Staubach wrote:
> Given that we seem to "own" time_in_range(), how about the
> attached patch which just modifies time_in_range() to calculate
> [b,c) instead of [b,c], removes the special case for attrtimeo==0
> in nfs_attribute_timeout() and adds a comment that Chuck requested
> concerning the need to ensure that zero timeout values continue
> to work?
I'm fine with that, but still suggest that you change the name in order
to avoid confusing possible out-of-tree users.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
next prev parent reply other threads:[~2008-07-11 20:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 20:52 [PATCH] make "noac" and "actimeo=0" work correctly Peter Staubach
2008-07-08 16:08 ` [PATCH V2] " Peter Staubach
2008-07-10 15:58 ` Chuck Lever
[not found] ` <76bd70e30807100858g58fbf454uc9331035a2bbf264-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-10 17:41 ` Peter Staubach
2008-07-10 18:55 ` Chuck Lever
[not found] ` <76bd70e30807101155l226c1cceh24ca17157cb454bf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-10 19:23 ` Peter Staubach
2008-07-10 19:31 ` Chuck Lever
2008-07-10 19:29 ` Trond Myklebust
2008-07-11 20:14 ` Peter Staubach
2008-07-11 20:19 ` Trond Myklebust [this message]
2008-07-11 20:24 ` Peter Staubach
2008-12-05 21:37 ` [PATCH V3] optimize attribute timeouts for "noac" and "actimeo=0" Peter Staubach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215807540.17983.2.camel@localhost \
--to=trond.myklebust@netapp.com \
--cc=chucklever@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=staubach@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox