From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Benny Halevy <bhalevy@panasas.com>,
Olga Kornievskaia <aglo@citi.umich.edu>,
linux-nfs@vger.kernel.org, pnfs mailing list <pnfs@linux-nfs.org>,
Trond Myklebust <trond@netapp.com>
Subject: Re: [pnfs] [PATCH] nfsd: use nfs client rpc callback program
Date: Thu, 25 Sep 2008 16:27:01 -0400 [thread overview]
Message-ID: <1222374421.13388.26.camel@localhost> (raw)
In-Reply-To: <20080925200014.GA14078@fieldses.org>
On Thu, 2008-09-25 at 16:00 -0400, J. Bruce Fields wrote:
> > >> Another fix would be to add a refcount to the rpc_program structure...
> > >
> > > ... a refcount seems more straightforward. Benny, what do you think?
> >
> > I agree. I'll send a patch hopefully tomorrow.
> > Would you like that combined with the one I sent or as a separate one?
> > (I'm inclined towards the latter).
>
> That'd be fine.
So, looking at what you're trying to do, I'm still having trouble
figuring out why you think you need a dynamically allocated rpc_program
in the first place.
If the only thing you are trying to support is dynamically allocated
program numbers, then note that rpc_encode_header() doesn't use
program->number at all. Instead, it uses clnt->cl_prog and
clnt->cl_vers. Nothing stops you from setting those values explicitly...
Trond
next prev parent reply other threads:[~2008-09-25 20:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 19:43 [PATCH] nfsd: use nfs client rpc callback program Benny Halevy
2008-09-17 23:10 ` J. Bruce Fields
2008-09-17 23:34 ` Benny Halevy
2008-09-18 0:10 ` [pnfs] " Benny Halevy
2008-09-18 19:24 ` Benny Halevy
2008-09-18 19:43 ` Peter Staubach
2008-09-18 20:05 ` Benny Halevy
2008-09-18 21:36 ` Benny Halevy
2008-09-24 16:35 ` J. Bruce Fields
2008-09-24 16:59 ` Trond Myklebust
2008-09-24 17:21 ` J. Bruce Fields
2008-09-24 17:26 ` Trond Myklebust
2008-09-24 17:42 ` J. Bruce Fields
2008-09-24 18:42 ` Trond Myklebust
2008-09-24 18:49 ` J. Bruce Fields
2008-09-25 19:30 ` Benny Halevy
2008-09-25 20:00 ` J. Bruce Fields
2008-09-25 20:27 ` Trond Myklebust [this message]
2008-09-25 20:41 ` J. Bruce Fields
2008-09-26 11:52 ` Benny Halevy
2008-09-27 3:34 ` J. Bruce Fields
2008-09-28 6:21 ` [PATCH v4] " Benny Halevy
2008-09-29 19:21 ` J. Bruce Fields
2008-09-25 20:08 ` [pnfs] [PATCH] " Trond Myklebust
2008-09-25 20:38 ` J. Bruce Fields
2008-09-19 19:51 ` Olga Kornievskaia
2008-09-19 21:15 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222374421.13388.26.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=aglo@citi.umich.edu \
--cc=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
--cc=trond@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox