Linux NFS development
 help / color / mirror / Atom feed
From: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
To: trond.myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Subject: [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode()
Date: Thu,  5 Mar 2009 18:05:57 -0800	[thread overview]
Message-ID: <1236305157-10461-1-git-send-email-Ricardo.Labiaga@netapp.com> (raw)
In-Reply-To: <>

The extra NFS_STALE() invocation is likely the result of a mismerge.

Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
---
 fs/nfs/inode.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 0c38168..af77c2d 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -667,8 +667,6 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
 
 	if (is_bad_inode(inode))
 		goto out;
-	if (NFS_STALE(inode))
-		goto out;
 
 	if (NFS_STALE(inode))
 		goto out;
-- 
1.5.4.3


             reply	other threads:[~2009-03-06  2:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06  2:05 Ricardo Labiaga [this message]
2009-03-06  4:10 ` [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode() Suresh Jayaraman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236305157-10461-1-git-send-email-Ricardo.Labiaga@netapp.com \
    --to=ricardo.labiaga@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox