From: Suresh Jayaraman <sjayaraman@suse.de>
To: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Cc: trond.myklebust@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode()
Date: Fri, 06 Mar 2009 09:40:53 +0530 [thread overview]
Message-ID: <49B0A24D.4060302@suse.de> (raw)
In-Reply-To: <1236305157-10461-1-git-send-email-Ricardo.Labiaga@netapp.com>
Ricardo Labiaga wrote:
> The extra NFS_STALE() invocation is likely the result of a mismerge.
Ah, I just posted this cleanup patch a little while ago..
http://marc.info/?l=linux-nfs&m=123486480925457&w=2
> Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
> ---
> fs/nfs/inode.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index 0c38168..af77c2d 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -667,8 +667,6 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
>
> if (is_bad_inode(inode))
> goto out;
> - if (NFS_STALE(inode))
> - goto out;
>
> if (NFS_STALE(inode))
> goto out;
--
Suresh Jayaraman
prev parent reply other threads:[~2009-03-06 4:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 2:05 [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode() Ricardo Labiaga
2009-03-06 4:10 ` Suresh Jayaraman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B0A24D.4060302@suse.de \
--to=sjayaraman@suse.de \
--cc=Ricardo.Labiaga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox