* [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode()
@ 2009-03-06 2:05 Ricardo Labiaga
2009-03-06 4:10 ` Suresh Jayaraman
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Labiaga @ 2009-03-06 2:05 UTC (permalink / raw)
To: trond.myklebust; +Cc: linux-nfs, Ricardo Labiaga
The extra NFS_STALE() invocation is likely the result of a mismerge.
Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
---
fs/nfs/inode.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 0c38168..af77c2d 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -667,8 +667,6 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
if (is_bad_inode(inode))
goto out;
- if (NFS_STALE(inode))
- goto out;
if (NFS_STALE(inode))
goto out;
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode()
2009-03-06 2:05 [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode() Ricardo Labiaga
@ 2009-03-06 4:10 ` Suresh Jayaraman
0 siblings, 0 replies; 2+ messages in thread
From: Suresh Jayaraman @ 2009-03-06 4:10 UTC (permalink / raw)
To: Ricardo Labiaga; +Cc: trond.myklebust, linux-nfs
Ricardo Labiaga wrote:
> The extra NFS_STALE() invocation is likely the result of a mismerge.
Ah, I just posted this cleanup patch a little while ago..
http://marc.info/?l=linux-nfs&m=123486480925457&w=2
> Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
> ---
> fs/nfs/inode.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index 0c38168..af77c2d 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -667,8 +667,6 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
>
> if (is_bad_inode(inode))
> goto out;
> - if (NFS_STALE(inode))
> - goto out;
>
> if (NFS_STALE(inode))
> goto out;
--
Suresh Jayaraman
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-06 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-06 2:05 [PATCH] Remove redundant NFS_STALE() call in __nfs_revalidate_inode() Ricardo Labiaga
2009-03-06 4:10 ` Suresh Jayaraman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox