From: Frank Filz <ffilzlnx@us.ibm.com>
To: NFS List <linux-nfs@vger.kernel.org>,
NFS V4 Mailing List <nfsv4@linux-nfs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Eugene Teo <eugene@redhat.com>,
security@kernel.org, Trond Myklebust <trond.myklebust@fys.uio.no>,
Bruce Fields <bfields@fieldses.org>
Subject: [PATCH] nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.
Date: Mon, 18 May 2009 12:29:43 -0700 [thread overview]
Message-ID: <1242674983.4273.8.camel@dyn9047022153> (raw)
Sorry for the resend, got lkml address wrong...
The problem is that permission checking is skipped if atomic open is
possible, but when exec opens a file, it just opens it O_READONLY which
means EXEC permission will not be checked at that time.
This problem is observed by the following sequence (executed as root):
mount -t nfs4 server:/ /mnt4
echo "ls" >/mnt4/foo
chmod 744 /mnt4/foo
su guest -c "mnt4/foo"
Signed-off-by: Frank Filz <ffilzlnx@us.ibm.com>
---
fs/nfs/dir.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 370b190..89f98e9 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1943,7 +1943,8 @@ int nfs_permission(struct inode *inode, int mask)
case S_IFREG:
/* NFSv4 has atomic_open... */
if (nfs_server_capable(inode, NFS_CAP_ATOMIC_OPEN)
- && (mask & MAY_OPEN))
+ && (mask & MAY_OPEN)
+ && !(mask & MAY_EXEC))
goto out;
break;
case S_IFDIR:
next reply other threads:[~2009-05-18 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 19:29 Frank Filz [this message]
2009-05-19 0:13 ` [PATCH] nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission Eugene Teo
-- strict thread matches above, loose matches on Subject: below --
2009-05-18 19:25 Frank Filz
2009-05-09 2:55 [NFS] " Frank Filz
2009-05-13 8:50 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242674983.4273.8.camel@dyn9047022153 \
--to=ffilzlnx@us.ibm.com \
--cc=bfields@fieldses.org \
--cc=eugene@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=security@kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox