From: Eugene Teo <eugene@redhat.com>
To: Frank Filz <ffilzlnx.at.us.ibm.com@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.
Date: Wed, 13 May 2009 16:50:05 +0800 [thread overview]
Message-ID: <4A0A89BD.3030607@redhat.com> (raw)
In-Reply-To: <1241837734.2404.4.camel@dyn9047022153>
Frank Filz wrote:
> The problem is that permission checking is skipped if atomic open is
> possible, but when exec opens a file, it just opens it O_READONLY which
> means EXEC permission will not be checked at that time.
>
> This problem is observed by the following sequence (executed as root):
>
> mount -t nfs4 server:/ /mnt4
> echo "ls" >/mnt4/foo
> chmod 744 /mnt4/foo
> su guest -c "mnt4/foo"
>
> Signed-off-by: Frank Filz <ffilzlnx at us.ibm.com>
Tested-by: Eugene Teo <eugeneteo@kernel.sg>
I have tested this on 2.6.29.3, and I can confirm that the patch fixed
the problem.
Btw, this looks like the same problem that was reported in 2006:
http://linux-nfs.org/pipermail/nfsv4/2006-November/005323.html
http://linux-nfs.org/pipermail/nfsv4/2006-November/005313.html
http://bugzilla.linux-nfs.org/show_bug.cgi?id=131
Thanks, Eugene
_______________________________________________
NFSv4 mailing list
NFSv4@linux-nfs.org
http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4
next prev parent reply other threads:[~2009-05-13 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 2:55 [NFS] [PATCH] nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission Frank Filz
2009-05-13 8:50 ` Eugene Teo [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-18 19:25 Frank Filz
2009-05-18 19:29 Frank Filz
2009-05-19 0:13 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0A89BD.3030607@redhat.com \
--to=eugene@redhat.com \
--cc=ffilzlnx.at.us.ibm.com@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox