public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: andros@netapp.com
To: bfields@citi.umich.edu
Cc: pnfs@linux-nfs.org, linux-nfs@vger.kernel.org,
	Andy Adamson <andros@netapp.com>
Subject: [PATCH 4/5] nfsd41: set the session maximum response size cached
Date: Wed, 24 Jun 2009 15:37:48 -0400	[thread overview]
Message-ID: <1245872278-18743-5-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1245872278-18743-4-git-send-email-andros@netapp.com>

From: Andy Adamson <andros@netapp.com>

NFSD_SLOT_CACHE_SIZE holds the encoded operations past the SEQUENCE operation.
ca_maxresponsesize_cached (draft-ietf-nfsv4-minorversion1-29) is the xdr
encoded size of the request including the RPC header. Since the RPC header
size varies with security flavor credential and verifier. we cannot set an
accurate ca_maxresponsesize_cached. Use NFSD_SLOT_CACHE_SIZE as an
approximate ca_maxresponsesize_cached - we will have at least that much space.

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 fs/nfsd/nfs4state.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 991c3cc..a0bd6da 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -464,9 +464,14 @@ static int init_forechannel_attrs(struct svc_rqst *rqstp,
 		fchan->maxresp_sz = maxcount;
 	session_fchan->maxresp_sz = fchan->maxresp_sz;
 
-	/* Set the max response cached size our default which is
-	 * a multiple of PAGE_SIZE and small */
-	session_fchan->maxresp_cached = NFSD_PAGES_PER_SLOT * PAGE_SIZE;
+	/*
+	 * The ca_maxresponssize_cached definition includes the xdr
+	 * encoded size of the rpc header with the variable length security
+	 * flavor credential plus verifier as well as the encoded SEQUENCE
+	 * operation response size which are not included in
+	 * NFSD_SLOT_CACHE_SIZE. We err on the side of being a bit small.
+	 */
+	session_fchan->maxresp_cached = NFSD_SLOT_CACHE_SIZE;
 	fchan->maxresp_cached = session_fchan->maxresp_cached;
 
 	/* Use the client's maxops if possible */
-- 
1.5.4.3


  reply	other threads:[~2009-06-24 19:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 19:37 [PATCH 0/14] NFSv4.1 Server DRC rewrite Version 4 andros
2009-06-24 19:37 ` [PATCH 1/5] nfsd41: use globals for DRC limits andros
2009-06-24 19:37   ` [PATCH 2/5] nfsd41: change from page to memory based drc limits andros
2009-06-24 19:37     ` [PATCH 3/5] nfsd41: reclaim DRC memory on session free andros
2009-06-24 19:37       ` andros [this message]
2009-06-24 19:37         ` [PATCH 5/5] nfsd41: remove redundant forechannel max requests check andros
2009-06-24 19:37           ` [PATCH 06/14] nfsd41: change check_slot_seqid parameters andros
2009-06-24 19:37             ` [PATCH 07/14] nfsd41: replace create_session DRC with xdr structure andros
2009-06-24 19:37               ` [PATCH 08/14] nfsd41: replace page based DRC with buffer based DRC andros
2009-06-24 19:37                 ` [PATCH 09/14] nfsd41: rename nfsd4_enc_uncached_replay andros
2009-06-24 19:37                   ` [PATCH 10/14] nfsd41: encode replay sequence from the slot values andros
2009-06-24 19:37                     ` [PATCH 11/14] nfsd41: fix nfsd4_replay_cache_entry comments andros
2009-06-24 19:37                       ` [PATCH 12/14] nfsd41: support 16 slots per session andros
2009-06-24 19:37                         ` [PATCH 13/14] nfsd41: add test for failed sequence operation andros
2009-06-24 19:37                           ` [PATCH 14/14] nfsd41: remove redundant failed sequence check andros
2009-07-01 23:09         ` [pnfs] [PATCH 4/5] nfsd41: set the session maximum response sizecached Alexandros Batsakis
2009-07-06 19:27           ` Andy Adamson
2009-07-06 21:48             ` J. Bruce Fields
2009-07-16 14:18       ` [pnfs] [PATCH 3/5] nfsd41: reclaim DRC memory on session free J. Bruce Fields
2009-07-16 15:49         ` William A. (Andy) Adamson
2009-07-27 22:57         ` J. Bruce Fields
2009-07-31  8:38           ` Andy Adamson
2009-07-16 14:17     ` [pnfs] [PATCH 2/5] nfsd41: change from page to memory based drc limits J. Bruce Fields
2009-07-16 18:50       ` J. Bruce Fields
2009-07-16 14:24     ` J. Bruce Fields
2009-06-28 16:01 ` [pnfs] [PATCH 0/14] NFSv4.1 Server DRC rewrite Version 4 Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245872278-18743-5-git-send-email-andros@netapp.com \
    --to=andros@netapp.com \
    --cc=bfields@citi.umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pnfs@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox