public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: andros@netapp.com
To: bfields@citi.umich.edu
Cc: pnfs@linux-nfs.org, linux-nfs@vger.kernel.org,
	Andy Adamson <andros@netapp.com>
Subject: [PATCH 06/14] nfsd41: change check_slot_seqid parameters
Date: Wed, 24 Jun 2009 15:37:50 -0400	[thread overview]
Message-ID: <1245872278-18743-7-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1245872278-18743-6-git-send-email-andros@netapp.com>

From: Andy Adamson <andros@netapp.com>

For separation of session slot and clientid slot processing.

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 fs/nfsd/nfs4state.c |   24 +++++++++++++-----------
 1 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index dc91544..0eab5e2 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1315,26 +1315,26 @@ error:
 }
 
 static int
-check_slot_seqid(u32 seqid, struct nfsd4_slot *slot)
+check_slot_seqid(u32 seqid, u32 slot_seqid, int slot_inuse)
 {
-	dprintk("%s enter. seqid %d slot->sl_seqid %d\n", __func__, seqid,
-		slot->sl_seqid);
+	dprintk("%s enter. seqid %d slot_seqid %d\n", __func__, seqid,
+		slot_seqid);
 
 	/* The slot is in use, and no response has been sent. */
-	if (slot->sl_inuse) {
-		if (seqid == slot->sl_seqid)
+	if (slot_inuse) {
+		if (seqid == slot_seqid)
 			return nfserr_jukebox;
 		else
 			return nfserr_seq_misordered;
 	}
 	/* Normal */
-	if (likely(seqid == slot->sl_seqid + 1))
+	if (likely(seqid == slot_seqid + 1))
 		return nfs_ok;
 	/* Replay */
-	if (seqid == slot->sl_seqid)
+	if (seqid == slot_seqid)
 		return nfserr_replay_cache;
 	/* Wraparound */
-	if (seqid == 1 && (slot->sl_seqid + 1) == 0)
+	if (seqid == 1 && (slot_seqid + 1) == 0)
 		return nfs_ok;
 	/* Misordered replay or misordered new request */
 	return nfserr_seq_misordered;
@@ -1357,7 +1357,8 @@ nfsd4_create_session(struct svc_rqst *rqstp,
 
 	if (conf) {
 		slot = &conf->cl_slot;
-		status = check_slot_seqid(cr_ses->seqid, slot);
+		status = check_slot_seqid(cr_ses->seqid, slot->sl_seqid,
+					  slot->sl_inuse);
 		if (status == nfserr_replay_cache) {
 			dprintk("Got a create_session replay! seqid= %d\n",
 				slot->sl_seqid);
@@ -1382,7 +1383,8 @@ nfsd4_create_session(struct svc_rqst *rqstp,
 		}
 
 		slot = &unconf->cl_slot;
-		status = check_slot_seqid(cr_ses->seqid, slot);
+		status = check_slot_seqid(cr_ses->seqid, slot->sl_seqid,
+					  slot->sl_inuse);
 		if (status) {
 			/* an unconfirmed replay returns misordered */
 			status = nfserr_seq_misordered;
@@ -1483,7 +1485,7 @@ nfsd4_sequence(struct svc_rqst *rqstp,
 	slot = &session->se_slots[seq->slotid];
 	dprintk("%s: slotid %d\n", __func__, seq->slotid);
 
-	status = check_slot_seqid(seq->seqid, slot);
+	status = check_slot_seqid(seq->seqid, slot->sl_seqid, slot->sl_inuse);
 	if (status == nfserr_replay_cache) {
 		cstate->slot = slot;
 		cstate->session = session;
-- 
1.5.4.3


  reply	other threads:[~2009-06-24 19:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 19:37 [PATCH 0/14] NFSv4.1 Server DRC rewrite Version 4 andros
2009-06-24 19:37 ` [PATCH 1/5] nfsd41: use globals for DRC limits andros
2009-06-24 19:37   ` [PATCH 2/5] nfsd41: change from page to memory based drc limits andros
2009-06-24 19:37     ` [PATCH 3/5] nfsd41: reclaim DRC memory on session free andros
2009-06-24 19:37       ` [PATCH 4/5] nfsd41: set the session maximum response size cached andros
2009-06-24 19:37         ` [PATCH 5/5] nfsd41: remove redundant forechannel max requests check andros
2009-06-24 19:37           ` andros [this message]
2009-06-24 19:37             ` [PATCH 07/14] nfsd41: replace create_session DRC with xdr structure andros
2009-06-24 19:37               ` [PATCH 08/14] nfsd41: replace page based DRC with buffer based DRC andros
2009-06-24 19:37                 ` [PATCH 09/14] nfsd41: rename nfsd4_enc_uncached_replay andros
2009-06-24 19:37                   ` [PATCH 10/14] nfsd41: encode replay sequence from the slot values andros
2009-06-24 19:37                     ` [PATCH 11/14] nfsd41: fix nfsd4_replay_cache_entry comments andros
2009-06-24 19:37                       ` [PATCH 12/14] nfsd41: support 16 slots per session andros
2009-06-24 19:37                         ` [PATCH 13/14] nfsd41: add test for failed sequence operation andros
2009-06-24 19:37                           ` [PATCH 14/14] nfsd41: remove redundant failed sequence check andros
2009-07-01 23:09         ` [pnfs] [PATCH 4/5] nfsd41: set the session maximum response sizecached Alexandros Batsakis
2009-07-06 19:27           ` Andy Adamson
2009-07-06 21:48             ` J. Bruce Fields
2009-07-16 14:18       ` [pnfs] [PATCH 3/5] nfsd41: reclaim DRC memory on session free J. Bruce Fields
2009-07-16 15:49         ` William A. (Andy) Adamson
2009-07-27 22:57         ` J. Bruce Fields
2009-07-31  8:38           ` Andy Adamson
2009-07-16 14:17     ` [pnfs] [PATCH 2/5] nfsd41: change from page to memory based drc limits J. Bruce Fields
2009-07-16 18:50       ` J. Bruce Fields
2009-07-16 14:24     ` J. Bruce Fields
2009-06-28 16:01 ` [pnfs] [PATCH 0/14] NFSv4.1 Server DRC rewrite Version 4 Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245872278-18743-7-git-send-email-andros@netapp.com \
    --to=andros@netapp.com \
    --cc=bfields@citi.umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pnfs@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox