* [PATCH] sunrpc: fix build-time warning
@ 2009-12-31 2:23 Jeff Layton
2009-12-31 17:18 ` Randy Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Layton @ 2009-12-31 2:23 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Stephen Rothwell, linux-kernel, linux-nfs
Commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a introduced this warning
at build time on some 32-bit architectures:
net/sunrpc/auth_gss/auth_gss.c: In function 'gss_pipe_downcall':
net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t
...fix it by changing the length modifier in the printk.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
net/sunrpc/auth_gss/auth_gss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
index 66cb89c..6de4f91 100644
--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
break;
default:
printk(KERN_CRIT "%s: bad return from "
- "gss_fill_context: %ld\n", __func__, err);
+ "gss_fill_context: %Zd\n", __func__, err);
BUG();
}
goto err_release_msg;
--
1.6.5.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] sunrpc: fix build-time warning
2009-12-31 2:23 [PATCH] sunrpc: fix build-time warning Jeff Layton
@ 2009-12-31 17:18 ` Randy Dunlap
2010-01-01 1:54 ` Jeff Layton
0 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2009-12-31 17:18 UTC (permalink / raw)
To: Jeff Layton; +Cc: Trond Myklebust, Stephen Rothwell, linux-kernel, linux-nfs
On Wed, 30 Dec 2009 21:23:15 -0500 Jeff Layton wrote:
> Commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a introduced this warning
> at build time on some 32-bit architectures:
>
> net/sunrpc/auth_gss/auth_gss.c: In function 'gss_pipe_downcall':
> net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t
>
> ...fix it by changing the length modifier in the printk.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> net/sunrpc/auth_gss/auth_gss.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
> index 66cb89c..6de4f91 100644
> --- a/net/sunrpc/auth_gss/auth_gss.c
> +++ b/net/sunrpc/auth_gss/auth_gss.c
> @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
> break;
> default:
> printk(KERN_CRIT "%s: bad return from "
> - "gss_fill_context: %ld\n", __func__, err);
> + "gss_fill_context: %Zd\n", __func__, err);
> BUG();
> }
> goto err_release_msg;
> --
I have that almost-same patch in my (unposted) linux-next patch queue,
so basically, ack, except that we try to use 'z' instead of 'Z' nowadays.
My quick kernel source tree count is 173 %Z to 966 %z.
(Please don't anyone start a project of converting %Z to %z.)
---
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sunrpc: fix build-time warning
2009-12-31 17:18 ` Randy Dunlap
@ 2010-01-01 1:54 ` Jeff Layton
[not found] ` <20091231205454.0f84f091-PC62bkCOHzGdMjc06nkz3ljfA9RmPOcC@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Layton @ 2010-01-01 1:54 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Trond Myklebust, Stephen Rothwell, linux-kernel, linux-nfs
On Thu, 31 Dec 2009 09:18:15 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Wed, 30 Dec 2009 21:23:15 -0500 Jeff Layton wrote:
>
> > Commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a introduced this warning
> > at build time on some 32-bit architectures:
> >
> > net/sunrpc/auth_gss/auth_gss.c: In function 'gss_pipe_downcall':
> > net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t
> >
> > ...fix it by changing the length modifier in the printk.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > ---
> > net/sunrpc/auth_gss/auth_gss.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
> > index 66cb89c..6de4f91 100644
> > --- a/net/sunrpc/auth_gss/auth_gss.c
> > +++ b/net/sunrpc/auth_gss/auth_gss.c
> > @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
> > break;
> > default:
> > printk(KERN_CRIT "%s: bad return from "
> > - "gss_fill_context: %ld\n", __func__, err);
> > + "gss_fill_context: %Zd\n", __func__, err);
> > BUG();
> > }
> > goto err_release_msg;
> > --
>
> I have that almost-same patch in my (unposted) linux-next patch queue,
> so basically, ack, except that we try to use 'z' instead of 'Z' nowadays.
>
> My quick kernel source tree count is 173 %Z to 966 %z.
> (Please don't anyone start a project of converting %Z to %z.)
>
If you have a patch queued up for this with the preferred qualifier,
then I'm fine with dropping this one.
Cheers,
--
Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-01-06 23:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-31 2:23 [PATCH] sunrpc: fix build-time warning Jeff Layton
2009-12-31 17:18 ` Randy Dunlap
2010-01-01 1:54 ` Jeff Layton
[not found] ` <20091231205454.0f84f091-PC62bkCOHzGdMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2010-01-02 2:25 ` [PATCH v2] " Randy Dunlap
2010-01-03 11:51 ` Jeff Layton
2010-01-06 23:10 ` Trond Myklebust
2010-01-06 23:51 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox