public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Ben Myers <bpm@sgi.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] wsync export option
Date: Wed, 03 Feb 2010 18:58:31 -0500	[thread overview]
Message-ID: <1265241511.2632.12.camel@localhost> (raw)
In-Reply-To: <20100203233755.17677.96582.stgit@case>

On Wed, 2010-02-03 at 17:44 -0600, Ben Myers wrote: 
> In April I did some research on why synchronous NFSv3 performance on XFS is so
> rotten when compared to local filesystem performance.  The workload I chose to
> work with is tar.
> 
> After taking some measurements I came to the conclusion that one of the big
> problems is that we're not treating the log as stable storage.  By calling
> write_inode_now() we've written the changes to the log first and then gone and
> also written them out to the inode on disk.
> 
> In a short discussion of this issue on the xfs-oss list it was suggested that I
> post the patches here for discussion.
> 
> The following series is adds a 'wsync' export option to nfsd.  It is intended
> to be used on XFS with the wsync mount option.  When you already have a
> synchronous log there is no need to sync metadata separately.

Why should the administrator have to both change /etc/fstab
and /etc/exports? That will be an immediate source of trouble if someone
changes one without changing the other.

Why not rather add an optional operation to the export_ops to let the
filesystem specify exactly what kind of synchronisation policy is
optimal for it?

Trond


  parent reply	other threads:[~2010-02-03 23:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 23:44 [RFC PATCH 0/4] wsync export option Ben Myers
2010-02-03 23:44 ` [RFC PATCH 1/4] Add 'wsync' " Ben Myers
2010-02-03 23:44 ` [RFC PATCH 2/4] Add datasync argument to nfsd_sync_dir() Ben Myers
2010-02-03 23:44 ` [RFC PATCH 3/4] If 'wsync' call vfs_fsync() instead of write_inode_now() Ben Myers
2010-02-03 23:44 ` [RFC PATCH 4/4] If 'wsync' pass datasync=1 to vfs_fsync() Ben Myers
2010-02-04 15:19   ` Christoph Hellwig
2010-02-04 17:20     ` bpm
2010-02-04 18:30       ` Christoph Hellwig
2010-02-04 18:38         ` Trond Myklebust
2010-02-04 18:40           ` Christoph Hellwig
2010-02-04 18:52             ` Trond Myklebust
2010-02-03 23:47 ` [ RFC PATCH 5/4 ] Add wsync export option to nfs-utils bpm
2010-02-03 23:58 ` Trond Myklebust [this message]
2010-02-04 15:21   ` [RFC PATCH 0/4] wsync export option Christoph Hellwig
2010-02-04 15:30 ` Christoph Hellwig
2010-02-04 18:15   ` bpm
2010-02-04 18:39     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265241511.2632.12.camel@localhost \
    --to=trond.myklebust@fys.uio.no \
    --cc=bpm@sgi.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox