From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Ben Myers <bpm@sgi.com>, linux-nfs@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] wsync export option
Date: Thu, 4 Feb 2010 10:21:47 -0500 [thread overview]
Message-ID: <20100204152147.GB22014@infradead.org> (raw)
In-Reply-To: <1265241511.2632.12.camel@localhost>
On Wed, Feb 03, 2010 at 06:58:31PM -0500, Trond Myklebust wrote:
> Why should the administrator have to both change /etc/fstab
> and /etc/exports? That will be an immediate source of trouble if someone
> changes one without changing the other.
I agree, this should be left to the filesystems.
> Why not rather add an optional operation to the export_ops to let the
> filesystem specify exactly what kind of synchronisation policy is
> optimal for it?
Maybe. But I suspect fsync is actually the right thing to do for
all the filesystems. The only reason why we'd still might want to make
it an export operation is that I'd really prefer not to grow more
instances of fsync without the file pointer. Then again they're
already all in nfs and it doesn't matter too much to audit a few
more places later.
next prev parent reply other threads:[~2010-02-04 15:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 23:44 [RFC PATCH 0/4] wsync export option Ben Myers
2010-02-03 23:44 ` [RFC PATCH 1/4] Add 'wsync' " Ben Myers
2010-02-03 23:44 ` [RFC PATCH 2/4] Add datasync argument to nfsd_sync_dir() Ben Myers
2010-02-03 23:44 ` [RFC PATCH 3/4] If 'wsync' call vfs_fsync() instead of write_inode_now() Ben Myers
2010-02-03 23:44 ` [RFC PATCH 4/4] If 'wsync' pass datasync=1 to vfs_fsync() Ben Myers
2010-02-04 15:19 ` Christoph Hellwig
2010-02-04 17:20 ` bpm
2010-02-04 18:30 ` Christoph Hellwig
2010-02-04 18:38 ` Trond Myklebust
2010-02-04 18:40 ` Christoph Hellwig
2010-02-04 18:52 ` Trond Myklebust
2010-02-03 23:47 ` [ RFC PATCH 5/4 ] Add wsync export option to nfs-utils bpm
2010-02-03 23:58 ` [RFC PATCH 0/4] wsync export option Trond Myklebust
2010-02-04 15:21 ` Christoph Hellwig [this message]
2010-02-04 15:30 ` Christoph Hellwig
2010-02-04 18:15 ` bpm
2010-02-04 18:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204152147.GB22014@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox