From: andros@netapp.com
To: bhalevy@panasas.com
Cc: linux-nfs@vger.kernel.org, Andy Adamson <andros@netapp.com>
Subject: [PATCH 2/8] SQUASHME pnfs-submit: pnfs_try_to_read, write, commit using freed memory
Date: Tue, 22 Jun 2010 17:56:32 -0400 [thread overview]
Message-ID: <1277243798-8181-3-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1277243798-8181-2-git-send-email-andros@netapp.com>
From: Andy Adamson <andros@netapp.com>
The nfs_read_data or nfs_write_data is freed during rpc call.
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfs/pnfs.h | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/pnfs.h b/fs/nfs/pnfs.h
index 78776f3..c60eff6 100644
--- a/fs/nfs/pnfs.h
+++ b/fs/nfs/pnfs.h
@@ -105,13 +105,14 @@ static inline enum pnfs_try_status
pnfs_try_to_read_data(struct nfs_read_data *data,
const struct rpc_call_ops *call_ops)
{
+ struct inode *inode = data->inode;
enum pnfs_try_status ret;
if (!data->req->wb_lseg)
return PNFS_NOT_ATTEMPTED;
ret = _pnfs_try_to_read_data(data, call_ops);
if (ret == PNFS_ATTEMPTED)
- nfs_inc_stats(data->inode, NFSIOS_PNFS_READ);
+ nfs_inc_stats(inode, NFSIOS_PNFS_READ);
else
_pnfs_clear_lseg_from_pages(&data->pages);
return ret;
@@ -122,13 +123,14 @@ pnfs_try_to_write_data(struct nfs_write_data *data,
const struct rpc_call_ops *call_ops,
int how)
{
+ struct inode *inode = data->inode;
enum pnfs_try_status ret;
if (!data->req->wb_lseg)
return PNFS_NOT_ATTEMPTED;
ret = _pnfs_try_to_write_data(data, call_ops, how);
if (ret == PNFS_ATTEMPTED)
- nfs_inc_stats(data->inode, NFSIOS_PNFS_WRITE);
+ nfs_inc_stats(inode, NFSIOS_PNFS_WRITE);
else
_pnfs_clear_lseg_from_pages(&data->pages);
return ret;
@@ -139,6 +141,7 @@ pnfs_try_to_commit(struct nfs_write_data *data,
const struct rpc_call_ops *call_ops,
int how)
{
+ struct inode *inode = data->inode;
enum pnfs_try_status ret;
/* Unlike in pnfs_try_to_write_data and pnfs_try_to_read_data,
@@ -148,7 +151,7 @@ pnfs_try_to_commit(struct nfs_write_data *data,
*/
ret = _pnfs_try_to_commit(data, call_ops, how);
if (ret == PNFS_ATTEMPTED)
- nfs_inc_stats(data->inode, NFSIOS_PNFS_COMMIT);
+ nfs_inc_stats(inode, NFSIOS_PNFS_COMMIT);
else
_pnfs_clear_lseg_from_pages(&data->pages);
return ret;
--
1.6.6
next prev parent reply other threads:[~2010-06-22 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 21:56 [PATCH 0/8] pnfs-submit add layoutget, layoutreturn error handling andros
2010-06-22 21:56 ` [PATCH 1/8] SQUASHME: pnfs-submit remove unused filelayout_mount_type andros
2010-06-22 21:56 ` andros [this message]
2010-06-22 21:56 ` [PATCH 3/8] SQUASHME pnfs-submit: tell commit to use the MDS andros
2010-06-22 21:56 ` [PATCH 4/8] SQUASHME pnfs-submit: remove encode_layoutreturn andros
2010-06-22 21:56 ` [PATCH 5/8] SQUASHME pnfs-submit: add error handling to layout return andros
2010-06-22 21:56 ` [PATCH 6/8] SQUASHME pnfs-submit: handle assassinated layoutcommit andros
2010-06-22 21:56 ` [PATCH 7/8] SQUASHME pnfs-submit: add error handlers to layout get andros
2010-06-22 21:56 ` [PATCH 8/8] pnfs-post-submit: restore encode_layoutreturn andros
2010-06-23 7:41 ` [PATCH 7/8] SQUASHME pnfs-submit: add error handlers to layout get Benny Halevy
2010-06-23 13:04 ` William A. (Andy) Adamson
[not found] ` <AANLkTinew-MgRJeswY3x7gJS-GBE_WMHhJdkWnrNGuo4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-23 19:23 ` William A. (Andy) Adamson
2010-06-23 13:34 ` [PATCH 3/8] SQUASHME pnfs-submit: tell commit to use the MDS Fred Isaman
[not found] ` <AANLkTimh37nfPbw5CZmBJv1XhIqrlogV_0nUVSDaxZJ3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-23 13:53 ` Andy Adamson
2010-06-23 14:11 ` Fred Isaman
[not found] ` <AANLkTikzfFVMd76tevedVeQ4Q6ot5wxXZ8fxKFNz_zyK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-23 14:24 ` Andy Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277243798-8181-3-git-send-email-andros@netapp.com \
--to=andros@netapp.com \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox