From: andros@netapp.com
To: bhalevy@panasas.com
Cc: linux-nfs@vger.kernel.org, Andy Adamson <andros@netapp.com>
Subject: [PATCH 4/8] SQUASHME pnfs-submit: remove encode_layoutreturn
Date: Tue, 22 Jun 2010 17:56:34 -0400 [thread overview]
Message-ID: <1277243798-8181-5-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1277243798-8181-4-git-send-email-andros@netapp.com>
From: Andy Adamson <andros@netapp.com>
Not used by the file layout
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfs/nfs4xdr.c | 15 ++-------------
include/linux/nfs4_pnfs.h | 4 ----
2 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
index a509bc1..fb50361 100644
--- a/fs/nfs/nfs4xdr.c
+++ b/fs/nfs/nfs4xdr.c
@@ -1874,24 +1874,13 @@ encode_layoutreturn(struct xdr_stream *xdr,
*p++ = cpu_to_be32(args->lseg.iomode);
*p = cpu_to_be32(args->return_type);
if (args->return_type == RETURN_FILE) {
- struct layoutdriver_io_operations *ld_io_ops =
- NFS_SERVER(args->inode)->pnfs_curr_ld->ld_io_ops;
-
p = reserve_space(xdr, 16 + NFS4_STATEID_SIZE);
p = xdr_encode_hyper(p, args->lseg.offset);
p = xdr_encode_hyper(p, args->lseg.length);
p = xdr_encode_opaque_fixed(p, &args->stateid.u.data,
NFS4_STATEID_SIZE);
-
- dprintk("%s: call %pF\n", __func__,
- ld_io_ops->encode_layoutreturn);
- if (ld_io_ops->encode_layoutreturn) {
- ld_io_ops->encode_layoutreturn(
- &NFS_I(args->inode)->layout, xdr, args);
- } else {
- p = reserve_space(xdr, 4);
- *p = cpu_to_be32(0);
- }
+ p = reserve_space(xdr, 4);
+ *p = cpu_to_be32(0);
}
hdr->nops++;
hdr->replen += decode_layoutreturn_maxsz;
diff --git a/include/linux/nfs4_pnfs.h b/include/linux/nfs4_pnfs.h
index d20b5de..782fdd9 100644
--- a/include/linux/nfs4_pnfs.h
+++ b/include/linux/nfs4_pnfs.h
@@ -154,10 +154,6 @@ struct layoutdriver_io_operations {
struct pnfs_layout_segment * (*alloc_lseg) (struct pnfs_layout_type *layoutid, struct nfs4_pnfs_layoutget_res *lgr);
void (*free_lseg) (struct pnfs_layout_segment *lseg);
- void (*encode_layoutreturn) (struct pnfs_layout_type *layoutid,
- struct xdr_stream *xdr,
- const struct nfs4_pnfs_layoutreturn_arg *args);
-
/* Registration information for a new mounted file system
*/
int (*initialize_mountpoint) (struct nfs_client *);
--
1.6.6
next prev parent reply other threads:[~2010-06-22 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 21:56 [PATCH 0/8] pnfs-submit add layoutget, layoutreturn error handling andros
2010-06-22 21:56 ` [PATCH 1/8] SQUASHME: pnfs-submit remove unused filelayout_mount_type andros
2010-06-22 21:56 ` [PATCH 2/8] SQUASHME pnfs-submit: pnfs_try_to_read, write, commit using freed memory andros
2010-06-22 21:56 ` [PATCH 3/8] SQUASHME pnfs-submit: tell commit to use the MDS andros
2010-06-22 21:56 ` andros [this message]
2010-06-22 21:56 ` [PATCH 5/8] SQUASHME pnfs-submit: add error handling to layout return andros
2010-06-22 21:56 ` [PATCH 6/8] SQUASHME pnfs-submit: handle assassinated layoutcommit andros
2010-06-22 21:56 ` [PATCH 7/8] SQUASHME pnfs-submit: add error handlers to layout get andros
2010-06-22 21:56 ` [PATCH 8/8] pnfs-post-submit: restore encode_layoutreturn andros
2010-06-23 7:41 ` [PATCH 7/8] SQUASHME pnfs-submit: add error handlers to layout get Benny Halevy
2010-06-23 13:04 ` William A. (Andy) Adamson
[not found] ` <AANLkTinew-MgRJeswY3x7gJS-GBE_WMHhJdkWnrNGuo4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-23 19:23 ` William A. (Andy) Adamson
2010-06-23 13:34 ` [PATCH 3/8] SQUASHME pnfs-submit: tell commit to use the MDS Fred Isaman
[not found] ` <AANLkTimh37nfPbw5CZmBJv1XhIqrlogV_0nUVSDaxZJ3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-23 13:53 ` Andy Adamson
2010-06-23 14:11 ` Fred Isaman
[not found] ` <AANLkTikzfFVMd76tevedVeQ4Q6ot5wxXZ8fxKFNz_zyK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-23 14:24 ` Andy Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277243798-8181-5-git-send-email-andros@netapp.com \
--to=andros@netapp.com \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox