From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Miquel van Smoorenburg <mikevs@xs4all.net>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 03/03] sunrpc: scale hashtable cache size with memory
Date: Tue, 07 Sep 2010 15:02:19 -0400 [thread overview]
Message-ID: <1283886139.2788.72.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20100822183149.GC26607@xs4all.net>
On Sun, 2010-08-22 at 20:31 +0200, Miquel van Smoorenburg wrote:
> Set the number of entries of the authcache to 4096 on servers
> with 4G of memory or more. Because kmallocing more than a few K
> is frowned upon, change the allocator from kmalloc to __get_free_pages.
> Since the minimum allocation size of __get_free_pages is 1 page,
> set the number of entries in the authcache to PAGE_SIZE / (entry_size)
> on servers with < 4G of memory so that exactly one page is used.
I'm not really understanding why this is an improvement. kmalloc() will
use pretty much the same mechanism when allocating a slab that is >
PAGE_SIZE, so why should we duplicate that in the RPC layer?
Cheers
Trond
next prev parent reply other threads:[~2010-09-07 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 18:28 [PATCH 00/03] sunrpc: a few authentication cache patches Miquel van Smoorenburg
2010-08-22 18:30 ` [PATCH 01/03]: sunrpc: increase MAX_HASHTABLE_BITS to 14 Miquel van Smoorenburg
2010-09-07 19:03 ` Trond Myklebust
2010-08-22 18:31 ` [PATCH 02/03]: sunrpc: make auth_hashtable_size param mode 0444 Miquel van Smoorenburg
2010-09-07 18:58 ` Trond Myklebust
2010-09-07 19:24 ` Miquel van Smoorenburg
2010-08-22 18:31 ` [PATCH 03/03] sunrpc: scale hashtable cache size with memory Miquel van Smoorenburg
2010-09-07 19:02 ` Trond Myklebust [this message]
2010-09-07 19:52 ` Miquel van Smoorenburg
2010-09-07 20:32 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283886139.2788.72.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=mikevs@xs4all.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox