public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel van Smoorenburg <mikevs@xs4all.net>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 00/03] sunrpc: a few authentication cache patches
Date: Sun, 22 Aug 2010 20:28:53 +0200	[thread overview]
Message-ID: <20100822182848.GA26590@xs4all.net> (raw)

Thanks for including the configurable authcache hashtable size patches
in 2.6.36. Yet another patch I can drop from our local builds.

I do have a few small enhancements though. I think the first
two should go into 2.6.36. The last one probably needs some
discussion.

Mike.

[PATCH 01/03]: sunrpc: increase MAX_HASHTABLE_BITS to 14

The maximum size of the authcache is now set to 1024 (10 bits),
but on our server we need at least 4096 (12 bits). Increase
MAX_HASHTABLE_BITS to 14. This is a maximum of 16384 entries,
each containing a pointer (8 bytes on x86_64). This is
exactly the limit of kmalloc() (128K).

[PATCH 02/03]: sunrpc: make auth_hashtable_size param mode 0444

The auth_hashtable_size parameter shows up in
/sys/module/sunrpc/parameters with mode 0644. However the hashtables
are allocated when the module is loaded, and changing the parameter
afterwards doesn't do much. So make it read-only.

[PATCH 03/03] sunrpc: scale hashtable cache size with memory

Set the number of entries of the authcache to 4096 on servers
with 4G of memory or more. Because kmallocing more than a few K
is frowned upon, change the allocator from kmalloc to __get_free_pages.
Since the minimum allocation size of __get_free_pages is 1 page,
set the number of entries in the authcache to PAGE_SIZE / (entry_size)
on servers with < 4G of memory so that exactly one page is used.


             reply	other threads:[~2010-08-22 18:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-22 18:28 Miquel van Smoorenburg [this message]
2010-08-22 18:30 ` [PATCH 01/03]: sunrpc: increase MAX_HASHTABLE_BITS to 14 Miquel van Smoorenburg
2010-09-07 19:03   ` Trond Myklebust
2010-08-22 18:31 ` [PATCH 02/03]: sunrpc: make auth_hashtable_size param mode 0444 Miquel van Smoorenburg
2010-09-07 18:58   ` Trond Myklebust
2010-09-07 19:24     ` Miquel van Smoorenburg
2010-08-22 18:31 ` [PATCH 03/03] sunrpc: scale hashtable cache size with memory Miquel van Smoorenburg
2010-09-07 19:02   ` Trond Myklebust
2010-09-07 19:52     ` Miquel van Smoorenburg
2010-09-07 20:32       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100822182848.GA26590@xs4all.net \
    --to=mikevs@xs4all.net \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox