* [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function @ 2013-10-14 20:24 Geyslan G. Bem 2013-10-14 20:24 ` [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c' Geyslan G. Bem 2013-10-14 20:32 ` [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function Geyslan Gregório Bem 0 siblings, 2 replies; 4+ messages in thread From: Geyslan G. Bem @ 2013-10-14 20:24 UTC (permalink / raw) To: Trond.Myklebust Cc: schumaker.anna, linux-nfs, linux-kernel, kernel-br, Geyslan G. Bem Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'. Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> --- fs/nfs/callback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c index 67cd732..073b4cf 100644 --- a/fs/nfs/callback.c +++ b/fs/nfs/callback.c @@ -164,8 +164,7 @@ nfs41_callback_up(struct svc_serv *serv) svc_xprt_put(serv->sv_bc_xprt); serv->sv_bc_xprt = NULL; } - dprintk("--> %s return %ld\n", __func__, - IS_ERR(rqstp) ? PTR_ERR(rqstp) : 0); + dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp)); return rqstp; } -- 1.8.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c' 2013-10-14 20:24 [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function Geyslan G. Bem @ 2013-10-14 20:24 ` Geyslan G. Bem 2013-10-14 20:33 ` Geyslan Gregório Bem 2013-10-14 20:32 ` [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function Geyslan Gregório Bem 1 sibling, 1 reply; 4+ messages in thread From: Geyslan G. Bem @ 2013-10-14 20:24 UTC (permalink / raw) To: Trond.Myklebust Cc: schumaker.anna, linux-nfs, linux-kernel, kernel-br, Geyslan G. Bem Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'. Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> --- fs/nfs/nfs4super.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index e26acdd..65ab0a0 100644 --- a/fs/nfs/nfs4super.c +++ b/fs/nfs/nfs4super.c @@ -261,9 +261,9 @@ struct dentry *nfs4_try_mount(int flags, const char *dev_name, res = nfs_follow_remote_path(root_mnt, export_path); - dfprintk(MOUNT, "<-- nfs4_try_mount() = %ld%s\n", - IS_ERR(res) ? PTR_ERR(res) : 0, - IS_ERR(res) ? " [error]" : ""); + dfprintk(MOUNT, "<-- nfs4_try_mount() = %d%s\n", + PTR_ERR_OR_ZERO(res), + IS_ERR(res) ? " [error]" : ""); return res; } @@ -319,9 +319,9 @@ static struct dentry *nfs4_referral_mount(struct file_system_type *fs_type, data->mnt_path = export_path; res = nfs_follow_remote_path(root_mnt, export_path); - dprintk("<-- nfs4_referral_mount() = %ld%s\n", - IS_ERR(res) ? PTR_ERR(res) : 0, - IS_ERR(res) ? " [error]" : ""); + dprintk("<-- nfs4_referral_mount() = %d%s\n", + PTR_ERR_OR_ZERO(res), + IS_ERR(res) ? " [error]" : ""); return res; } -- 1.8.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c' 2013-10-14 20:24 ` [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c' Geyslan G. Bem @ 2013-10-14 20:33 ` Geyslan Gregório Bem 0 siblings, 0 replies; 4+ messages in thread From: Geyslan Gregório Bem @ 2013-10-14 20:33 UTC (permalink / raw) To: Trond Myklebust Cc: schumaker.anna, linux-nfs, LKML, kernel-br, Geyslan G. Bem 2013/10/14 Geyslan G. Bem <geyslan@gmail.com>: > Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'. > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > --- > fs/nfs/nfs4super.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c > index e26acdd..65ab0a0 100644 > --- a/fs/nfs/nfs4super.c > +++ b/fs/nfs/nfs4super.c > @@ -261,9 +261,9 @@ struct dentry *nfs4_try_mount(int flags, const char *dev_name, > > res = nfs_follow_remote_path(root_mnt, export_path); > > - dfprintk(MOUNT, "<-- nfs4_try_mount() = %ld%s\n", > - IS_ERR(res) ? PTR_ERR(res) : 0, > - IS_ERR(res) ? " [error]" : ""); > + dfprintk(MOUNT, "<-- nfs4_try_mount() = %d%s\n", > + PTR_ERR_OR_ZERO(res), > + IS_ERR(res) ? " [error]" : ""); > return res; > } > > @@ -319,9 +319,9 @@ static struct dentry *nfs4_referral_mount(struct file_system_type *fs_type, > data->mnt_path = export_path; > > res = nfs_follow_remote_path(root_mnt, export_path); > - dprintk("<-- nfs4_referral_mount() = %ld%s\n", > - IS_ERR(res) ? PTR_ERR(res) : 0, > - IS_ERR(res) ? " [error]" : ""); > + dprintk("<-- nfs4_referral_mount() = %d%s\n", > + PTR_ERR_OR_ZERO(res), > + IS_ERR(res) ? " [error]" : ""); > return res; > } > > -- > 1.8.4 > In this version (v2): Format changed from %ld to %d. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function 2013-10-14 20:24 [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function Geyslan G. Bem 2013-10-14 20:24 ` [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c' Geyslan G. Bem @ 2013-10-14 20:32 ` Geyslan Gregório Bem 1 sibling, 0 replies; 4+ messages in thread From: Geyslan Gregório Bem @ 2013-10-14 20:32 UTC (permalink / raw) To: Trond Myklebust Cc: schumaker.anna, linux-nfs, LKML, kernel-br, Geyslan G. Bem 2013/10/14 Geyslan G. Bem <geyslan@gmail.com>: > Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'. > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > --- > fs/nfs/callback.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c > index 67cd732..073b4cf 100644 > --- a/fs/nfs/callback.c > +++ b/fs/nfs/callback.c > @@ -164,8 +164,7 @@ nfs41_callback_up(struct svc_serv *serv) > svc_xprt_put(serv->sv_bc_xprt); > serv->sv_bc_xprt = NULL; > } > - dprintk("--> %s return %ld\n", __func__, > - IS_ERR(rqstp) ? PTR_ERR(rqstp) : 0); > + dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp)); > return rqstp; > } > > -- > 1.8.4 > In this version (v2): Format changed from %ld to %d. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-14 20:33 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-14 20:24 [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function Geyslan G. Bem 2013-10-14 20:24 ` [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs/nfs4super.c' Geyslan G. Bem 2013-10-14 20:33 ` Geyslan Gregório Bem 2013-10-14 20:32 ` [PATCH v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function Geyslan Gregório Bem
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox