From: Steve Dickson <steved@redhat.com>
To: Libtirpc-devel Mailing List <libtirpc-devel@lists.sourceforge.net>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 00/15] libtirpc: New Debugging Interface
Date: Tue, 15 Jul 2014 11:09:19 -0400 [thread overview]
Message-ID: <1405436974-4161-1-git-send-email-steved@redhat.com> (raw)
It was brought to my attention there is large
amount of debugging in libtirpc but the library
had to be recompiled to access it.
With the precedence being set with the old librpcsecgss
and libnfsidmap where debugging can be set by the
application, I thought it would be a good idea to
build a similar interface in libtirpc.
A lot of these changes is in code that's not use or
even compiled but there is now one unified interface
we can build on.
The first patch defines the interface so I will not
repeat it here, but the interface is modeled after
a simplify xlog, used by a number of daemons. The
interface can log messages to strderr or syslog but
not both. Trying to keep it as simple as possible.
The debugging levels are broken down by:
level 1 - only error messages
level 2 - "I get here" type of messages
level 3 - "I got this value" type of messages
level 4 - hex dumps and other wordy messages
Steve Dickson (15):
libtirpc: New configurable debugging routines
gss_log: Convert existing gss debugging routines
gss_log: Removed DEBUG defines
gss_log_status: reformat output to use one line.
git_log_status: Add function name to status message
libtirpc_debug: Converted the rest of the #ifdef DEBUGs
gss_log: Replace gss_log_debug with LIBTIRPC_DEBUG macros
print_rpc_gss_sec: Make sure logging to stderr is enabled.
Clean up: Remove newlines from a couple debugging calls.
svcauth_des: Convert local debug() calls to LIBTIRPC_DEBUG() calls
key_call: Convert local debug() calls to LIBTIRPC_DEBUG() calls
clnt_bcast: Convert local debug() calls to LIBTIRPC_DEBUG() calls
rpcb_clnt: Convert fprintf calls to LIBTIRPC_DEBUG() calls
svc_dg: Convert fprintf calls to LIBTIRPC_DEBUG() calls
auth_des: Converted some of the debugging syslog calls to
LIBTIRPC_DEBUG() calls
src/Makefile.am | 4 +--
src/auth_des.c | 11 ++++----
src/auth_gss.c | 45 ++++++++++++++------------------
src/authgss_prot.c | 76 +++++++++++++++++++++---------------------------------
src/clnt_bcast.c | 36 ++++++++------------------
src/debug.c | 64 +++++++++++++++++++++++++++++++++++++++++++++
src/debug.h | 49 +++++++++++++++++++++++++++++++++++
src/getpublickey.c | 13 +++++-----
src/key_call.c | 21 ++++++---------
src/netnamer.c | 20 ++++++--------
src/rpcb_clnt.c | 65 +++++++++++++++-------------------------------
src/svc_auth_des.c | 32 +++++++++++------------
src/svc_auth_gss.c | 29 +++++++++++++--------
src/svc_dg.c | 51 +++++++++++++++++-------------------
14 files changed, 282 insertions(+), 234 deletions(-)
create mode 100644 src/debug.c
create mode 100644 src/debug.h
--
1.9.3
next reply other threads:[~2014-07-15 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 15:09 Steve Dickson [this message]
2014-07-15 15:09 ` [PATCH 01/15] libtirpc: New configurable debugging routines Steve Dickson
2014-07-15 15:09 ` [PATCH 02/15] gss_log: Convert existing gss " Steve Dickson
2014-07-15 15:09 ` [PATCH 03/15] gss_log: Removed DEBUG defines Steve Dickson
2014-07-15 15:09 ` [PATCH 04/15] gss_log_status: reformat output to use one line Steve Dickson
2014-07-15 15:09 ` [PATCH 05/15] git_log_status: Add function names to status message Steve Dickson
2014-07-15 15:09 ` [PATCH 06/15] libtirpc_debug: Converted the rest of the #ifdef DEBUGs Steve Dickson
2014-07-15 15:09 ` [PATCH 07/15] gss_log: Replace gss_log_debug with LIBTIRPC_DEBUG macros Steve Dickson
2014-07-15 15:09 ` [PATCH 08/15] print_rpc_gss_sec: Make sure logging to stderr is enabled Steve Dickson
2014-07-15 15:09 ` [PATCH 09/15] Clean up: Remove newlines from a couple debugging calls Steve Dickson
2014-07-15 15:09 ` [PATCH 10/15] svcauth_des: Convert local debug() calls to LIBTIRPC_DEBUG() calls Steve Dickson
2014-07-15 15:09 ` [PATCH 11/15] key_call: " Steve Dickson
2014-07-15 15:09 ` [PATCH 12/15] clnt_bcast: " Steve Dickson
2014-07-15 15:09 ` [PATCH 13/15] rpcb_clnt: Convert fprintf " Steve Dickson
2014-07-15 15:09 ` [PATCH 14/15] svc_dg: " Steve Dickson
2014-07-15 15:09 ` [PATCH 15/15] auth_des: Converted some of the debugging syslog " Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405436974-4161-1-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox