From: Steve Dickson <steved@redhat.com>
To: Libtirpc-devel Mailing List <libtirpc-devel@lists.sourceforge.net>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 10/15] svcauth_des: Convert local debug() calls to LIBTIRPC_DEBUG() calls
Date: Tue, 15 Jul 2014 11:09:29 -0400 [thread overview]
Message-ID: <1405436974-4161-11-git-send-email-steved@redhat.com> (raw)
In-Reply-To: <1405436974-4161-1-git-send-email-steved@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
---
src/svc_auth_des.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/svc_auth_des.c b/src/svc_auth_des.c
index e0ff6cb..08e2bee 100644
--- a/src/svc_auth_des.c
+++ b/src/svc_auth_des.c
@@ -64,9 +64,9 @@
#include <libc_private.h>
#endif
-extern int key_decryptsession_pk(const char *, netobj *, des_block *);
+#include "debug.h"
-#define debug(msg) printf("svcauth_des: %s\n", msg)
+extern int key_decryptsession_pk(const char *, netobj *, des_block *);
#define USEC_PER_SEC ((u_long) 1000000L)
#define BEFORE(t1, t2) timercmp(t1, t2, <)
@@ -178,20 +178,20 @@ _svcauth_des(rqst, msg)
sessionkey = &cred->adc_fullname.key;
if (! getpublickey(cred->adc_fullname.name, pkey_data)) {
- debug("getpublickey");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: getpublickey failed"));
return(AUTH_BADCRED);
}
pkey.n_bytes = pkey_data;
pkey.n_len = strlen(pkey_data) + 1;
if (key_decryptsession_pk(cred->adc_fullname.name, &pkey,
sessionkey) < 0) {
- debug("decryptsessionkey");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: key_decryptsessionkey failed"));
return (AUTH_BADCRED); /* key not found */
}
} else { /* ADN_NICKNAME */
sid = (short)cred->adc_nickname;
if (sid < 0 || sid >= AUTHDES_CACHESZ) {
- debug("bad nickname");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: bad nickname"));
return (AUTH_BADCRED); /* garbled credential */
}
sessionkey = &authdes_cache[sid].key;
@@ -214,7 +214,7 @@ _svcauth_des(rqst, msg)
sizeof(des_block), DES_DECRYPT | DES_HW);
}
if (DES_FAILED(status)) {
- debug("decryption failure");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: decryption failure"));
return (AUTH_FAILED); /* system error */
}
@@ -240,13 +240,13 @@ _svcauth_des(rqst, msg)
window = IXDR_GET_U_LONG(ixdr);
winverf = IXDR_GET_U_LONG(ixdr);
if (winverf != window - 1) {
- debug("window verifier mismatch");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: window verifier mismatch"));
return (AUTH_BADCRED); /* garbled credential */
}
sid = cache_spot(sessionkey, cred->adc_fullname.name,
×tamp);
if (sid < 0) {
- debug("replayed credential");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: replayed credential"));
return (AUTH_REJECTEDCRED); /* replay */
}
nick = 0;
@@ -256,19 +256,19 @@ _svcauth_des(rqst, msg)
}
if ((u_long)timestamp.tv_usec >= USEC_PER_SEC) {
- debug("invalid usecs");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: invalid usecs"));
/* cached out (bad key), or garbled verifier */
return (nick ? AUTH_REJECTEDVERF : AUTH_BADVERF);
}
if (nick && BEFORE(×tamp,
&authdes_cache[sid].laststamp)) {
- debug("timestamp before last seen");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: timestamp before last seen"));
return (AUTH_REJECTEDVERF); /* replay */
}
(void) gettimeofday(¤t, (struct timezone *)NULL);
current.tv_sec -= window; /* allow for expiration */
if (!BEFORE(¤t, ×tamp)) {
- debug("timestamp expired");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: timestamp expired"));
/* replay, or garbled credential */
return (nick ? AUTH_REJECTEDVERF : AUTH_BADCRED);
}
@@ -292,7 +292,7 @@ _svcauth_des(rqst, msg)
status = ecb_crypt((char *)sessionkey, (char *)cryptbuf,
sizeof(des_block), DES_ENCRYPT | DES_HW);
if (DES_FAILED(status)) {
- debug("encryption failure");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: encryption failure"));
return (AUTH_FAILED); /* system error */
}
verf.adv_xtimestamp = cryptbuf[0];
@@ -328,7 +328,7 @@ _svcauth_des(rqst, msg)
if (entry->rname != NULL) {
(void) strcpy(entry->rname, cred->adc_fullname.name);
} else {
- debug("out of memory");
+ LIBTIRPC_DEBUG(1, ("_svcauth_des: out of memory"));
}
entry->key = *sessionkey;
entry->window = window;
@@ -472,7 +472,7 @@ authdes_getucred(adc, uid, gid, grouplen, groups)
sid = adc->adc_nickname;
if (sid >= AUTHDES_CACHESZ) {
- debug("invalid nickname");
+ LIBTIRPC_DEBUG(1, ("authdes_getucred: invalid nickname"));
return (0);
}
cred = (struct bsdcred *)authdes_cache[sid].localcred;
@@ -488,11 +488,11 @@ authdes_getucred(adc, uid, gid, grouplen, groups)
if (!netname2user(adc->adc_fullname.name, &i_uid, &i_gid,
&i_grouplen, groups))
{
- debug("unknown netname");
+ LIBTIRPC_DEBUG(1, ("authdes_getucred: unknown netname"));
cred->grouplen = UNKNOWN; /* mark as lookup up, but not found */
return (0);
}
- debug("missed ucred cache");
+ LIBTIRPC_DEBUG(1, ("authdes_getucred: missed ucred cache"));
*uid = cred->uid = i_uid;
*gid = cred->gid = i_gid;
*grouplen = cred->grouplen = i_grouplen;
--
1.9.3
next prev parent reply other threads:[~2014-07-15 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 15:09 [PATCH 00/15] libtirpc: New Debugging Interface Steve Dickson
2014-07-15 15:09 ` [PATCH 01/15] libtirpc: New configurable debugging routines Steve Dickson
2014-07-15 15:09 ` [PATCH 02/15] gss_log: Convert existing gss " Steve Dickson
2014-07-15 15:09 ` [PATCH 03/15] gss_log: Removed DEBUG defines Steve Dickson
2014-07-15 15:09 ` [PATCH 04/15] gss_log_status: reformat output to use one line Steve Dickson
2014-07-15 15:09 ` [PATCH 05/15] git_log_status: Add function names to status message Steve Dickson
2014-07-15 15:09 ` [PATCH 06/15] libtirpc_debug: Converted the rest of the #ifdef DEBUGs Steve Dickson
2014-07-15 15:09 ` [PATCH 07/15] gss_log: Replace gss_log_debug with LIBTIRPC_DEBUG macros Steve Dickson
2014-07-15 15:09 ` [PATCH 08/15] print_rpc_gss_sec: Make sure logging to stderr is enabled Steve Dickson
2014-07-15 15:09 ` [PATCH 09/15] Clean up: Remove newlines from a couple debugging calls Steve Dickson
2014-07-15 15:09 ` Steve Dickson [this message]
2014-07-15 15:09 ` [PATCH 11/15] key_call: Convert local debug() calls to LIBTIRPC_DEBUG() calls Steve Dickson
2014-07-15 15:09 ` [PATCH 12/15] clnt_bcast: " Steve Dickson
2014-07-15 15:09 ` [PATCH 13/15] rpcb_clnt: Convert fprintf " Steve Dickson
2014-07-15 15:09 ` [PATCH 14/15] svc_dg: " Steve Dickson
2014-07-15 15:09 ` [PATCH 15/15] auth_des: Converted some of the debugging syslog " Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405436974-4161-11-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox