Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@primarydata.com>
To: bfields@fieldses.org
Cc: hch@infradead.org, linux-nfs@vger.kernel.org
Subject: [PATCH v3 0/6] nfsd: more delegation fixes to prepare for client_mutex removal
Date: Thu, 17 Jul 2014 15:12:28 -0400	[thread overview]
Message-ID: <1405624354-22388-1-git-send-email-jlayton@primarydata.com> (raw)

v3:
- use alternate method for checking for delegation break races after
  getting a lease (just check fi_had_conflict instead)

- drop file_has_lease patch -- no longer needed

- move cl_revoked handling patch into this set. It means altering a
  few of the later patches, but it keeps the set more topically
  coherent

v2:
- move remove_stid call from nfs4_free_stid and into callers

Here's a respin of the delegation fixes that Bruce hasn't yet merged
into his nfsd-next branch. I think this should address most of the
review comments so far.

I'm still not 100% thrilled with the delegation handling as a whole, but
I think it's getting a bit tighter now. I tend to think that we'll need
to rework this at some point in the future (and maybe the generic lease
code as well). I'd prefer to wait until after the rest of the
scalability work is complete before doing that if possible though.

Jeff Layton (3):
  nfsd: Protect the nfs4_file delegation fields using the fi_lock
  nfsd: Fix delegation revocation
  nfsd: ensure that clp->cl_revoked list is protected by clp->cl_lock

Trond Myklebust (3):
  nfsd: Move the delegation reference counter into the struct nfs4_stid
  nfsd: simplify stateid allocation and file handling
  nfsd: Convert delegation counter to an atomic_long_t type

 fs/nfsd/nfs4state.c | 148 +++++++++++++++++++++++++++++++++-------------------
 fs/nfsd/state.h     |   2 +-
 2 files changed, 96 insertions(+), 54 deletions(-)

-- 
1.9.3


             reply	other threads:[~2014-07-17 19:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 19:12 Jeff Layton [this message]
2014-07-17 19:12 ` [PATCH 1/6] nfsd: Protect the nfs4_file delegation fields using the fi_lock Jeff Layton
2014-07-17 19:23   ` Jeff Layton
2014-07-17 20:02   ` J. Bruce Fields
2014-07-18 11:27     ` Jeff Layton
2014-07-18  0:21   ` Jeff Layton
2014-07-17 19:12 ` [PATCH 2/6] nfsd: Move the delegation reference counter into the struct nfs4_stid Jeff Layton
2014-07-17 19:12 ` [PATCH 3/6] nfsd: simplify stateid allocation and file handling Jeff Layton
2014-07-17 19:12 ` [PATCH 4/6] nfsd: Fix delegation revocation Jeff Layton
2014-07-17 19:12 ` [PATCH 5/6] nfsd: ensure that clp->cl_revoked list is protected by clp->cl_lock Jeff Layton
2014-07-17 19:12 ` [PATCH 6/6] nfsd: Convert delegation counter to an atomic_long_t type Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405624354-22388-1-git-send-email-jlayton@primarydata.com \
    --to=jlayton@primarydata.com \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox