public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rpcbind: exit gracefully on termination
@ 2014-10-24 13:13 Steve Dickson
  2014-10-28 19:06 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Dickson @ 2014-10-24 13:13 UTC (permalink / raw)
  To: Linux NFS Mailing list

When systemd bring rpcbind down, via an expect signal,
exit gracefully with a zero status and don't log a
meaningless message.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 src/rpcbind.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/rpcbind.c b/src/rpcbind.c
index 83dbe93..1924d97 100644
--- a/src/rpcbind.c
+++ b/src/rpcbind.c
@@ -726,11 +726,9 @@ terminate(int dummy /*__unused*/)
 	unlink(_PATH_RPCBINDSOCK);
 	unlink(RPCBINDDLOCK);
 #ifdef WARMSTART
-	syslog(LOG_ERR,
-		"rpcbind terminating on signal. Restart with \"rpcbind -w\"");
 	write_warmstart();	/* Dump yourself */
 #endif
-	exit(2);
+	exit(0); /* exit gracefully */
 }
 
 void
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rpcbind: exit gracefully on termination
  2014-10-24 13:13 [PATCH] rpcbind: exit gracefully on termination Steve Dickson
@ 2014-10-28 19:06 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2014-10-28 19:06 UTC (permalink / raw)
  To: Linux NFS Mailing list



On 10/24/2014 09:13 AM, Steve Dickson wrote:
> When systemd bring rpcbind down, via an expect signal,
> exit gracefully with a zero status and don't log a
> meaningless message.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed....

steved.

> ---
>  src/rpcbind.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/rpcbind.c b/src/rpcbind.c
> index 83dbe93..1924d97 100644
> --- a/src/rpcbind.c
> +++ b/src/rpcbind.c
> @@ -726,11 +726,9 @@ terminate(int dummy /*__unused*/)
>  	unlink(_PATH_RPCBINDSOCK);
>  	unlink(RPCBINDDLOCK);
>  #ifdef WARMSTART
> -	syslog(LOG_ERR,
> -		"rpcbind terminating on signal. Restart with \"rpcbind -w\"");
>  	write_warmstart();	/* Dump yourself */
>  #endif
> -	exit(2);
> +	exit(0); /* exit gracefully */
>  }
>  
>  void
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-28 19:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-24 13:13 [PATCH] rpcbind: exit gracefully on termination Steve Dickson
2014-10-28 19:06 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox