* [PATCH] nfs: remove spurious WARN_ON_ONCE in write path
@ 2014-11-03 20:19 Weston Andros Adamson
2014-11-03 20:21 ` Weston Andros Adamson
0 siblings, 1 reply; 2+ messages in thread
From: Weston Andros Adamson @ 2014-11-03 20:19 UTC (permalink / raw)
To: trond.myklebust; +Cc: linux-nfs, Weston Andros Adamson
This WARN_ON_ONCE was supposed to catch reference counting bugs, but can
trigger in inappropriate situations.
This was reproducible using NFSv2 on an architecture with 64K pages -- we
verified that it was not a reference counting bug and the warning was
safe to ignore.
Reported-by: Will Deacon <will.deacon@arm.com>
Tested-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
---
fs/nfs/write.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 12493846a2d3..f83b02dc9166 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req)
if (test_and_clear_bit(PG_INODE_REF, &req->wb_flags))
nfs_release_request(req);
- else
- WARN_ON_ONCE(1);
}
static void
--
1.9.3 (Apple Git-50)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs: remove spurious WARN_ON_ONCE in write path
2014-11-03 20:19 [PATCH] nfs: remove spurious WARN_ON_ONCE in write path Weston Andros Adamson
@ 2014-11-03 20:21 ` Weston Andros Adamson
0 siblings, 0 replies; 2+ messages in thread
From: Weston Andros Adamson @ 2014-11-03 20:21 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs list
I’m not sure it we want to CC stable on this one - the single warning can simply be ignored.
-dros
> On Nov 3, 2014, at 3:19 PM, Weston Andros Adamson <dros@primarydata.com> wrote:
>
> This WARN_ON_ONCE was supposed to catch reference counting bugs, but can
> trigger in inappropriate situations.
>
> This was reproducible using NFSv2 on an architecture with 64K pages -- we
> verified that it was not a reference counting bug and the warning was
> safe to ignore.
>
> Reported-by: Will Deacon <will.deacon@arm.com>
> Tested-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> ---
> fs/nfs/write.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfs/write.c b/fs/nfs/write.c
> index 12493846a2d3..f83b02dc9166 100644
> --- a/fs/nfs/write.c
> +++ b/fs/nfs/write.c
> @@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req)
>
> if (test_and_clear_bit(PG_INODE_REF, &req->wb_flags))
> nfs_release_request(req);
> - else
> - WARN_ON_ONCE(1);
> }
>
> static void
> --
> 1.9.3 (Apple Git-50)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-03 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 20:19 [PATCH] nfs: remove spurious WARN_ON_ONCE in write path Weston Andros Adamson
2014-11-03 20:21 ` Weston Andros Adamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox