public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Scott Mayhew <smayhew@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [nfs-utils RFC PATCH 12/15] mountstats: Add support for -R/--raw to mountstats_command
Date: Wed,  5 Nov 2014 12:01:09 -0500	[thread overview]
Message-ID: <1415206872-864-13-git-send-email-smayhew@redhat.com> (raw)
In-Reply-To: <1415206872-864-1-git-send-email-smayhew@redhat.com>

This option displays the mountstats in raw format (i.e. in the same
format as /proc/self/mountstats).  It's intended to be used mainly with
the -S/--since option.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 tools/mountstats/mountstats.py | 50 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 45 insertions(+), 5 deletions(-)

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 281f4be..2d6ca95 100755
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -305,6 +305,41 @@ class DeviceData:
             return True
         return False
 
+    def display_raw_stats(self):
+        """Prints out stats in the same format as /proc/self/mountstats
+        """
+        print('device %s mounted on %s with fstype %s %s' % \
+            (self.__nfs_data['export'], self.__nfs_data['mountpoint'], \
+            self.__nfs_data['fstype'], self.__nfs_data['statvers']))
+        print('\topts:\t%s' % ','.join(self.__nfs_data['mountoptions']))
+        print('\tage:\t%d' % self.__nfs_data['age'])
+        print('\tcaps:\t%s' % ','.join(self.__nfs_data['servercapabilities']))
+        print('\tsec:\tflavor=%d,pseudoflavor=%d' % (self.__nfs_data['flavor'], \
+            self.__nfs_data['pseudoflavor']))
+        print('\tevents:\t%s' % " ".join([str(self.__nfs_data[key]) for key in NfsEventCounters]))
+        print('\tbytes:\t%s' % " ".join([str(self.__nfs_data[key]) for key in NfsByteCounters]))
+        print('\tRPC iostats version: %1.1f p/v: %s (nfs)' % (self.__rpc_data['statsvers'], \
+            self.__rpc_data['programversion']))
+        if self.__rpc_data['protocol'] == 'udp':
+            print('\txprt:\tudp %s' % " ".join([str(self.__rpc_data[key]) for key in XprtUdpCounters]))
+        elif self.__rpc_data['protocol'] == 'tcp':
+            print('\txprt:\ttcp %s' % " ".join([str(self.__rpc_data[key]) for key in XprtTcpCounters]))
+        elif self.__rpc_data['protocol'] == 'rdma':
+            print('\txprt:\trdma %s' % " ".join([str(self.__rpc_data[key]) for key in XprtRdmaCounters]))
+        else:
+            raise Exception('Unknown RPC transport protocol %s' % self.__rpc_data['protocol'])
+        print('\tper-op statistics')
+        prog, vers = self.__rpc_data['programversion'].split('/')
+        if vers == '3':
+            for op in Nfsv3ops:
+                print('\t%12s: %s' % (op, " ".join(str(x) for x in self.__rpc_data[op])))
+        elif vers == '4':
+            for op in Nfsv4ops:
+                print('\t%12s: %s' % (op, " ".join(str(x) for x in self.__rpc_data[op])))
+        else:
+            print('\tnot implemented for version %d' % vers)
+        print()
+
     def display_nfs_options(self):
         """Pretty-print the NFS options
         """
@@ -565,7 +600,7 @@ def print_mountstats_help(name):
     print('  --since <file> shows difference between current stats and those in \'file\'')
     print()
 
-def print_mountstats(stats, nfs_only, rpc_only):
+def print_mountstats(stats, nfs_only, rpc_only, raw):
     if nfs_only:
        stats.display_nfs_options()
        stats.display_nfs_events()
@@ -573,6 +608,8 @@ def print_mountstats(stats, nfs_only, rpc_only):
     elif rpc_only:
        stats.display_rpc_generic_stats()
        stats.display_rpc_op_stats()
+    elif raw:
+       stats.display_raw_stats()
     else:
        stats.display_nfs_options()
        stats.display_nfs_bytes()
@@ -583,13 +620,14 @@ def mountstats_command():
     """Mountstats command
     """
     try:
-        opts, args = getopt.getopt(sys.argv[1:], "ef:hnrsvS:", ["end", "file=", "help", "nfs", "rpc", "start", "version", "since="])
+        opts, args = getopt.getopt(sys.argv[1:], "ef:hnrsvS:R", ["end", "file=", "help", "nfs", "rpc", "start", "version", "since=", "raw"])
     except getopt.GetoptError as err:
         print_mountstats_help(prog)
 
     mountpoints = []
     nfs_only = False
     rpc_only = False
+    raw = False
     infile = None
     since = None
 
@@ -612,6 +650,8 @@ def mountstats_command():
             sys.exit(0)
         elif o in ("-S", "--since"):
             since = a
+        elif o in ("-R", "--raw"):
+            raw = True
         else:
             assert False, "unhandled option"
     mountpoints += args
@@ -650,14 +690,14 @@ def mountstats_command():
         stats = DeviceData()
         stats.parse_stats(mountstats[mp])
         if not since:
-            print_mountstats(stats, nfs_only, rpc_only)
+            print_mountstats(stats, nfs_only, rpc_only, raw)
         elif since and mp not in old_mountstats:
-            print_mountstats(stats, nfs_only, rpc_only)
+            print_mountstats(stats, nfs_only, rpc_only, raw)
         else:
             old_stats = DeviceData()
             old_stats.parse_stats(old_mountstats[mp])
             diff_stats = stats.compare_iostats(old_stats)
-            print_mountstats(diff_stats, nfs_only, rpc_only)
+            print_mountstats(diff_stats, nfs_only, rpc_only, raw)
 
 def print_nfsstat_help(name):
     print('usage: %s [ options ]' % name)
-- 
1.9.3


  parent reply	other threads:[~2014-11-05 17:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 17:00 [nfs-utils RFC PATCH 00/15] A few enhancements to mountstats.py Scott Mayhew
2014-11-05 17:00 ` [nfs-utils RFC PATCH 01/15] mountstats: Fix up NFS event counters Scott Mayhew
2014-11-05 17:00 ` [nfs-utils RFC PATCH 02/15] mountstats: Add lists of various counters Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 03/15] mountstats: Refactor __parse_nfs_line and __parse_rpc_line Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 04/15] mountstats: Refactor compare_iostats Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 05/15] mountstats: Convert existing option parsing to use the getopt module Scott Mayhew
2014-11-06  1:52   ` Chuck Lever
2014-11-06 14:44     ` Scott Mayhew
2014-11-06 15:02       ` Chuck Lever
2014-11-05 17:01 ` [nfs-utils RFC PATCH 06/15] mountstats: Make ms-iostat output match that of nfs-iostat.py Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 07/15] mountstats: Make print_iostat_summary handle newly appearing mounts Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 08/15] mountstats: Add support for -f/--file to the mountstats and ms-iostat commands Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 09/15] mountstats: Add support for -S/--since " Scott Mayhew
2014-11-06  1:50   ` Chuck Lever
2014-11-06 14:40     ` Scott Mayhew
2014-11-06 15:02       ` Chuck Lever
2014-11-05 17:01 ` [nfs-utils RFC PATCH 10/15] mountstats: Fix IndexError in __parse_nfs_line Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 11/15] mountstats: Allow mountstats_command to take a variable number of mountpoints Scott Mayhew
2014-11-06  2:09   ` Chuck Lever
2014-11-06 14:46     ` Scott Mayhew
2014-11-06 14:58       ` Chuck Lever
2014-11-05 17:01 ` Scott Mayhew [this message]
2014-11-05 17:01 ` [nfs-utils RFC PATCH 13/15] mountstats: Implement nfsstat_command Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 14/15] mountstats: Remove the --start and --end options Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 15/15] mountstats: Update the help output Scott Mayhew
2014-11-05 18:08 ` [nfs-utils RFC PATCH 00/15] A few enhancements to mountstats.py Chuck Lever
2014-11-05 22:07   ` Scott Mayhew
2014-11-05 20:34 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415206872-864-13-git-send-email-smayhew@redhat.com \
    --to=smayhew@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox