From: Scott Mayhew <smayhew@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [nfs-utils RFC PATCH 13/15] mountstats: Implement nfsstat_command
Date: Wed, 5 Nov 2014 12:01:10 -0500 [thread overview]
Message-ID: <1415206872-864-14-git-send-email-smayhew@redhat.com> (raw)
In-Reply-To: <1415206872-864-1-git-send-email-smayhew@redhat.com>
Displays nfssstat-like statistics for a single mountpoint (client
statistics only).
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
tools/mountstats/mountstats.py | 87 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 86 insertions(+), 1 deletion(-)
diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 2d6ca95..389f241 100755
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -445,6 +445,42 @@ class DeviceData:
print('\ttotal execute time: %f (milliseconds)' % \
(float(stats[7]) / count))
+ def display_nfsstat_stats(self):
+ """Pretty-print nfsstat-style stats
+ """
+ sends = 0
+ trans = 0
+ for op in self.__rpc_data['ops']:
+ sends += self.__rpc_data[op][0]
+ trans += self.__rpc_data[op][1]
+ retrans = trans - sends
+ print('Client rpc stats:')
+ print('calls retrans authrefrsh')
+ # authrefresh stats don't actually get captured in
+ # /proc/self/mountstats, so we fudge it here
+ print('%-11u%-11u%-11u' % (sends, retrans, sends))
+ if not sends:
+ return
+ print()
+ prog, vers = self.__rpc_data['programversion'].split('/')
+ print('Client nfs v%d' % int(vers))
+ info = []
+ for op in self.__rpc_data['ops']:
+ print('%-13s' % str.lower(op), end='')
+ count = self.__rpc_data[op][0]
+ pct = (count * 100) / sends
+ info.append((count, pct))
+ if (self.__rpc_data['ops'].index(op) + 1) % 6 == 0:
+ print()
+ for (count, pct) in info:
+ print('%-8u%3u%% ' % (count, pct), end='')
+ print()
+ info = []
+ print()
+ for (count, pct) in info:
+ print('%-8u%3u%% ' % (count, pct), end='')
+ print()
+
def compare_iostats(self, old_stats):
"""Return the difference between two sets of stats
"""
@@ -706,9 +742,58 @@ def print_nfsstat_help(name):
print()
print(' nfsstat-like program that uses NFS client per-mount statistics.')
print()
+ print('Options:')
+ print()
+ print(' -m <mountpoint>, --mountpount <mountpoint>')
+ print(' Show stats for \'mountpoint\'')
+ print()
+ print(' -f <file>, --file <file>')
+ print(' Read stats from \'file\' instead of /proc/self/mountstats')
+ print()
+ print(' -S <file>, --since <file>')
+ print(' Shows difference between current stats and those in \'file\'')
+ print()
+ print(' -h, --help')
+ print(' What you just did')
def nfsstat_command():
- print_nfsstat_help(prog)
+ """nfsstat-like command for NFS mount points
+ """
+ try:
+ opts, args = getopt.getopt(sys.argv[1:], "f:hm:S:", ["file=", "help", "mountpoint=", "since="])
+ except getopt.GetoptError as err:
+ print_nfsstat_help(prog)
+ infile = None
+ mp = None
+ since = None
+ for o, a in opts:
+ if o in ("-f", "--file"):
+ infile = a
+ elif o in ("-h", "--help"):
+ print_nfsstat_help(prog)
+ sys.exit()
+ elif o in ("-m", "--mountpoint"):
+ mp = a
+ elif o in ("-S", "--since"):
+ since = a
+ else:
+ assert False, "unhandled option"
+ if not mp:
+ print_nfsstat_help(prog)
+ sys.exit()
+ if not infile:
+ infile = '/proc/self/mountstats'
+ mountstats = parse_stats_file(infile)
+ stats = DeviceData()
+ stats.parse_stats(mountstats[mp])
+ if not since:
+ stats.display_nfsstat_stats()
+ else:
+ old_mountstats = parse_stats_file(since)
+ oldstats = DeviceData()
+ oldstats.parse_stats(old_mountstats[mp])
+ diff_stats = stats.compare_iostats(oldstats)
+ diff_stats.display_nfsstat_stats()
def print_iostat_help(name):
print('usage: %s [ <interval> [ <count> ] ] [ <mount point> ] ' % name)
--
1.9.3
next prev parent reply other threads:[~2014-11-05 17:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 17:00 [nfs-utils RFC PATCH 00/15] A few enhancements to mountstats.py Scott Mayhew
2014-11-05 17:00 ` [nfs-utils RFC PATCH 01/15] mountstats: Fix up NFS event counters Scott Mayhew
2014-11-05 17:00 ` [nfs-utils RFC PATCH 02/15] mountstats: Add lists of various counters Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 03/15] mountstats: Refactor __parse_nfs_line and __parse_rpc_line Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 04/15] mountstats: Refactor compare_iostats Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 05/15] mountstats: Convert existing option parsing to use the getopt module Scott Mayhew
2014-11-06 1:52 ` Chuck Lever
2014-11-06 14:44 ` Scott Mayhew
2014-11-06 15:02 ` Chuck Lever
2014-11-05 17:01 ` [nfs-utils RFC PATCH 06/15] mountstats: Make ms-iostat output match that of nfs-iostat.py Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 07/15] mountstats: Make print_iostat_summary handle newly appearing mounts Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 08/15] mountstats: Add support for -f/--file to the mountstats and ms-iostat commands Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 09/15] mountstats: Add support for -S/--since " Scott Mayhew
2014-11-06 1:50 ` Chuck Lever
2014-11-06 14:40 ` Scott Mayhew
2014-11-06 15:02 ` Chuck Lever
2014-11-05 17:01 ` [nfs-utils RFC PATCH 10/15] mountstats: Fix IndexError in __parse_nfs_line Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 11/15] mountstats: Allow mountstats_command to take a variable number of mountpoints Scott Mayhew
2014-11-06 2:09 ` Chuck Lever
2014-11-06 14:46 ` Scott Mayhew
2014-11-06 14:58 ` Chuck Lever
2014-11-05 17:01 ` [nfs-utils RFC PATCH 12/15] mountstats: Add support for -R/--raw to mountstats_command Scott Mayhew
2014-11-05 17:01 ` Scott Mayhew [this message]
2014-11-05 17:01 ` [nfs-utils RFC PATCH 14/15] mountstats: Remove the --start and --end options Scott Mayhew
2014-11-05 17:01 ` [nfs-utils RFC PATCH 15/15] mountstats: Update the help output Scott Mayhew
2014-11-05 18:08 ` [nfs-utils RFC PATCH 00/15] A few enhancements to mountstats.py Chuck Lever
2014-11-05 22:07 ` Scott Mayhew
2014-11-05 20:34 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415206872-864-14-git-send-email-smayhew@redhat.com \
--to=smayhew@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox