From: Henrique Martins <linux@martins.cc>
To: linux-nfs@vger.kernel.org
Subject: F20 nfs-utils exportfs patch
Date: Fri, 05 Sep 2014 10:02:08 -0700 [thread overview]
Message-ID: <14393.1409936528@monster.martins.cc> (raw)
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
Attaching path to exportfs that:
- in client.c/client_lookup:
changes the (x)log level for unresolvable entries in
/etc/exports from L_ERROR to L_WARNING,
- in hostname.c/host_addrinfo:
changes the (x)log level for unresolvable entries in
/etc/exports from D_GENERAL to D_PARSE,
- in export.c/export_read:
counts the number of exported volume entries and
generates a (x)log L_ERROR if no volumes are exported.
Built and tested on a Fedora 20 system.
-- Henrique
[-- Attachment #2: nfs-utils-1.3.0-exportfs.patch --]
[-- Type: text/x-diff, Size: 1718 bytes --]
--- nfs-utils-1.3.0/support/export/client.c.orig 2014-09-05 08:21:37.568364360 -0700
+++ nfs-utils-1.3.0/support/export/client.c 2014-09-05 08:21:41.709451778 -0700
@@ -277,7 +277,7 @@
if (htype == MCL_FQDN && !canonical) {
ai = host_addrinfo(hname);
if (!ai) {
- xlog(L_ERROR, "Failed to resolve %s", hname);
+ xlog(L_WARNING, "Failed to resolve %s", hname);
goto out;
}
hname = ai->ai_canonname;
--- nfs-utils-1.3.0/support/export/hostname.c.orig 2014-09-05 08:09:07.387551291 -0700
+++ nfs-utils-1.3.0/support/export/hostname.c 2014-09-05 08:09:13.799573723 -0700
@@ -175,11 +175,11 @@
case 0:
return ai;
case EAI_SYSTEM:
- xlog(D_GENERAL, "%s: failed to resolve %s: (%d) %m",
+ xlog(D_PARSE, "%s: failed to resolve %s: (%d) %m",
__func__, hostname, errno);
break;
default:
- xlog(D_GENERAL, "%s: failed to resolve %s: %s",
+ xlog(D_PARSE, "%s: failed to resolve %s: %s",
__func__, hostname, gai_strerror(error));
break;
}
--- nfs-utils-1.3.0/support/export/export.c.orig 2014-03-25 08:12:07.000000000 -0700
+++ nfs-utils-1.3.0/support/export/export.c 2014-09-05 09:23:37.424105125 -0700
@@ -76,15 +76,22 @@
struct exportent *eep;
nfs_export *exp;
+ int volumes = 0;
+
setexportent(fname, "r");
while ((eep = getexportent(0,1)) != NULL) {
exp = export_lookup(eep->e_hostname, eep->e_path, 0);
- if (!exp)
- export_create(eep, 0);
+ if (!exp) {
+ exp = export_create(eep, 0);
+ if (exp)
+ volumes++;
+ }
else
warn_duplicated_exports(exp, eep);
}
endexportent();
+ if (volumes == 0)
+ xlog(L_ERROR, "no or all unresolvable export entries");
}
/**
next reply other threads:[~2014-09-05 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:02 Henrique Martins [this message]
2014-10-31 18:33 ` F20 nfs-utils exportfs patch Henrique Martins
2014-11-04 17:57 ` Steve Dickson
2014-11-05 1:30 ` Henrique Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14393.1409936528@monster.martins.cc \
--to=linux@martins.cc \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox