From: Henrique Martins <linux@martins.cc>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: F20 nfs-utils exportfs patch
Date: Tue, 04 Nov 2014 17:30:32 -0800 [thread overview]
Message-ID: <16217.1415151032@monster.martins.cc> (raw)
In-Reply-To: <54591385.2080007@RedHat.com>
Missed these comments in the middle of the patch ...
> Just curious as to why these changes... What does D_PARSE do that
> D_GENERAL does not?
D_PARSE, and L_WARNING, don't cause xlog to return an error,
D_GENERAL and L_ERROR do. An error from xlog which will
cause nfsd to error out and not start.
I changed L_ERROR with L_WARNING, but there was no
D_WARNING def or similar so I went with D_PARSE instead of
adding that one.
> When testing the patch, I notice two "Failed to resolve" warning messages
> are logged for each export... Its not because of this patch but
> I wounder how that could be cleaned up a bit....
Hopefully you solved that, otherwise I would have to hunt on
which machine I generated those patches, if I didn't wipe
out the rpmbuild environment yet..
-- Henrique
prev parent reply other threads:[~2014-11-05 1:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:02 F20 nfs-utils exportfs patch Henrique Martins
2014-10-31 18:33 ` Henrique Martins
2014-11-04 17:57 ` Steve Dickson
2014-11-05 1:30 ` Henrique Martins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16217.1415151032@monster.martins.cc \
--to=linux@martins.cc \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox