Re: [PATCH 01/11] nfs-utils: mount: non-nfs mount options

[Neil Brown <neilb@suse.de>]

On Monday February 26, SteveD@redhat.com wrote:
> commit 806b02f63fe6e01946d84a1f14c74e977be76530
> Author: Amit Gud <agud@redhat.com>
> Date:   Sat Feb 24 14:31:13 2007 -0500
> 
>     Added the following non-nfs mount options as suggested
>     but upstream code reviews:
>     
>         [no]auto, [no]users, [no]user, [no]owner, [no]group
>     	    _netdev, comment

This patch does a lot more than that brief description suggests.

- The 'users' / 'user' changes are enough to be a patch in itself,
  particularly as it is a security issue and needs careful review.
  mount and umount do similar tests here and it would be good to
  include them in the library (nfs/fstab.c).

- 'const' is removed from nfs_mntent_s, and copy_mntent is introduced
  .. are those related?

- You copy instead of link the 4 different mount.* programs, which
  might be a good thing, but deserves a comment in the changelog.

- Some printf change to fprintf, which is good, but seems to be
  independent of the rest.

and possible some other things that I didn't notice.  As this is a
setuid program, I really want to be able to review changes in
isolation please.

Thanks,
NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs