Linux NFS development
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Steve Dickson <SteveD@redhat.com>
Cc: "'nfs@lists.sourceforge.net'" <nfs@lists.sourceforge.net>,
	Amit Gud <gud@ksu.edu>
Subject: Re: [PATCH 01/11] nfs-utils: mount: non-nfs mount options
Date: Mon, 19 Mar 2007 10:41:40 +1100	[thread overview]
Message-ID: <17917.52788.9258.451246@notabene.brown> (raw)
In-Reply-To: message from Steve Dickson on Friday March 16

On Friday March 16, SteveD@redhat.com wrote:
> 
> > 
> > and possible some other things that I didn't notice.  As this is a
> > setuid program, I really want to be able to review changes in
> > isolation please.
> Ok... I broke the original patch up into 3 separate ones.
> Pleas see attachments...

Thanks.  I've applied the last.
I'd really like to understand the ln/cp issue before applying.  And
I'm not quite ready to turn on setuid yet.  Maybe when I do that,
testing will show something.

The first patch - I have already applied that conceptually.. A lot of
the code is different as I wasn't very comfortable with what was
there.

e.g. When checking that a 'user' mount was in fstab, it just checked
that the mountpoint or filesystem was listed in fstab with the 'user'
flag. It didn't check that the mountpoint and filesystem and options all
matched.
So I think that if you put in fstab that  host:/place was allowed to
be mounted on /foo by any user, than any user could run mount.nfs
directly, ask for host:/place to be mounted on /etc and it would work.

My version is at 
  http://linux-nfs.org/cgi-bin/gitweb.cgi?p=nfs-utils;a=commitdiff;h=ae5ec51e0ddc99dc5552e51bd5c095084dbb61aa

Thanks,
NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-03-18 23:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-26 11:17 [PATCH 01/11] nfs-utils: mount: non-nfs mount options Steve Dickson
2007-02-27  6:04 ` Neil Brown
2007-03-16 15:25   ` Steve Dickson
2007-03-18 23:41     ` Neil Brown [this message]
2007-03-22 21:23       ` Amit Gud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17917.52788.9258.451246@notabene.brown \
    --to=neilb@suse.de \
    --cc=SteveD@redhat.com \
    --cc=gud@ksu.edu \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox