Linux NFS development
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Steve Dickson <SteveD@redhat.com>
Cc: nfs@lists.sourceforge.net
Subject: Re: HEADS-UP: nearing nfs-utils 1.1.0 and statd changes.
Date: Thu, 22 Mar 2007 15:30:47 +1100	[thread overview]
Message-ID: <17922.1655.967323.732476@notabene.brown> (raw)
In-Reply-To: message from Steve Dickson on Tuesday March 20

On Tuesday March 20, SteveD@redhat.com wrote:
> Neil Brown wrote:
> > I have changed the default so that statd now compiled with
> > RESTRICTED_STATD, so that it only listens to locked for monitor
> > requests.  Everyone else is ignored.  There is no-one else who uses
> > statd anywhere, so this should be perfectly safe and is more secure.
> It just occurred to me that this may not be a good idea... Unless
> there has been some changes in the area, turn this on will
> break locking... The reason I know this is that I turned it on
> at one point and people started to see the following messages
> being logged:
>   nsm_mon_unmon: rpc failed, status=-13
>   lockd: cannot monitor 192.168.1.202
> 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=140385
> has the details...
> 
> steved.

Thanks for the info and the link.

It's a shame you weren't able to reproduce it as it means it isn't
something we can easily test for in a new version.

The "status=-13" suggests an rpc-level failure.  E.g. not being able
to get a useful answer from portmap or getting an error from the rpc
client library like an xdr decoding error.
As you say in the bz, it looks like statd has died, except that
apparently it hasn't.

The
  Received erroneous SM_UNMON request from server for client1
messages do make sense.  RESTRICTED_STATD forces 'my_name' to be
127.0.0.1 for MON requests but not for UNMON requests, so unless the
hostname maps to 127.0.0.1, you will get this error.  I can fix that.

But I cannot see how this or anything else that is RESTRICTED_STATD
specific could cause statd to stop servicing requests.

My guess is that a 'netstat -n' would have shown a large queue of
requests to statd that were not being served - statd still there but
not responding for some reason, possibly in an infinite loop, though I
cannot find it.


Hmm... I just noticed that statd sets REUSEADDR on the udp port that
it listens on.  So if another process binds to the same port it will
succeed and will get some (maybe all) of the packets meant for statd.
That might cause lots of 'cannot monitor' messages.... but I cannot
see how it could be connected to RESTRICTED_STATD.

I'm still inclined to make RESTRICTED_STATD the default, to fix what
bugs I can find, and to test it as thoroughly as I can...

Thanks,
NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

      reply	other threads:[~2007-03-22  4:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16  8:00 HEADS-UP: nearing nfs-utils 1.1.0 and statd changes Neil Brown
2007-03-16 12:59 ` Talpey, Thomas
2007-03-18 23:02   ` Neil Brown
2007-03-19 18:40     ` Talpey, Thomas
2007-03-22  4:54       ` Neil Brown
2007-03-22 12:36         ` Talpey, Thomas
2007-03-16 14:03 ` Steve Dickson
2007-03-16 14:30 ` Kevin Coffman
2007-03-18 22:52   ` Neil Brown
2007-03-16 18:10 ` J. Bruce Fields
2007-03-18 23:49   ` Neil Brown
2007-03-19 23:02     ` J. Bruce Fields
2007-03-20  0:30       ` Talpey, Thomas
2007-03-20  1:14         ` J. Bruce Fields
2007-03-20 10:47           ` Talpey, Thomas
2007-03-20 11:24             ` William A. (Andy) Adamson
2007-03-20 14:26               ` J. Bruce Fields
2007-03-20 14:49                 ` Talpey, Thomas
2007-03-20 14:57                   ` J. Bruce Fields
2007-03-20 15:03                     ` Talpey, Thomas
2007-03-20 12:32 ` Steve Dickson
2007-03-22  4:30   ` Neil Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17922.1655.967323.732476@notabene.brown \
    --to=neilb@suse.de \
    --cc=SteveD@redhat.com \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox