Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: "William A. (Andy) Adamson" <andros@citi.umich.edu>
Cc: nfs@lists.sourceforge.net, "Talpey, Thomas" <Thomas.Talpey@netapp.com>
Subject: Re: HEADS-UP: nearing nfs-utils 1.1.0 and statd changes.
Date: Tue, 20 Mar 2007 10:26:27 -0400	[thread overview]
Message-ID: <20070320142627.GC12165@fieldses.org> (raw)
In-Reply-To: <89c397150703200424n4921f619heaa47c13482a215a@mail.gmail.com>

On Tue, Mar 20, 2007 at 07:24:00AM -0400, William A. (Andy) Adamson wrote:
> On 3/20/07, Talpey, Thomas <Thomas.Talpey@netapp.com> wrote:
> >
> >At 09:14 PM 3/19/2007, J. Bruce Fields wrote:
> >>Currently we're *not* doing what the rfc suggests--keeping a record
> >>with timestamp of first open, etc.--instead we're basically remembering
> >>just the one bit per client (is this client known to us or not), which
> >>means we *must* synchronously invalidate every client as we exit the
> >>grace period.  That's awkward.
> >
> >Ah, I get it. It has to be invalidated because the state can't be marked
> >"out of grace"? The timestamp is the right fix of course, but wouldn't
> >a single bit ("known to us" | "out of grace") kinda sorta do it? Then
> >invalidation could at least be delayed.
> >
> >It's a little worse than awkward though. Isn't the server going to return
> >BAD_STATEID after this (instead of stale/old)? The server goes from
> >serving no state-granting ops, to dropping everything that didn't make
> >it back to reclaim in time. The v3 nlm recovery doesn't do that.
> 
> 
> No. The stale stateid check is before the bad stateid check
> (fs/nfsd/nfs4state.c:nfs4_preprocess_stateid_op) - stale stateid is
> returned, which is the correct behavior past reclaim processing.

Yeah, note that the necessary information is in the stateid itself--we
embed the current boot time in every stateid we hand out--so we don't
need to keep around any memory of the client in order to hand out the
correct error.

--b.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-03-20 14:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16  8:00 HEADS-UP: nearing nfs-utils 1.1.0 and statd changes Neil Brown
2007-03-16 12:59 ` Talpey, Thomas
2007-03-18 23:02   ` Neil Brown
2007-03-19 18:40     ` Talpey, Thomas
2007-03-22  4:54       ` Neil Brown
2007-03-22 12:36         ` Talpey, Thomas
2007-03-16 14:03 ` Steve Dickson
2007-03-16 14:30 ` Kevin Coffman
2007-03-18 22:52   ` Neil Brown
2007-03-16 18:10 ` J. Bruce Fields
2007-03-18 23:49   ` Neil Brown
2007-03-19 23:02     ` J. Bruce Fields
2007-03-20  0:30       ` Talpey, Thomas
2007-03-20  1:14         ` J. Bruce Fields
2007-03-20 10:47           ` Talpey, Thomas
2007-03-20 11:24             ` William A. (Andy) Adamson
2007-03-20 14:26               ` J. Bruce Fields [this message]
2007-03-20 14:49                 ` Talpey, Thomas
2007-03-20 14:57                   ` J. Bruce Fields
2007-03-20 15:03                     ` Talpey, Thomas
2007-03-20 12:32 ` Steve Dickson
2007-03-22  4:30   ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070320142627.GC12165@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Thomas.Talpey@netapp.com \
    --cc=andros@citi.umich.edu \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox