Re: [PATCH] nfs-utils: make auth_reload respect sub-second timestamps on etab

[Neil Brown <neilb@suse.de>]

On Thursday April 26, jlayton@redhat.com wrote:
> 
> This patch seems to fix the problem as well. mountd holds the etab open, but
> doesn't actually do any I/O on that fd. This makes sure that the inode number
> of the new etab file won't be the same as the current version that mountd is
> aware of. I also added a comment to xtab_write to warn people who might
> consider changing how the files are written.
> 
> We might also consider adding back in some of the mtime logic to try and
> catch programs that edit the file in place, but I'm not sure if that's
> worthwhile.

I agree.

> 
> Neil, what do you think?

I was about to say "fine", but then saw the problem.
Because of the way get_exportlist uses the return value, that value
needs to unique over all time (or close to it).  So returning the
inode number won't work (as we have seen that ext3 cycles between
two).

A simple event counter could be returned though, which would give
something unique to get_exportlist.

NeilBrown

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs