Re: [PATCH] nfs-utils: make auth_reload respect sub-second timestamps on etab

[Jeff Layton <jlayton@redhat.com>]

On Thu, Apr 26, 2007 at 12:58:00PM -0400, J. Bruce Fields wrote:
> On Thu, Apr 26, 2007 at 12:23:04PM -0400, Jeff Layton wrote:
> > I've had a look at this, and even took a pretty broad swipe at doing it. The
> > issue here is that a lot of the existing code is not well geared toward having
> > an already-open filehandle that gets passed around. Changing this is going to
> > mean a pretty invasive patch that adds quite a few new functions. I don't feel
> > confident that this method has enough advantages over your earlier patch to
> > make this worthwhile.
> > 
> > Neil, what do you think? Should I continue down this road, or should we just
> > go with what you've already written?
> 
> Wouldn't you get the same benefit just by storing (and comparing) the
> inode number and mtime of etab, instead of just the mtime?
> 
> --b.

Not if the inode number is reused. That can occur on some filesystems if
nothing is holding it open. Then again, if we're opening a new file and
renaming it to the old name, then that might not be an issue here. Let me
play with that idea and see...

-- Jeff



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs