Linux NFS development
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Steve Dickson <steved@redhat.com>
Cc: linux-nfs <linux-nfs@vger.kernel.org>,
	trond myklebust <trond.myklebust@hammerspace.com>,
	chris chilvers <chris.chilvers@appsbroker.com>
Subject: Re: mountd: Possible bug in next_mnt()
Date: Sun, 12 Mar 2023 14:36:00 +0100 (CET)	[thread overview]
Message-ID: <1826031117.236924.1678628160815.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <31643f88-26ec-515c-d1d6-fad951248a8c@redhat.com>

----- Ursprüngliche Mail -----
> On 3/11/23 11:52 AM, Richard Weinberger wrote:
>> ----- Ursprüngliche Mail -----
>>>> next_mnt() finds submounts below a given path p.
>>>> While investigating into an issue in my crossmount patches for nfs-utils I
>>>> noticed
>>>> that it does not work when fsid=root, rootdir=/some/path/ and then "/" is being
>>>> exported.
>>>> In this case next_mnt() is asked to find submounts of "/" but returns none.
>>> I'm not clear as what you are saying... "rootdir=/some/path/" is not an
>>> export option.
>> 
>> Sorry for being imprecise.
>> rootdir= is an nfs.conf exports option.Point. But I still need the patch in the
>> correct
> format with the Signed-off-by...

Well, the goal of my mail was not sending a ready-to-apply patch.
It was a question. To me next_mnt() looks wrong but I'm not sure whether
the current handling of "/" is desired for some special case I'm not aware of.

I'll happily send a patch after we agree that next_mnt() is wrong.

Thanks,
//richard


  reply	other threads:[~2023-03-12 13:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 15:05 mountd: Possible bug in next_mnt() Richard Weinberger
2023-03-11 16:19 ` Steve Dickson
2023-03-11 16:52   ` Richard Weinberger
2023-03-12 13:31     ` Steve Dickson
2023-03-12 13:36       ` Richard Weinberger [this message]
2023-03-12 14:20         ` Steve Dickson
2023-03-12 16:51           ` Richard Weinberger
2023-03-15 22:04             ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1826031117.236924.1678628160815.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=chris.chilvers@appsbroker.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox