From: Steve Dickson <steved@redhat.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-nfs <linux-nfs@vger.kernel.org>,
trond myklebust <trond.myklebust@hammerspace.com>,
chris chilvers <chris.chilvers@appsbroker.com>
Subject: Re: mountd: Possible bug in next_mnt()
Date: Sun, 12 Mar 2023 10:20:50 -0400 [thread overview]
Message-ID: <ecfe32fc-f547-ca7f-dc07-018af4d23f39@redhat.com> (raw)
In-Reply-To: <1826031117.236924.1678628160815.JavaMail.zimbra@nod.at>
On 3/12/23 9:36 AM, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> On 3/11/23 11:52 AM, Richard Weinberger wrote:
>>> ----- Ursprüngliche Mail -----
>>>>> next_mnt() finds submounts below a given path p.
>>>>> While investigating into an issue in my crossmount patches for nfs-utils I
>>>>> noticed
>>>>> that it does not work when fsid=root, rootdir=/some/path/ and then "/" is being
>>>>> exported.
>>>>> In this case next_mnt() is asked to find submounts of "/" but returns none.
>>>> I'm not clear as what you are saying... "rootdir=/some/path/" is not an
>>>> export option.
>>>
>>> Sorry for being imprecise.
>>> rootdir= is an nfs.conf exports option.Point. But I still need the patch in the
>>> correct
>> format with the Signed-off-by...
>
> Well, the goal of my mail was not sending a ready-to-apply patch.
> It was a question. To me next_mnt() looks wrong but I'm not sure whether
> the current handling of "/" is desired for some special case I'm not aware of.
>
> I'll happily send a patch after we agree that next_mnt() is wrong.
I'm still trying to reproduce problem... I have
/etc/nfs.conf: rootdir=/export
/etc/exports:
/home *(rw,sec=sys:krb5:krb5i:krb5p)
/tmp *(rw,fsid=666,all_squash)
/ *(rw,fsid=root,all_squash)
I'm not seeing the problem... Where does the crossmount come in?
steved.
next prev parent reply other threads:[~2023-03-12 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:05 mountd: Possible bug in next_mnt() Richard Weinberger
2023-03-11 16:19 ` Steve Dickson
2023-03-11 16:52 ` Richard Weinberger
2023-03-12 13:31 ` Steve Dickson
2023-03-12 13:36 ` Richard Weinberger
2023-03-12 14:20 ` Steve Dickson [this message]
2023-03-12 16:51 ` Richard Weinberger
2023-03-15 22:04 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecfe32fc-f547-ca7f-dc07-018af4d23f39@redhat.com \
--to=steved@redhat.com \
--cc=chris.chilvers@appsbroker.com \
--cc=linux-nfs@vger.kernel.org \
--cc=richard@nod.at \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox