* [PATCH 1/1] NFSD enforce filehandle check for source file in COPY
@ 2022-08-19 19:16 Olga Kornievskaia
2022-08-19 19:41 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Olga Kornievskaia @ 2022-08-19 19:16 UTC (permalink / raw)
To: chuck.level, jlayton; +Cc: linux-nfs
From: Olga Kornievskaia <kolga@netapp.com>
If the passed in filehandle for the source file in the COPY operation
is not a regular file, the server MUST return NFS4ERR_WRONG_TYPE.
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
fs/nfsd/nfs4proc.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index a72ab97f77ef..d8f05d96fe68 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1768,7 +1768,13 @@ static int nfsd4_do_async_copy(void *data)
filp = nfs42_ssc_open(copy->ss_mnt, ©->c_fh,
©->stateid);
if (IS_ERR(filp)) {
- nfserr = nfserr_offload_denied;
+ switch (PTR_ERR(filp)) {
+ case -EBADF:
+ nfserr = nfserr_wrong_type;
+ break;
+ default:
+ nfserr = nfserr_offload_denied;
+ }
nfsd4_interssc_disconnect(copy->ss_mnt);
goto do_callback;
}
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] NFSD enforce filehandle check for source file in COPY
2022-08-19 19:16 [PATCH 1/1] NFSD enforce filehandle check for source file in COPY Olga Kornievskaia
@ 2022-08-19 19:41 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2022-08-19 19:41 UTC (permalink / raw)
To: Olga Kornievskaia, chuck.level; +Cc: linux-nfs
On Fri, 2022-08-19 at 15:16 -0400, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
>
> If the passed in filehandle for the source file in the COPY operation
> is not a regular file, the server MUST return NFS4ERR_WRONG_TYPE.
>
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
> fs/nfsd/nfs4proc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index a72ab97f77ef..d8f05d96fe68 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1768,7 +1768,13 @@ static int nfsd4_do_async_copy(void *data)
> filp = nfs42_ssc_open(copy->ss_mnt, ©->c_fh,
> ©->stateid);
> if (IS_ERR(filp)) {
> - nfserr = nfserr_offload_denied;
> + switch (PTR_ERR(filp)) {
> + case -EBADF:
> + nfserr = nfserr_wrong_type;
> + break;
> + default:
> + nfserr = nfserr_offload_denied;
> + }
> nfsd4_interssc_disconnect(copy->ss_mnt);
> goto do_callback;
> }
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-19 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-19 19:16 [PATCH 1/1] NFSD enforce filehandle check for source file in COPY Olga Kornievskaia
2022-08-19 19:41 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox