Re: [PATCH v10 2/7] nfs/localio: avoid issuing misaligned IO using O_DIRECT

[Chuck Lever <chuck.lever@oracle.com>]

On 9/18/25 10:15 AM, Anna Schumaker wrote:
>> diff --git a/fs/nfsd/localio.c b/fs/nfsd/localio.c
>> index 269fa9391dc46..be710d809a3ba 100644
>> --- a/fs/nfsd/localio.c
>> +++ b/fs/nfsd/localio.c
> I'll need an acked-by from Chuck or Jeff for the NFSD portions of this patch.

Doesn't this series need

https://lore.kernel.org/linux-nfs/175811950708.19474.3966708920934397510.stgit@91.116.238.104.host.secureserver.net/T/#u

as a prerequisite?


> Thanks,
> Anna
> 
>> @@ -117,12 +117,23 @@ nfsd_open_local_fh(struct net *net, struct auth_domain *dom,
>>  	return localio;
>>  }
>>  
>> +static void nfsd_file_dio_alignment(struct nfsd_file *nf,
>> +				    u32 *nf_dio_mem_align,
>> +				    u32 *nf_dio_offset_align,
>> +				    u32 *nf_dio_read_offset_align)
>> +{
>> +	*nf_dio_mem_align = nf->nf_dio_mem_align;
>> +	*nf_dio_offset_align = nf->nf_dio_offset_align;
>> +	*nf_dio_read_offset_align = nf->nf_dio_read_offset_align;
>> +}
>> +
>>  static const struct nfsd_localio_operations nfsd_localio_ops = {
>>  	.nfsd_net_try_get  = nfsd_net_try_get,
>>  	.nfsd_net_put  = nfsd_net_put,
>>  	.nfsd_open_local_fh = nfsd_open_local_fh,
>>  	.nfsd_file_put_local = nfsd_file_put_local,
>>  	.nfsd_file_file = nfsd_file_file,
>> +	.nfsd_file_dio_alignment = nfsd_file_dio_alignment,
>>  };
>>  
>>  void nfsd_localio_ops_init(void)
>> diff --git a/include/linux/nfslocalio.h b/include/linux/nfslocalio.h
>> index 59ea90bd136b6..3d91043254e64 100644
>> --- a/include/linux/nfslocalio.h
>> +++ b/include/linux/nfslocalio.h
>> @@ -64,6 +64,8 @@ struct nfsd_localio_operations {
>>  						const fmode_t);
>>  	struct net *(*nfsd_file_put_local)(struct nfsd_file __rcu **);
>>  	struct file *(*nfsd_file_file)(struct nfsd_file *);
>> +	void (*nfsd_file_dio_alignment)(struct nfsd_file *,
>> +					u32 *, u32 *, u32 *);
>>  } ____cacheline_aligned;
>>  
>>  extern void nfsd_localio_ops_init(void);

For the above hunks:

Acked-by: Chuck Lever <chuck.lever@oracle.com>


-- 
Chuck Lever