Re: [PATCH v10 6/7] nfs/localio: add tracepoints for misaligned DIO READ and WRITE support

[Mike Snitzer <snitzer@kernel.org>]

On Thu, Sep 18, 2025 at 05:07:55PM -0400, Anna Schumaker wrote:
> Here's my .config file. Maybe it'll help reproduce the issue?

Using your config I was able to reproduce on EL9 with gcc 15.1.1-2

The key clue for me was:

  CC [M]  nfs2xdr.o
In file included from nfstrace.h:11,
                 from nfs2xdr.c:26:
nfstrace.h:1796:31: error: `struct nfs_local_dio´ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
 1796 |                  const struct nfs_local_dio *local_dio),\
      |                               ^~~~~~~~~~~~~

This fixes the issue for me, please feel free to fold it in.. its the
same issue I had with nfs3xdr.c (I audited the other files that
include nfstrace.h, it seems all others include internal.h first):

diff --git a/fs/nfs/nfs2xdr.c b/fs/nfs/nfs2xdr.c
index 6e75c6c2d234..9eff09158518 100644
--- a/fs/nfs/nfs2xdr.c
+++ b/fs/nfs/nfs2xdr.c
@@ -23,8 +23,8 @@
 #include <linux/nfs2.h>
 #include <linux/nfs_fs.h>
 #include <linux/nfs_common.h>
-#include "nfstrace.h"
 #include "internal.h"
+#include "nfstrace.h"
 
 #define NFSDBG_FACILITY		NFSDBG_XDR